Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/2] input: imx_sc_key: add wakeup support
Thread-Topic: [PATCH 2/2] input: imx_sc_key: add wakeup support
Thread-Index: AQHZXWmUVLJFWxBDC068h5KGnJZKqa8j7hEAgAPIhwCAAD2TgA==
Date:   Wed, 12 Apr 2023 15:58:40 +0000
Message-ID: <DU0PR04MB9417185EB8243ED2D60A6E43889B9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230323093141.4070840-1-peng.fan@oss.nxp.com>
 <20230323093141.4070840-2-peng.fan@oss.nxp.com> <ZDN00vwyCOzFrDYt@google.com>
 <DU0PR04MB94172C2BBB554E472576B2BA889B9@DU0PR04MB9417.eurprd04.prod.outlook.com>
In-Reply-To: <DU0PR04MB94172C2BBB554E472576B2BA889B9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ac5rjiRCO3/d+WnBFtnnKvP+Vr7JNpd3aTr67YQ8eWQUWdUyFx8bSvgpnp6?=
 =?us-ascii?Q?UzoQagIORzCJEyNVpsll0RXhsdOCmfbpV0XA2RS8yS+JxmnzRJPhG/t1tAnG?=
 =?us-ascii?Q?wXdqDyG4SeHf4YRNVUC5baCZQWCoGdJ7pJlk+ySviO6wAgV2JeUem18ZUSOX?=
 =?us-ascii?Q?2Js+w/uV/DOvoP98uXx6om6skHlLyNAXOxy0TasGUL4ZnLuMiuOj2LX6Y+KA?=
 =?us-ascii?Q?7t1d8J0/fNB9LJ+FUgb3uQLJd9dGZC9D3bBl9h7pm/GM2x6ZkQ838HLP6Cb3?=
 =?us-ascii?Q?Nn+W1NIXRn9Rhl7Ksgm5GODA5u2ftash3MSbRpXPPEMXLGIRMm9S3lDpoHHJ?=
 =?us-ascii?Q?9MHLzlTpjeC17kul3gchzRLdBvMNfwIV6l5swHI6MkdPmReLfk6JR3trSoFL?=
 =?us-ascii?Q?dAM7LxeZWTdXXUFiC70SQ3qdEhFevz8ht01y/6xshH3F4A6B6CCFcHxhvQAZ?=
 =?us-ascii?Q?OpB/c5LojqKj22GUlonup7LQJYNu9YUkso6ylmgOtZ9H5GLmS/h2Ub91gCaE?=
 =?us-ascii?Q?gZDL3c7dWdaYr2syi/jjrIzd2zQGs8oMrwjflhZSx7Np3tk7atCZbXb5Ip7o?=
 =?us-ascii?Q?kPoZJvgSSEgsH0tHsQEHvZW0ImVds8PGlKlAkT/9yTUaB+NYf9OO83uoGueo?=
 =?us-ascii?Q?8IamJgXeSo8WIbjAg6U/u6OO7iFNtgXrXgPde6MuziSqkjUzzVyHxEbns5Ee?=
 =?us-ascii?Q?nVP7pcgjnG/SRfOEZLeDOOkN6JE45VVPZ8TS8CweFOhNktMIJDJjeYi03gU4?=
 =?us-ascii?Q?b7PGdaNdo05JGhpsVjknQbijXCjfBFzrH/jvk5dv4rQyPgfYOAHxt5jGygoA?=
 =?us-ascii?Q?f2S/ib/SLWBsGqE0PQe/wmsMQyBCMGyT6WqXoHxLC9JFaBZCEf+j2b0uLBPr?=
 =?us-ascii?Q?owHlDgg9H0TFHWxhYSD28Fx3J8MTxeAQQM1q2MbCwZn+nvoIIj+7Ic+oADZe?=
 =?us-ascii?Q?QosN5BIy8WIqjSNDnyyO8OiqL1ogVf+aoreUv3uv/LdsJnqMoHOnokigI2/3?=
 =?us-ascii?Q?JJEfYct3qyQ0hPYJWukOHtoV/Q9Zjh4dVxdz5O5Xxl+OIjFtGXnEaSa3mtLV?=
 =?us-ascii?Q?RlkDcaoVyw0vjWUTtpzOsH6PnyTc1Zo7NYbHqoKotNHQOnJ6L9DRNkTxr8T/?=
 =?us-ascii?Q?GYK7yVVysJy0EOWS+kdRYbiHxgWqw53hLTlK2CEWkz5w11N9qNwe6UInVOLy?=
 =?us-ascii?Q?lIeps2kcLNK+TNXKyPWR5jCSjM1sPaw/m8d/DR+RXw5sujkl3spAxuyTeKCa?=
 =?us-ascii?Q?fpV+6LzfXOiBMTtTDj7DeX5gUDwX44lskwgtlRaAonL6gfJXlNv8N4COxhcf?=
 =?us-ascii?Q?9qpRX0bscsere2K+DT4Xky8FznDZYEuNJhipU5qhpoN2VZYftb96e1CItqAM?=
 =?us-ascii?Q?tm++HvUreGSuwpfSKvYtzAqBEn5dcq/HpJZiGbbUOwV0mzbyvhtPULFPGpuT?=
 =?us-ascii?Q?6J9pUAB3DCuTgeEAX3jEa3OUSCicHrYDTddKQzv53ao1r3wRhNSUOb8FhLPr?=
 =?us-ascii?Q?IYcfrXaEGMgkd0d4II7WkSwx/LFlU+S6/Hb7CSqCO2wJos8xaPL1AsF0NOcE?=
 =?us-ascii?Q?RPUExNXeW52TzLyMWO4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee2187d-7a98-4a2a-311e-08db3b6ec8e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 15:58:40.5496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iil3ZOX/QLDjc27eWsKxfBaAJ0L/qgk0ObIhMcvNaFrNgjiCgoo9OUFcSfT/80hlw3uZOiIMgQmnifdc/alfsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7714
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Ulf

> Subject: RE: [PATCH 2/2] input: imx_sc_key: add wakeup support
>=20
> > Subject: Re: [PATCH 2/2] input: imx_sc_key: add wakeup support
> >
> > On Thu, Mar 23, 2023 at 05:31:41PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Add support for waking up from system wide suspend.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  drivers/input/keyboard/imx_sc_key.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/input/keyboard/imx_sc_key.c
> > b/drivers/input/keyboard/imx_sc_key.c
> > > index d18839f1f4f6..234f23cf9990 100644
> > > --- a/drivers/input/keyboard/imx_sc_key.c
> > > +++ b/drivers/input/keyboard/imx_sc_key.c
> > > @@ -151,6 +151,8 @@ static int imx_sc_key_probe(struct
> > platform_device *pdev)
> > >  	priv->input =3D input;
> > >  	platform_set_drvdata(pdev, priv);
> > >
> > > +	device_init_wakeup(&pdev->dev,
> > device_property_read_bool(&pdev->dev, "wakeup-source"));
> > > +
> >
> > I wonder - could we move this to the device core?
>=20
> I see lots device drivers parse wakeup-source, so I also follow That. Not=
 sure
> whether could move this feature to device core, but anyway I could give a
> try.

Do you think it is feasible to move device_init_wakeup into device core
part?

Thanks,
Peng.
>=20
> Thanks,
> Peng.
> >
> > >  	error =3D imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE,
> > SC_IRQ_BUTTON,
> > >  					 true);
> > >  	if (error) {
> > > --
> > > 2.37.1
> > >
> >
> > Thanks.
> >
> > --
> > Dmitry