Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 19:00:02 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <ZDbVgqV9JT7Ru96j@shredder>
References: <20230410204951.1359485-1-vladimir.oltean@nxp.com>
 <ZDa856x2rhzNrrXa@shredder>
 <20230412142733.6jhxt7kjf3nwqzsy@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412142733.6jhxt7kjf3nwqzsy@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RaE+ENsLkMrti5sMYwbHLqtYeI1infFNTA0JifzK5KChL8+Wgz7cowqUmslz?=
 =?us-ascii?Q?ElYd6Z4l7L2cP3O/1yqrbJfUTfGmLX2guspLbIPjcq9laKNJf0paAscHePvm?=
 =?us-ascii?Q?X1XYuOMFTNru+VohWWdaSSYcxf49BEr968JHorEOYmjngDpDOsv0D9CaMbvd?=
 =?us-ascii?Q?b1OdW6rMGC8bGiK8sxk/aDzTUOGDONBrBKzJmBoipVxYWO89iBZ9BwdbXE7y?=
 =?us-ascii?Q?4E3IVU4cr22jFdraNX562ujDfdIfkfshZJxpGfmxBNsbpnntfAWaanLqdrtD?=
 =?us-ascii?Q?XMVyytwT+CaztnaOqTKF/JTdB5qL2NAUuGS3YpspSiIxFcPxt9O2IDloSW3R?=
 =?us-ascii?Q?hGD9TUzND8m3PkhFeQ4XjawqATqlK/yIE60shUUpguFmJoL5qxunXce0XTjl?=
 =?us-ascii?Q?W3Pvzp2bLJBfOQ9IJJhvT9LkHSLoEo6Zdw2hBs+i87CdrRewYb5hNKjXpwcg?=
 =?us-ascii?Q?z67Bx50CNkfax7iUHV53eSHEu0cjAC628aqJgrlrd8sgIIcvEoRSiXO+p+wN?=
 =?us-ascii?Q?Q3rFG9AxF8FETWB830tfkqmU3fL7MHlWPyKMx+qE5O4dHvvucKmk+rwly1eb?=
 =?us-ascii?Q?+dv+ERSqJ9Besl9f4Cw3BM0VxgygfKLAl3rwcybGTAurTzxeAk0Day9wyrwJ?=
 =?us-ascii?Q?E/NulvudOMXiQ6XRgIamTGzv0AZZ4zZoFjF0QSQzOII//H9khSgXwFphknWd?=
 =?us-ascii?Q?weUq7xF7nHAmYdX9EWv/B1s/IpI2ES7fPf6XjMwHXZEBwPCxK8cjgE45XIMu?=
 =?us-ascii?Q?TzPBHWzA3fHq6YtyZYmZiGB0c7Cf/r6eafAVpY6rtcoMKJ/CJXVosbigpq/k?=
 =?us-ascii?Q?ahrnVsf60/Xd8lwK1nypS0PZYq//BBqbJBFSC+vJBDp84u+ItB0IongJlm/d?=
 =?us-ascii?Q?dLK/hJgBes4Mfnag4OjCbIJXyrb+6DVP9ztpsI5IURga0NRiSsuWR3fLiwDb?=
 =?us-ascii?Q?8eYGqGkKdZEc7U0xmqGHUZdDC9wtvrxlohBB+0QAqqQ7DTz86jdgxnvUDE7X?=
 =?us-ascii?Q?kUvbXeihviAB/NrPOy20N7a4du6f7QpXWxzm5ywl4P0RJjGgljQHIdM9Eudx?=
 =?us-ascii?Q?kX1DMmPLvqH2EXL0DGjFjitFpwyExxVUoAcG2DzM1nyUTLOKo6slTlBHKOeB?=
 =?us-ascii?Q?piC1/WmwEWZ9bVVuPwYfPGNzvCNj8PjtBvAYGyPbBnrlJl/HpEJd/5v3Ym8M?=
 =?us-ascii?Q?5RbfNTtVnerIdm8v1OTRbfQspAqRKiS1OsR6TIfNloNSPBLSuFRvuhgX5Olw?=
 =?us-ascii?Q?1VYY+nWnnk11ZyTJmPifmZT3lgiB2rQwgGlHakH/ho+ncSI+jGkTHJoIjjrq?=
 =?us-ascii?Q?+iX7Lz8kEUINcCu24zOyzFpSuFRpAeNxWsKN5qLi1TXEMyEMQ6Ww/c7Vs+wo?=
 =?us-ascii?Q?RgRAysCpRgiNojthNFxr2vL2cMAFpxKIUPS55oKVS94mN1uEgdA3lUxtpab6?=
 =?us-ascii?Q?Ou384kkJPa/Ti2NbctQd6+lPjSMhOjh/oZ5fF/iQrqsokieSJQIUR5noMojW?=
 =?us-ascii?Q?hsN0GG5BK6HIV5Nun/9H90e79NHf4HTsbWBeUjQN2AKXU7zNL1dJvN7xFxqs?=
 =?us-ascii?Q?ceqRB1E71tCd4kEHykWtgAP9KqLWUdPI4NLCWWgw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bf7df63-0433-4ef6-3e74-08db3b6efd4b
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 16:00:08.6804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5gsocLHAZvFSx3uwLNre4D25Gz3mT55aiz1YU13zgB+ZvI4ElZoNgj9iukryXQbVKWTMWN6B52vRKvMGDgLowQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8852
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 12, 2023 at 05:27:33PM +0300, Vladimir Oltean wrote:
> How are extern_learn FDB entries processed by spectrum's
> SWITCHDEV_FDB_ADD_TO_DEVICE handler?

No different than "BR_FDB_STATIC", which is a bug I'm aware of and
intend to fix in net-next when I get the time (together with all the
other combinations enabled by the bridge). Entry has ageing disabled,
but can roam in which case it becomes age-able.

TBH, I think most devices don't handle "BR_FDB_STATIC" correctly. In the
Linux bridge, "BR_FDB_STATIC" only means ageing disabled. The entry can
still roam, but remains "static". I believe that in most devices out
there "static" means no roaming and no ageing which is equivalent to
"BR_FDB_STATIC | BR_FDB_STICKY". Mentioned in your commit message as
well: "As for the hardware FDB entry, that's static, it doesn't move
when the station roams."

As it stands, the situation is far from perfect, but the patch doesn't
solve a regression (always broken) and will introduce one. My suggestion
allows you to move forward and solve the "dynamic" case, so let's
proceed with that unless there's a better alternative.