Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 19:49:17 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <ZDbhDUDs0RUWVZ4B@shredder>
References: <20230410204951.1359485-1-vladimir.oltean@nxp.com>
 <ZDa856x2rhzNrrXa@shredder>
 <20230412142733.6jhxt7kjf3nwqzsy@skbuf>
 <ZDbVgqV9JT7Ru96j@shredder>
 <20230412162407.xk3okeiedylv6sqp@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412162407.xk3okeiedylv6sqp@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dAQ14cdUMtTh64unHxvN4Kj5E3x/HThQoMs99AMp7JhU+o/+1zrSom+vVLJ+?=
 =?us-ascii?Q?Gtw8xEQoBGwwEOs20duCXsGOLk9Tbwjoa80LTDesYyRVBHO2uUduPKqSMQ6P?=
 =?us-ascii?Q?yqnstzjz3MqIshRJVLSFn6HthbKa5C+wQoSWBKCAWglZnzWDhrp/oLze9R8V?=
 =?us-ascii?Q?GWARd86EBMa4z7XoQ+ANpxEcMX8dzQi7XJAfQEZBi52ejIoyr82dTimaY+Fb?=
 =?us-ascii?Q?qB4kFS0OEmp+SceEC8JnPxtu9ltn5a8H8HujMeSAYxKl4imfLCJOr+dYk4+q?=
 =?us-ascii?Q?dqur6YHWeqsIxl98Poq3Xqbi3GD7UrubDKMgGgZmPgYWLx+ilkfo/YIqyDDU?=
 =?us-ascii?Q?8nT0eGqntevfNlH4wVjsivtFd6imAFtk8sYBWzEEAXter2nsCG8AtEw0HIkd?=
 =?us-ascii?Q?bTWORhFcEmR3To11F3qNzPqSDh2rJLK5Fdt244oNSXRkjsVGnGVdzXO6Lmo1?=
 =?us-ascii?Q?F6hICp3Kj3CtSwWvhY42wue7wqnTH/k3O/pE94mdpxOPwcUJkaCb0AY527fT?=
 =?us-ascii?Q?sqJxN4aNBR4DURJXPkq8HbZNwu3grWutxCsWZOBpRyUltcJoVNnvV9PnaC09?=
 =?us-ascii?Q?GrCnJI5eZ2LDgTH9JzLutnT2Cd3+uEmbrmuKqQxO0imDHgbVssgsvHjupcwt?=
 =?us-ascii?Q?hXTw18qfdpH6AQcKvRwn/JxqnYj9KKtFVItlDJ3y3RTCtFlN2PvceNpJhLDR?=
 =?us-ascii?Q?dCRNwG7LaOkvgWFlVOTGcuX/wQlLxXB0wt07VmgX2iezSE5EjQb1KRvWjLBV?=
 =?us-ascii?Q?EMlE39Ei18kY+qYq6G+KAH9lm2XqHWzS5gLDHPhTbU4jU31rJq0dZJnrUzkE?=
 =?us-ascii?Q?3fcLR8aefYLsLFK9i9PlepQlTnzadN6O67+T4kJ2CMwxv1e5HmdCw9l/Prtf?=
 =?us-ascii?Q?DCxcxDGFNdw19WVv/KQ6lKJTihD2SqlMGcjRvndOTDjZSLubgO0VZ4ZZ5wuc?=
 =?us-ascii?Q?g538Y1CI2WMQJrKEfSdUvFEyzWslTBBi4jz/9GFebsxzeUg347XaF9tMbrKZ?=
 =?us-ascii?Q?Zp3uRMdAo+35df7Fp088qv+FlHw6Tf/2YhTAtgMYCgtgA4/zkIj99z/kRA8B?=
 =?us-ascii?Q?MMtDYP54SuvCdE0TLKU5d5eMWf93BZ/VRbr3SQEVWOWz3ZOKIgUwqItPQxTP?=
 =?us-ascii?Q?EVyMBcgqbl9hxQGh6SKJA/4AgYGzquczdDNbxfUNT9k4WkvjgO3G0FuSZ1j3?=
 =?us-ascii?Q?30N3B3mN3eqmjoal6VrRxXxA/WspswJbZcNkK+aNzgPGx+YkfV07T+DN6hi4?=
 =?us-ascii?Q?6oT61Y2GBj3tuS/6O9qpbt3iZ5mCnWMUPRPXhnkXnXWkPs+NkL8WZDDeQMwf?=
 =?us-ascii?Q?h3jWB5krCKxSWvs5pqXXmBa+SZ9fNqLYzz/1tr94NHuQ8QqVropiIkxVheQi?=
 =?us-ascii?Q?Isg9A2BY4HVtMjtvZ3GmUVxKvqacSNmogtOoxEZX+N4lY6YBavCgK+8M8rQK?=
 =?us-ascii?Q?u8Q5PVmejDbdfvQxJ/+1hJ1Zn+Cg1/8hvRGsz2GardJe0JqouB1GUXTud/Hd?=
 =?us-ascii?Q?ayw20Hp6fUNwbieSo3z9G/jkpNZboG6ALFuJ0F40rLz/56aVxspsQXzwtGRE?=
 =?us-ascii?Q?73nO4pfPqwSLjFAXUmVqUYh4erptUlxJwKMDdM3t?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0501784-6b64-4937-05e9-08db3b75deb3
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 16:49:24.3064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FsJ4d/PhsGY3fd/cDZlDZBHxF+VQg9VQCfAT/f/X9blWYo4m8MnIY4uFNr2O2RHnWHW3BGKpfLPWXkpiRHlg3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6414
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> notified from switchdev.
> 
> Unless you have any objection, I won't send v2 like this:
> 
> 	if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> 	    !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> 	    !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> 		return;
> 
> but like this:
> 
> 	/* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> 	 * using 'bridge fdb add ... master dynamic'
> 	 */
> 	if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> 		return;

LGTM. Please copy me on v2 and I will run it through regression. Will
try to report results before tomorrow's PR.

Thanks!