Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 20:04:37 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Ido Schimmel <idosch@nvidia.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Arkadi Sharshevsky <arkadis@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <20230412170437.26nwldbxydm7lgxm@skbuf>
References: <20230410204951.1359485-1-vladimir.oltean@nxp.com>
 <ZDa856x2rhzNrrXa@shredder>
 <20230412142733.6jhxt7kjf3nwqzsy@skbuf>
 <ZDbVgqV9JT7Ru96j@shredder>
 <20230412162407.xk3okeiedylv6sqp@skbuf>
 <ZDbhDUDs0RUWVZ4B@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZDbhDUDs0RUWVZ4B@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3DSmyK8JZAJrGU/rgoEn3CYOTkGOOWUSwDuIlsS9uJNcPBRvb6+ecwPMebQp?=
 =?us-ascii?Q?zfqO0eIAAxFS9/7+ZiemXRpxGWu3Lodndp/28kr4lHWW6G+3RyB7tUiDWJ9a?=
 =?us-ascii?Q?zjqjoJFcGXSK5rRj2fqSwG+bxwFxVIr5ZUD0HB+MvYZll8oJ54lOMrn6l54u?=
 =?us-ascii?Q?roUi9Z/wc0mwnQNlxE1BW6Is6ejiRpj/V+GWoCX+vCJTECMCziHzw6NdIbse?=
 =?us-ascii?Q?LDPSLtFb1Ekpy0rVd1Jn/Z3HGhDdYktx6k9MkR0ZT2yKXolNn4wuQQUjzGsO?=
 =?us-ascii?Q?LL9i972g02Q6CJHUnKRnV7Hmxc9rBC+lhY/gYhpjob+1Aw7l7dIVSJYZ6FZ+?=
 =?us-ascii?Q?tgzgQvKMx+JgRJJ/N7dQM724toBg7LhLJ7UaiN3x/UV3kwPDl3F/CgZvsku1?=
 =?us-ascii?Q?KcVFAynvvtif1HsFCxZDpSndfDsWWSQPYizArButDssgqRB27JIMGkoE1jTV?=
 =?us-ascii?Q?6A+uRtR/APtzFY571EFT6i0JaFqWuTNn5+OhBzrTpWzJOXGO8ZsWxZBaBuJS?=
 =?us-ascii?Q?A5TM+5L2KOPlhbFdqP3kcQqtGh+vETK55nTxzPW6pFJNEjf7pVLyiQ0dHQAq?=
 =?us-ascii?Q?DWEeOxrqIeilZ2xwK+AyULAs4iLpPnxGiExPWkKyY/QDcmWybolVsTzB2PsS?=
 =?us-ascii?Q?kQHS2qQYYzlYYizLk8da0ABW7eziy4LR84fdFqwNquXm59BZfUpbgizXbZLu?=
 =?us-ascii?Q?ZUHmAyjvjvglOIoykEEN2MlOeFE9a3tuAhNz3t6kv25Wo3vnVDduPwOsYhPp?=
 =?us-ascii?Q?d8gbDL1FfiWjforIjjRvjXAoSJKqwSQkCewZMd/Cxafy51HpaQ+ycK7NgcZ0?=
 =?us-ascii?Q?P31VWUqyCHxPoO8TQR56cfjmCZTv4UMxIHLbGPQJf++VQjZ8RTP59hNlwrl4?=
 =?us-ascii?Q?29LHEVAE9wtCOQsoY0ddzDWdVoLE2r2j/+yHnFYkzMDzlLDL3gDoo9gWembs?=
 =?us-ascii?Q?LzFvLZNzpbzltvdsjbEShcZ825KaTmRXzLiOgcTaaJ9xnTBz+EbzH2vFxzj6?=
 =?us-ascii?Q?i2P4ph3hSxgQDFNXLNQLlUE06smloTdfHsEPjmxzYXJ034bfo6AmTUNp5f0z?=
 =?us-ascii?Q?sjryvbCp+21F1xTmN/f+4MhsbrBxRr9J95QNlUhI/oQNd7BJMmtBgxEU6Hu3?=
 =?us-ascii?Q?4QnWH8fnfGbcF2WEIf2FrfTrs6iOQMYID85NsNDbCdjC56vWspjZME0aLcDC?=
 =?us-ascii?Q?x9If+narAEEgX7cBq2dYm7s2N7dnUEqndsNPPHbjS90VIuvnDdEM23ZZmXP1?=
 =?us-ascii?Q?+lsyehF2VjyxN0/TmQKvUnqaewn2ga6klCgmU7KLDJA2vyY5KV9OQHmqVSqu?=
 =?us-ascii?Q?Q/oBxkBQDDk8GQYWUvpqVATyH9fNoI+18L+158GDEE+GpuRZYW1d9zZRfBQ/?=
 =?us-ascii?Q?jP6MAPKwuUFmzbJ+Pj+zIUh1NxGToeiIf5kuFdli3DfGHkpnGU5EC9C6mwPn?=
 =?us-ascii?Q?lcYVd8Ps63/miAYjHtAGD/ZPupW9ONPar5q7+wJmOU67PLxrD5uxA/VKmbar?=
 =?us-ascii?Q?gUcmT5u1PO5sYB25doKa6+lorRYJ/Cjz9tz0c8xshV7YCJRexPkLeZHNQ8pe?=
 =?us-ascii?Q?PsOKoepdn/4bqo3ggoNx07XzBiIJYZMTwxoLUqGp8tlerySbH1G6CE1TFGX6?=
 =?us-ascii?Q?ng=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d7b701b-f0f2-4718-6d2a-08db3b780167
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 17:04:41.0942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9ne9MxSvLhuS2ixu8DXqm2UPwK8IeU6/3qDIneM9SieAJCyJB8SzvlGkQB27o2TBwyqXtUGYvVFV48e5sgghNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9489
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 12, 2023 at 07:49:17PM +0300, Ido Schimmel wrote:
> On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> > I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> > notified from switchdev.
> > 
> > Unless you have any objection, I won't send v2 like this:
> > 
> > 	if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> > 	    !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> > 	    !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> > 		return;
> > 
> > but like this:
> > 
> > 	/* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> > 	 * using 'bridge fdb add ... master dynamic'
> > 	 */
> > 	if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> > 		return;
> 
> LGTM. Please copy me on v2 and I will run it through regression. Will
> try to report results before tomorrow's PR.

Sorry, I won't send the v2 early; I need to think more about this and
I don't want to rush things. It's likely that the zero-day bug fix will
miss this week's PR.