Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1292900rwl; Wed, 12 Apr 2023 10:36:55 -0700 (PDT) X-Google-Smtp-Source: AKy350YbfPDJ4SEjEOpZOGuCXs959H6uC0ruST9wmn3p2cX4G1g2tZsFbP+fQnVSL2yendz+pit8 X-Received: by 2002:a17:906:18a2:b0:946:a1c8:e000 with SMTP id c2-20020a17090618a200b00946a1c8e000mr13938363ejf.44.1681321015539; Wed, 12 Apr 2023 10:36:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681321015; cv=none; d=google.com; s=arc-20160816; b=t475QkaxI/VfnQpJLImOJMqYo6sTzFu8PoJiJgH3uX/8ogVsOoozHwU8e1x3JDkF5A MM4SX+oeYxrPyBrdc0DKFA8AIXnRchubI353yTP887BMnElQ7v/bRts5+MWsT1BcS+Ml qxTBmlJP+mTQ6fBxPpbwDtPbR1IBZnUyW318QKU/DpmWtB9VZ4tCvxHsTxACAxhEvZwe rAze58V0hcYeym43HmozGUbHeAywoE5qYgqBdJhz2gZouhbMakqO2Ov95kkQ+ieLk5Mg Y7AGCsgeqB/rLlxsNQ56v9zTTbPLgLyD7mrc0QtAsD+Qdiu9QaW8HvVpktixoxqiag9e pmLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eDsJKP/nGXpuhW2laNrTf89QCVE2yIjy2OL7YXFWnIU=; b=bn0LfmynJjqjUoV52dQ7u1vs0xB+0TK78b9akRtKSwnPxXPUsUzOk8EsgbE/1otnir 3tMEXwNOpZkbwVDBsMAnNcg1NNPzrgljlU6kjN77zJcn0HM8+JwlId/3uW+6BQ/sgn6H 563I8y7CzhmwM9SUkc9ByXnvgf2HUhHIzQHli6IOnHDkOoLTJ0XW+A1RLjIUawUOoxLb 1F17QIF8lc9et2aJnWDbdSz76QENZRCW/F8v6cSoATElS2mpaCOKKyYzvaZjUl4ciwon Brphz/7BBodBYF24pKsgh3wEENbrXXKh8sHCndPzBuWLEi93D0PMn5oLyIU9RkW+1Iv5 SgFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/0lStm0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp6-20020a1709071b0600b0094a972d045esi4726623ejc.1015.2023.04.12.10.36.30; Wed, 12 Apr 2023 10:36:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/0lStm0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjDLRYU (ORCPT + 99 others); Wed, 12 Apr 2023 13:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbjDLRYQ (ORCPT ); Wed, 12 Apr 2023 13:24:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFFD31726 for ; Wed, 12 Apr 2023 10:24:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 869B1637CC for ; Wed, 12 Apr 2023 17:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD300C433AA; Wed, 12 Apr 2023 17:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681320255; bh=40bQAl7b9ZRfFX150jDT4Y2Aky1kTJSd3vkEWMdjKys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S/0lStm0fcgmo7O/BpzPF+J6qdMt8uKX4RF6V6vpfoaXb28wNlJpphDYIJwnLZtem 830qJt9OGn8zMRl6slScF7ONK1esfYPEC9AgaWjmtsi382hw+NCQImblNHRZkpPUlT wJ+Y9/2sxgvNV410VG6bCPzmeWZikIbM7Boa+mzaDr54jzqgsEXsp8PKaIn3GiZHkt MPywY/uh5qZy74BxqlE/9gR2cCXW7VIdOCM0gzTr165TeeJeWCvZt+Jrd/JL6u+0/L vk/Uxq4XkTkmmoqHWZjYa3rDWOiQQnU4Ft2WzZybBMap0d2sUM+4aSq1TfnV8cB1T2 0xxIuoj3/ujYA== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , frederic@kernel.org, paulmck@kernel.org, keescook@chromium.org Subject: [PATCH 2/3] sched: Fix KCSAN noinstr violation Date: Wed, 12 Apr 2023 10:24:07 -0700 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With KCSAN enabled, end_of_stack() can get out-of-lined. Force it inline. Fixes the following warnings: vmlinux.o: warning: objtool: check_stackleak_irqoff+0x2b: call to end_of_stack() leaves .noinstr.text section Signed-off-by: Josh Poimboeuf --- include/linux/sched/task_stack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h index 5e799a47431e..f158b025c175 100644 --- a/include/linux/sched/task_stack.h +++ b/include/linux/sched/task_stack.h @@ -23,7 +23,7 @@ static __always_inline void *task_stack_page(const struct task_struct *task) #define setup_thread_stack(new,old) do { } while(0) -static inline unsigned long *end_of_stack(const struct task_struct *task) +static __always_inline unsigned long *end_of_stack(const struct task_struct *task) { #ifdef CONFIG_STACK_GROWSUP return (unsigned long *)((unsigned long)task->stack + THREAD_SIZE) - 1; -- 2.39.2