Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9954a532-871a-e747-908f-bc5a3e32a55f@gmail.com>
Date:   Wed, 12 Apr 2023 10:52:50 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] scripts/gdb: use mem instead of core_layout to get the
 module address
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, jan.kiszka@siemens.com,
        kbingham@kernel.org
Cc:     gost.dev@samsung.com, linux-kernel@vger.kernel.org,
        song@kernel.org, mcgrof@kernel.org
References: <20230412111508.892296-1-p.raghav@samsung.com>
 <CGME20230412112608eucas1p2e8aa819cf92ccc2bacfe0ff9bfcd7a6f@eucas1p2.samsung.com>
 <ffc82a81-c212-7990-53fb-2f95eb7af2ad@samsung.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <ffc82a81-c212-7990-53fb-2f95eb7af2ad@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/12/23 04:26, Pankaj Raghav wrote:
> On 2023-04-12 13:15, Pankaj Raghav wrote:
>> commit ac3b43283923 ("module: replace module_layout with module_memory")
>> changed the struct module data structure from module_layout to
>> module_memory. The core_layout member which is used while loading
>> modules are not available anymore leading to the following error while
>> running gdb:
>>
>> (gdb) lx-symbols
>> loading vmlinux
>> Python Exception <class 'gdb.error'>: There is no member named core_layout.
>> Error occurred in Python: There is no member named core_layout.
>>
>> Replace core_layout with its new counterpart mem[MOD_TEXT].
>>
>> Fixes: ac3b43283923 ("module: replace module_layout with module_memory")
>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>> ---
> 
> I had one question:
> - Is there a way to import enum? I currently hard code 0 but it will better if we can
> use the MOD_TEXT enum instead.

You should be able to with updating constants.py.in and using LX_GDBPARSED()
-- 
Florian