Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1343292rwl; Wed, 12 Apr 2023 11:20:09 -0700 (PDT) X-Google-Smtp-Source: AKy350biWsPW9xOmgkNuoeSKjh8Lzf0aS9rOKZ5p45J6WnoirVdKXU5j6pZ0Gdfn56sjo6WbNacx X-Received: by 2002:a17:903:2444:b0:1a1:aa68:7e61 with SMTP id l4-20020a170903244400b001a1aa687e61mr816pls.33.1681323609108; Wed, 12 Apr 2023 11:20:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681323609; cv=none; d=google.com; s=arc-20160816; b=1DhBmCzlzmbK2olpovyU7CdbLeiSbZPLPwNlKXtem9gN5hcSOyFFq49dqmd5CNdBNh 8HEDqyoL3Go6E0g+7RT65Wa9doI7sWXFXr+2IGUWi9uTaEFwlSJGtNsbRzvvZYHz33Y7 NwYLsODGYlvIhBzjbuyEun/lIapLGLjaAaGUUwcKLK+p6AlQjQHBhdZFqQXe3zdrmkJj OcU5Ss8dHUb3z5taJ/PHIGGxntFJNoNPk0XED88k5jVsTybU8O4qHGvd9AnV4SjMBmnm gr3Wj67Zukdo9Kr9Cemz1icZK5Mcv8/VEMOidLTq/q8MluN3ADMfXTmJDcqnmS/z22gx dJTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:importance:content-transfer-encoding :mime-version:user-agent:cc:to:from:subject:date:references :in-reply-to:message-id:dkim-signature; bh=bbtx7YM00UXAS7Akot4n34YD+A+SC5hXFf03L0M2/v8=; b=Eh/dZZoRTdqk3XyjUbYbFinfyy8/Ex0aREDecLeZMxHP/TcXLbu3xIfhlW78hT87Tf dsjrHmzMJONeFqkiM947jHjJ+8r0COFxE100Ndoun4gNU10TSrXeP4+qwgILLm9jFbpP IR6ShUGb9hHIFR9PkBxCfyf8D5yiagA9EuM/t4ToTnFg3gySKTnWURuJyf9UDIjBcq/G YXy1dUA06Y4s4dk3YfqHCPfc7pa9Q+zW0DwnuyJmEVrQhIJ/OrnwOSASXp6V6kkrGiRI vvkk8QNYxzgV9M5PZ4r93sA/2hAQ5DNApZGpFaDEYBSqUxojzA3icoAgPjahZNNOSVi6 8C5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=Ev4IV7ka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=panix.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s19-20020a632c13000000b00502f4be647fsi1356016pgs.641.2023.04.12.11.19.55; Wed, 12 Apr 2023 11:20:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=Ev4IV7ka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=panix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbjDLSMw (ORCPT + 99 others); Wed, 12 Apr 2023 14:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjDLSMv (ORCPT ); Wed, 12 Apr 2023 14:12:51 -0400 Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D639B211F for ; Wed, 12 Apr 2023 11:12:48 -0700 (PDT) Received: from mail.panix.com (localhost [127.0.0.1]) by mailbackend.panix.com (Postfix) with ESMTPA id 4PxW5q4BRMz47j8; Wed, 12 Apr 2023 14:12:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1681323167; bh=DvXrenb9Kgk8Kq1FPp3NAzT+K5TJB88dBKyeYXg0qUE=; h=In-Reply-To:References:Date:Subject:From:To:Cc; b=Ev4IV7kaTaSnTFw5fwQIMzThRKaAuB3VYooO0MwC9OxuawXKoaJywqR7JYgIrZW5S JY0RWMxMiMz5J32Mkp9KkxH32QjDocoLh3g1vXldMTCXnS/QiahFpWoYCo7rD96sSE +bLeaEp2FQz22WestWfImV7vx2o8YLRsfg0susfM= X-Panix-Received: from 166.84.1.2 (SquirrelMail authenticated user pa@panix.com) by mail.panix.com with HTTP; Wed, 12 Apr 2023 14:12:47 -0400 Message-ID: In-Reply-To: <87jzyhror0.fsf@minerva.mail-host-address-is-not-set> References: <20230412150225.3757223-1-javierm@redhat.com> <2e07f818ccdff7023a060e732d7c4ef6.squirrel@mail.panix.com> <87jzyhror0.fsf@minerva.mail-host-address-is-not-set> Date: Wed, 12 Apr 2023 14:12:47 -0400 Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated From: "Pierre Asselin" To: "Javier Martinez Canillas" Cc: "Pierre Asselin" , "Jocelyn Falempe" , "Daniel Vetter" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Hans de Goede" , "Thomas Zimmermann" , "Ard Biesheuvel" User-Agent: SquirrelMail/1.4.23-p1 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Interesting. So you don't have the simplefb output that you had before ? I do now, after a 'make clean' and "make bzImage'. In between, I had tried CONFIG_SYSFB_SIMPLEFB=n . That "works", by falling back to vesafb in every case. I restored the .config before testing the patch, but there must have been leftover dregs in the build tree. 1024x768x32 is garbled, others are good whether simplefb or vesafb. --PA