Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412150225.3757223-1-javierm@redhat.com> <2e07f818ccdff7023a060e732d7c4ef6.squirrel@mail.panix.com>
 <87jzyhror0.fsf@minerva.mail-host-address-is-not-set> <beeff0335ab4cc244d214a7baadba371.squirrel@mail.panix.com>
In-Reply-To: <beeff0335ab4cc244d214a7baadba371.squirrel@mail.panix.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
Date:   Wed, 12 Apr 2023 20:24:27 +0200
Message-ID: <CAFOAJEdKBUg91pDmNYYw5xigUxjifBgOLz2YgD+xQ+WyEy=V2w@mail.gmail.com>
Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated
To:     Pierre Asselin <pa@panix.com>
Cc:     Jocelyn Falempe <jfalempe@redhat.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Hans de Goede <hdegoede@redhat.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 8:12=E2=80=AFPM Pierre Asselin <pa@panix.com> wrote=
:
>
>
> > Interesting. So you don't have the simplefb output that you had before =
?
>
> I do now, after a 'make clean' and "make bzImage'.
>
> In between, I had tried CONFIG_SYSFB_SIMPLEFB=3Dn .  That "works", by
> falling back to vesafb in every case.  I restored the .config before
> testing the patch, but there must have been leftover dregs in the
> build tree.  1024x768x32 is garbled, others are good whether simplefb

And can you share the "linelength=3D" print out from simplefb ?

--=20
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat