Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1364324rwl; Wed, 12 Apr 2023 11:37:48 -0700 (PDT) X-Google-Smtp-Source: AKy350YoY+4CU8/66NBT07WktjAiwATFAbKxDtdjmHU0Q1Xn0/9ebqJmcuZ6qOncE2ee4/Tg7TOW X-Received: by 2002:a17:90a:440d:b0:23d:41:3582 with SMTP id s13-20020a17090a440d00b0023d00413582mr10417318pjg.8.1681324667656; Wed, 12 Apr 2023 11:37:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681324667; cv=none; d=google.com; s=arc-20160816; b=Cfar27OY9ACqeq7OFIRNyTRxLLAhl3TlsUmoWCHOK7BnI6sz0pn1YhqbU1hENDqDZH 4UB/D7HBOhr42dYTG2H93p56c201L9dT5eBeOgxwXUBhmMKXiXHaqTVI66T/rDZa7+cQ ROiiVvKnWTb28TAnMAof1nSPkoZ0pqVJwsn0OxoDKEuaRMQUPq201+1LdTedrFgVfO72 y4TcWSdQeLkIrBy5sGLQrA3ua/mAC698J8MAouWDuQoL3zprk6FIEqtvdCLTU4Kp6WWK Xd4JcWO3fREDyW0V3fmnewmR7tzx0VXbohNpW1+PY/LCZrHYP66dtZO/1U+fQgvtHrEJ Tnsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=nASbvUSnsaeFCXOfTkcdVrQuPHnFeQGcQeYLYHUVI1w=; b=S5wtHTkM6JQ9ZTNTv0OgrWDM86pq6PTwuoceu1qNbPKTCeJTjVu2jvR/4OsW3Crc2W toOvY2OkeNFFYOaTq52NSV1eZLGKIlwj10rUEqqdMFin3Z2NREG3uxFdM17JfwTIM4GQ 9IE0OWT5mSXxG6JAtt9xy32p1XRieV21Lvq+dSHGS5buJ1po+hCXYvjigCFEFVI4LiXo pf43dlK4OxCGAjjgKRR08b9TJu4victr8M5uWdzwfip13eErBVLgulUI/rvikIrEqsA1 XyAnO/w2RwAqkYGThbwAe89HMpoJn20fN4+2oV10neEGIGqD6+YYBe4i24iCn7cy4K79 Hdzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T5zyYeB4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a17090adb9000b00233d1081c5fsi2550309pjv.52.2023.04.12.11.37.35; Wed, 12 Apr 2023 11:37:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T5zyYeB4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbjDLSgC (ORCPT + 99 others); Wed, 12 Apr 2023 14:36:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjDLSgA (ORCPT ); Wed, 12 Apr 2023 14:36:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42AE2683 for ; Wed, 12 Apr 2023 11:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681324519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nASbvUSnsaeFCXOfTkcdVrQuPHnFeQGcQeYLYHUVI1w=; b=T5zyYeB4dDBPIHj0+e8J7i1ZjgBF4NM9LZpaG/kg0lr3A3jQ0b8zVMnu+JlUOiEPno/jmg w33RE43+9hYVnClDBllmrKqz4t3vvGcwnIogzWAkuOPLDwWZgqC1WeYuXhA4DibZAm/UiA TAbXaTuGVLWX1wo/X9WDIFawV0XcIIg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-IOXeVZDPPWOzW5WkMenixQ-1; Wed, 12 Apr 2023 14:35:15 -0400 X-MC-Unique: IOXeVZDPPWOzW5WkMenixQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D9F029AA3AC; Wed, 12 Apr 2023 18:35:13 +0000 (UTC) Received: from firesoul.localdomain (unknown [10.45.242.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B43F2166B26; Wed, 12 Apr 2023 18:35:13 +0000 (UTC) Received: from [10.1.1.1] (localhost [IPv6:::1]) by firesoul.localdomain (Postfix) with ESMTP id 0CE2D307372E8; Wed, 12 Apr 2023 20:35:12 +0200 (CEST) Subject: [PATCH bpf V9 0/6] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash From: Jesper Dangaard Brouer To: bpf@vger.kernel.org, Stanislav Fomichev , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net, tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org Date: Wed, 12 Apr 2023 20:35:11 +0200 Message-ID: <168132448251.317773.2526885806604122764.stgit@firesoul> User-Agent: StGit/1.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value, but doesn't provide information on the RSS hash type (part of 6.3-rc). This patchset proposal is to change the function call signature via adding a pointer value argument for providing the RSS hash type. Patchset also removes all bpf_printk's from xdp_hw_metadata program that we expect driver developers to use. Instead counters are introduced for relaying e.g. skip and fail info. --- Jesper Dangaard Brouer (6): selftests/bpf: xdp_hw_metadata remove bpf_printk and add counters xdp: rss hash types representation mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type veth: bpf_xdp_metadata_rx_hash add xdp rss hash type mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +- .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++- drivers/net/veth.c | 10 ++- include/linux/mlx5/device.h | 14 ++++- include/linux/netdevice.h | 3 +- include/net/xdp.h | 47 ++++++++++++++ net/core/xdp.c | 10 ++- .../selftests/bpf/prog_tests/xdp_metadata.c | 2 + .../selftests/bpf/progs/xdp_hw_metadata.c | 42 +++++++------ .../selftests/bpf/progs/xdp_metadata.c | 6 +- .../selftests/bpf/progs/xdp_metadata2.c | 7 ++- tools/testing/selftests/bpf/xdp_hw_metadata.c | 10 ++- tools/testing/selftests/bpf/xdp_metadata.h | 4 ++ 14 files changed, 205 insertions(+), 38 deletions(-) --