Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412025737.20280-1-mibodhi@gmail.com> <20230412025737.20280-3-mibodhi@gmail.com>
 <eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch>
In-Reply-To: <eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch>
From:   Tony Dinh <mibodhi@gmail.com>
Date:   Wed, 12 Apr 2023 11:50:47 -0700
Message-ID: <CAJaLiFw00VyD4rPBh=06U6wXmbDaK75Cd9MCVwUCN1SF4A1_Xw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Arnd Bergmann <arnd@arndb.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Olof Johansson <olof@lixom.net>,
        Rob Herring <robh+dt@kernel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-kernel@vger.kernel.org, soc@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andrew,

On Wed, Apr 12, 2023 at 5:24=E2=80=AFAM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +
> > +/ {
> > +     model =3D "Thecus N2350";
> > +     compatible =3D "marvell,armada385";
>
> If you look at all the other armarda-385 .dts files, they all have a
> board compatible. It might not be needed now, but it could be useful
> in the future and allow backwards compatibility.
>
> > +&mdio {
> > +     phy0: ethernet-phy@0 {
> > +             reg =3D <1>;
> > +     };
> > +};
>
> Since you have ref =3D <1>, this should be ethernet-phy@1.
>

Thanks! somehow I kept missing that change.

All the best,
Tony