Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412025737.20280-1-mibodhi@gmail.com> <20230412025737.20280-2-mibodhi@gmail.com>
 <168130276446.1439316.3427548118074442016.robh@kernel.org>
In-Reply-To: <168130276446.1439316.3427548118074442016.robh@kernel.org>
From:   Tony Dinh <mibodhi@gmail.com>
Date:   Wed, 12 Apr 2023 12:05:39 -0700
Message-ID: <CAJaLiFxNbz+EygSy8OMKafZ667ingeiTw8Z17p3dwtPTpiH40g@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for
 Marvell Armada 38x
To:     Rob Herring <robh@kernel.org>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob,
Hi Krzysztof,

On Wed, Apr 12, 2023 at 5:36=E2=80=AFAM Rob Herring <robh@kernel.org> wrote=
:
>
>
> On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote:
> > Add device tree binding for Marvell Armada 38x.
> >
> > Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> > ---
> >
> > Changes in v2:
> > - Add marvell,38x.yaml. For now, add this binding to the Marvell
> > directory to keep it consistent with other Marvell yaml files.
> > At a later date and a separate patch, consolidate the Marvell
> > yaml files into  marvell.yaml.
> >
> >  .../bindings/arm/marvell/armada-38x.yaml      | 27 +++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/arm/marvell/armad=
a-38x.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: rel=
ative path/filename doesn't match actual path or filename
>         expected: http://devicetree.org/schemas/arm/marvell/armada-38x.ya=
ml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202304=
12025737.20280-2-mibodhi@gmail.com
>
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your sch=
ema.
>

Thanks for the reviews. After running make dt_binding_check for it
seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and
used
make CHECK_DTBS=3Dy armada-385-thecus-n2350.dtb

I'll move this to another faster box and run make dt_binding_check.

All the best,
Tony