Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754861AbXIZIbh (ORCPT ); Wed, 26 Sep 2007 04:31:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752326AbXIZIb1 (ORCPT ); Wed, 26 Sep 2007 04:31:27 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:53592 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1749667AbXIZIb0 (ORCPT ); Wed, 26 Sep 2007 04:31:26 -0400 Date: Wed, 26 Sep 2007 09:31:21 +0100 From: Christoph Hellwig To: Erez Zadok Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org Subject: Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting Message-ID: <20070926083121.GA8421@infradead.org> Mail-Followup-To: Christoph Hellwig , Erez Zadok , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk References: <11907762042481-git-send-email-ezk@cs.sunysb.edu> <1190776207595-git-send-email-ezk@cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1190776207595-git-send-email-ezk@cs.sunysb.edu> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 12 On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote: > Fixes bugs in number promotion/demotion computation, as per > It's better to use te page_offset helper as that avoids any confusion on where to cast. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/