Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1494671rwl; Wed, 12 Apr 2023 13:55:15 -0700 (PDT) X-Google-Smtp-Source: AKy350adEUjL5kRikmsirCJ+Z+I1DS2bDUQAjza9hHjiGzryfZY7euBNyycQOMt9oy9wqdm1nQ7J X-Received: by 2002:a05:6a20:671d:b0:ea:fd64:6a60 with SMTP id q29-20020a056a20671d00b000eafd646a60mr7104179pzh.57.1681332915488; Wed, 12 Apr 2023 13:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681332915; cv=none; d=google.com; s=arc-20160816; b=ogUQWuYU298Cgyj3OgSQBkRsSUFQaIXbdW8gu10gKSIpQlXJBaoYzn/ujFQeF/YHP1 GlGBmL8D73ihGfHkhhjKUiCM9qzUCtooND3atiRpFvKely6tTMvLOylSIfLnwZqZAxd/ M+N2P5ldNCYXOShvFzEbcI6BPbOqJxebCKPU1GaUa+CfGqZpzuUwRGcmnCIGsdJIu+3T 90Do0x5ldSF8IYGTsDeTiA3g2xawXiSphJjvXW1aeBtgkixMwPwaryhKBTL+9KxfBp+R EukhxIAj/HEXH1lJUPL5xvG1Y4Cy9CAkC4gniMTZLpNidvFpQ75KqPqBPNUTmeJpEfDT Ie5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1HWrQjH/0R7gJB/BiP8Byw9Dy8Qj5kkAtvdSXYIJpXU=; b=RgqaGlCnNAl2D7RJ2pEF94pHynij15tgrfE3n5Jkfa2BvQaCETWj0wF5vdWpJ9gJrb DZeY+zDwlY8eKr3vrqJBvBXgSLggGc54vh4rCnvQlTRXVsy/aZQ4wH50+IbYierwTpEV liLv7aXSEOPhswX+fcQgNvj1i3X2SmW6NldXvABuMcRXgZomlggx2RXh0N/oInB2h7E5 nynf12Dh7c1OR06u1dmX9VDVWpjPTQmG3bZBF9RPD2DvRD0KC58BRAzutOHKEt90oGVJ Y6NaXkiOK8n4RMXAHA4zjEM9fngmvkNkvCi2375t8fSypzIM+tO6f2tEC9gbqrYqE429 Iang== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VDKWuY8v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a63570b000000b00507681e1281si50443pgb.525.2023.04.12.13.55.03; Wed, 12 Apr 2023 13:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VDKWuY8v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbjDLUoK (ORCPT + 99 others); Wed, 12 Apr 2023 16:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjDLUoJ (ORCPT ); Wed, 12 Apr 2023 16:44:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5987E4EC5; Wed, 12 Apr 2023 13:44:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E89AD622CC; Wed, 12 Apr 2023 20:44:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06C8BC433EF; Wed, 12 Apr 2023 20:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681332247; bh=aoAHy7DEiYr/xln2kAunwsb8zReQcW/Oo/qN/Fl7/8k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VDKWuY8vNj6YxhcCZ+ic86Utd60bh/CErc5li9e+X7YBlPXuQHxBoOIAX9RBDBL6u qSJoAisF4GNfADV3HeQznFPynj3k8PoLmxZb4mvepSgi52FtL6x0yFYiOBNfVQlRwE 5awcIAvR64OUZP2q6prjoJZvh+BOg/YFkeuPqJMMlewGLEHf6nwKjUwFNuFhJxWM14 o+XlU7sxPeRxGpuAKmxX/IycKhfxqmfNficR3WZpSR6+1sop50DL/gyoidBjwMxpEP oQngrjxAkCUV46Hx5oiWm7EK8FvKl1gakHTBxpIh/wC3ydVliozftnvDfBoqu44HkM DtVzz6YWRI19Q== Date: Wed, 12 Apr 2023 21:44:03 +0100 From: Jonathan Cameron To: Subhajit Ghosh Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Shreeya Patel , Paul Gazzillo , Zhigang Shi , Dmitry Osipenko Subject: Re: [RFC PATCH 0/2] Support for Avago APDS9306 Ambient Light Sensor Message-ID: <20230412214403.5c053ed6@jic23-huawei> In-Reply-To: References: <20230411011203.5013-1-subhajit.ghosh@tweaklogic.com> <20230411144031.000077c7@Huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Apr 2023 12:46:49 +0800 Subhajit Ghosh wrote: > Hi Jonathan, > Thank you for getting back. > > > Hi Subhajit, > > > > No need to sign off a cover letter. The content isn't captured in the > > git tree anyway. > > > > For an RFC, I'd expect to see a clear statement in the cover letter of > > why it is an RFC rather than a formal patch submission. What specifically > > are you looking for comments on? > > > > Point us in the right direction and we might answer the questions quicker. > > > > Thanks, > > > > Jonathan > Thank you for clearing it up. > Next version of RFC I will put specific reasons. > Before submitting a formal patch I wanted to check if my implementation of > single reads of ALS data raw values from userspace when interrupts are > enabled is the right thing to do or not. Also wanted to check if my event > related userspace ABI implementation is in line with IIO subsystem. > I will put it into better words in the next cover letter. > > Can you also help me out with the git tree I should use to format the > patches? As per my understanding it is the subsystem maintainer tree > and the main branch but the macros and functions which you have suggested > in other reviews are available in Linux mainline. For a new driver it rarely matters and I'd advise simply using https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git which is the mainline tree. Please base either on the previous release (currently 6.2) or rc1 of the current release (v6.3-rc1) if doing this. If you need a feature that has only been applied in the same cycle, or are building on recent work that has been applied to the iio tree then for fixes you want: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git fixes-togreg for new stuff you want: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg The IIO tree routes through Greg KH's char-misc tree so will see the togreg branch move forwards to be based on that as Greg takes pull requests from me. Usually this happens once or twice a kernel cycle. Don't worry too much about this. If it should affect a patch because some changes crossed I'll generally fix it up whilst applying whichever gets applied second and ask the authors to check I didn't make a mistake. Joanthan > > Regards, > Subhajit Ghosh >