Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <369a47f7-8194-73bc-34a4-687f2e554438@intel.com>
Date:   Wed, 12 Apr 2023 14:11:26 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 1/8] net: mscc: ocelot: strengthen type of "u32
 reg" in I/O accessors
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-2-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1hWWXNIK3BqVERGOWhYajJhc1ZQb3J2NXQwYTJySGpnTVROem1HbUtGWitV?=
 =?utf-8?B?YVc4cE8rQzk5K0FWREN1SG9wY3BHQjFRQ09wVllkMHh3eG1YeVFvbmpCcDI5?=
 =?utf-8?B?c2hxSUZuQjFVUlhyS3MrMHQ4am5LTk8xd3NXeDdQN0dnNzByTWFjYmJKVTAv?=
 =?utf-8?B?TDNFdCszSFYvblgyVnYwZmNtcTI4bHZyaXJTeEZwdGdyZlRrVnJlaWNJN3Jq?=
 =?utf-8?B?RFNEa0JESGs1b25UZTFtMjlhd0Z2T0lTT0FGcCtJZlBPVGl4aXZFejFTQmJv?=
 =?utf-8?B?b0Y2dXVGT0Z0enZnNmNFZU1ycmRxZjg1OEFyVHRFa0ROaFB2WkxVRjJZbUYy?=
 =?utf-8?B?YjJNcWNadmlETVRuUmhDRDlRYjdGdi9YakR3T2xydGdNZlFpK1lnK3RCSEVz?=
 =?utf-8?B?MFlBNXkwOGZKUUp2Vy9yaDZ0dHRzTVBrdnZ4VFNKMnA0NE9hMENHdWRCUGkz?=
 =?utf-8?B?QjExS0lpbzVTS29pSGxjU2FncHB5Q2tLTTNOanM5UzVBWjdnVG5PME51YUZz?=
 =?utf-8?B?OXJGWDRqQ01HN1ZvbGV2YTRYZTBKdC95MUxNbFhSdWZha29qMHhxNkJuMTlx?=
 =?utf-8?B?azFlWjdybHA0aWc3Q2VOaDdqTnRIMkJCdzk5RTRBdHlHM3hLVXhPd2xDVThV?=
 =?utf-8?B?OTVQdWE2VGJ6cXFuS1p5blB4a00rZXg4NWRxL1I2b0NCRUU3QXZ5Rkw1cHlQ?=
 =?utf-8?B?NHJaV2VqMlhBYWhNTkZZQkdVeVpyQlQ0bjlMczZLckpiOTVFN2dZQUYyaHlY?=
 =?utf-8?B?aVlMWUtlMmFaVnRkU0NKSURibTlUMVNWMlp6M0wvdWFhYjhndmJhWXR6WEo0?=
 =?utf-8?B?MmFOUlJqK1E2cHc0V1J1akwvSkZYaWEySGRVZGVRSU5sc1ZpODd1bnl1WVRV?=
 =?utf-8?B?dG1ISmVLUHlvZUY5UGlxd01DWnFkZmZwQ1diejRpM3lEMkN1a1NJQzJpdkg5?=
 =?utf-8?B?MXJJRUhDSVNxT2NWVnNwVDl0bDRYSEhOLzFycU9CbEE0VGNMOXZLZDE5T3pM?=
 =?utf-8?B?RmdxMUZ0WkJuaXNnZERxdHdWdXFqazViZ1VsS1BoQUQ4SVVWODFYeDNiY2l6?=
 =?utf-8?B?K0VNTFdXRld2ZTJZaHFQc2k2OUtXU0c0bElVNjVMaU5lMDByeXNlOW9sWXlV?=
 =?utf-8?B?MU5YNlJVUGVkVFd6U1NUVjdYamJUVDUzWGJPUHRNdmxkdzZwMHVkNGZndVNv?=
 =?utf-8?B?Z29yU2NGWU5Dd0JaeXYreW10N2pBOEc5SjJhRXZDM1BBOTdtM3RyREVqWlNr?=
 =?utf-8?B?aHJLQXVQeiswcDdIUUd2VEdUMTVuMEhYL0VGdEh5VXA3blhvbVhtK0drY3k1?=
 =?utf-8?B?YVUzUGQyeDBycFRkMitmNHJMcXMvcU9RYmpuZkp1U1JkK1pJbWZVZDcrWXM1?=
 =?utf-8?B?dGsvKzBlUE9YQ1NsRmU1MVEzODNua09QWU8zTjd2ZmNHSXR5Mk0vOWFvMnpS?=
 =?utf-8?B?NUJsdWpxNEhNak5BU3VJSGxyRk1lODBGaWdUdUc2ZzIrdTQyYStveHByRm5H?=
 =?utf-8?B?cE9sdEJLQ2w4NWl5TU90bEpwU2FQSjZhVVkrb0pmTlNEL0t0YzVvVE1Kanp5?=
 =?utf-8?B?VHoySk5UNG1MTnRxbXpmT25wMXJENFljSzRtbGxyZ0ZlWDVLeDRGeFBCSWsz?=
 =?utf-8?B?RE54QURtQkpYeExmK3RZMUhMck9sNkozQlVDMDFwUi9KT2hjM3ZMbk1YTEtP?=
 =?utf-8?B?YlRjWE5hbTZDM2VDakpoeEpxZzd0SVJMWEFxZVc5WkcxUnFSdmNGZXVhR3lE?=
 =?utf-8?B?RE5NWnptMkdBbm9tdEo0bUZzRW81eEtubVIzcVZlS3hPc1N6dGdXUVpzYytM?=
 =?utf-8?B?bmR0dDhBV1RGWUg5YlljMVJzcDdFOEtYOXZnVnh6TTQ2TlBuaEZ2RzBOWFFY?=
 =?utf-8?B?by9OaG1XblR4c012QmNucVFSbnJoTWdqZDd0dFQ5djhBL21iNy9xNkJQQjJR?=
 =?utf-8?B?c2dqMVVDMGVLNmRXQXBDTlphclZQRHFDRmZsVzRpeGVSdENQODZqK1VsZ3V2?=
 =?utf-8?B?S2lxM1FSR21xdzhyUHEvQ1plcXhPaGp6UEtRTmFVdGVMVS9ERndWZ0ZDU21P?=
 =?utf-8?B?RGFGRGtZV2tFVTh0RDdWTWJwUys0OEdiMGkxTjFiMVlPUnNQaDN4dklocXNQ?=
 =?utf-8?B?SFI1bkptczlHaXhUSk1KZ1lwdUdYWTAveUo4S3dFK1dNY0FkangwOWdicW5O?=
 =?utf-8?B?UFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df6270ba-46e0-4bf0-2441-08db3b9a76db
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:11:21.0371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ufcfknox1ieQyFdLP7Dz5aqTnKQ/KAGvQ5r5j+Ma2gZ0+jeoCwyXoRFriKmO238tPPLQfkJuL5+gIpIZfFh0kbJ449mu8wYOTwahbDUCoaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7754
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> The "u32 reg" argument that is passed to these functions is not a plain
> address, but rather a driver-specific encoding of another enum
> ocelot_target target in the upper bits, and an index into the
> u32 ocelot->map[target][] array in the lower bits. That encoded value
> takes the type "enum ocelot_reg" and is what is passed to these I/O
> functions, so let's actually use that to prevent type confusion.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

It  does make the prototypes a bit longer, but clarity of the type of
value you need to pass is good.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>