Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e7edc87b-3c1b-1b10-9c4f-0a7b114dd2fe@intel.com>
Date:   Wed, 12 Apr 2023 14:16:19 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 2/8] net: mscc: ocelot: refactor enum ocelot_reg
 decoding to helper
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-3-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-3-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW9HZVoyYTlDdjFMVHN2cXVTQVcwNmZmYWU1NVZOSk5Ta2g0b2ZIamFGb3Jk?=
 =?utf-8?B?VTNCaDhBWkd3YkZqRFVUV1U5aUk1WW4rRGg1Q1kwQi9iZklOVnBQUTBnSW5X?=
 =?utf-8?B?anhFczEvU3pwNjBCMmFHSjBkM1hiT2ZTSHZlYk0yNVAwVFlUSENjaFVYdG5t?=
 =?utf-8?B?UFdRZzEwNWErQlZqRTJXaTZKZFNWZmNqRWIwQURGRzJvcm1VWjg2WHNhUGM2?=
 =?utf-8?B?UW5FL1I4Q3BwUEhna2hJeC83b3BsNmw3UWRSNS9mM3JKeWRpaFlVODZEdUQ0?=
 =?utf-8?B?dlpNbkVwaEkyQU94VGkwdGlEelZCZDRSUnEvanhoRmd1MkVMM1ZrOGVPWTZD?=
 =?utf-8?B?TklBb1FpMXNWY2FTbnBzZ3kxTFdFdXllQjl3WjRGSkRsZWNvZ01jN2xiQUFI?=
 =?utf-8?B?Z0Z2UUhUMHEycnFXQmIyN1pQQUorMWQ3UHpralBwYnhqZkF5U0V1L1NtS2NF?=
 =?utf-8?B?U1ZXM1F5cDhsNkJWZHBjVFNxMFZ2azZxUTdmOFUxS051NzB2dGRSbXlMbjdu?=
 =?utf-8?B?QWVuNG4xbHJSUlU3WWVGT0N0VjA3bTRBdUZBaHljN254ZC9VVVduaTZMakpM?=
 =?utf-8?B?c01TSW85OER2SnRpcVEveExKREFIZjVpVURkUCs3M0NUSUdhWVlqRDJ3TzRZ?=
 =?utf-8?B?MkJGSGdQUk9VTkVXT3NUR0tRclRodjVNdzRBN1Z2UytPMXViNVN2RGxaZzVp?=
 =?utf-8?B?dkxld1Q5UVdmMmsycmlGeE1xNUNTZmtlR0k0RjJEMjlwM1NzRGY2bHBBMGxW?=
 =?utf-8?B?d1lYSFRxTDV4WCt3cUhVb05UQnlUZ2tGOWtSTEZLRkFEaCs0R2FiSksvVGFU?=
 =?utf-8?B?OEVrb0pBMGpuck9YbFVvcnV0YjNNNExvQmgvK0w3MzUrYXNmVE5FTXBEaTVL?=
 =?utf-8?B?YWhydjdLbk5CcXNwN29RaTR2MVZ1eVFlQ291NXRRbWw3TmhnOGE3YnNKclIx?=
 =?utf-8?B?VU96M05pNHYwRG1ORllNNE42YmZEemMxdnBJbUp3OFJxYTJ3S3JUNGgrdmU2?=
 =?utf-8?B?eE5TMytKN3ZvZC9UL0hsbnZSSnJhcS9zU3NFdi9OVGUwTXI5ME1HeGcrUmZW?=
 =?utf-8?B?WjJ1TjhDektYdEpnd0ZGdklucVZGWnlLbHV3SmVBR2dkdDVoZ3FuaUVRaVBj?=
 =?utf-8?B?a1pYK0FYcmtlT29UcmJERTlaUENxeWFPQzhUbTZoNlJ0VVFaUDFrZWRkUVVp?=
 =?utf-8?B?aXBsZ1NJNzJIdVRvbmhrem9tZktjRGF1L1JicEJzUVV3bXdJdVdIc2VuYkwy?=
 =?utf-8?B?WEIyMnJOa2J0UHNyODdnb1NOWmNBUWlxUFpwZVFxZDliSzZUNnpySk1GTWpV?=
 =?utf-8?B?TTBYNmE0VmUwV1FZSTdYMGNISkliODU5VHNoRUF6UjZkZFJJWlB4ZUc0OTh5?=
 =?utf-8?B?WXJLR2hLdklYMUFsa29Pd3R2eDd1eWhib3FLU01BRzZ0NTVGVnI4ZXhuQ0E0?=
 =?utf-8?B?bUhVYTVKUEo4T3BJUlI4dXJySnppMExtR1NLYVk1c3VBR0hjVTBacW1JU1kw?=
 =?utf-8?B?YTArOWhjTTg3cVdrOGFqTFdldVRZWWVHV0cvK2RJTytVN1ZZMFhwNmJ3Y0li?=
 =?utf-8?B?N2dwQ3dmUU15KzdGZ2xVcVRJZkw1TWNxUGQ0Y2NJZG9BV1ZXRGkrWEtHR21m?=
 =?utf-8?B?Z0hWRGRWUTlwMUp3NU5OYkZxNGxXazZPbDhEOXV2TzdiRUNockJpTkY0a256?=
 =?utf-8?B?VjNBOHRMaHdNeVdtNGJCR0w5Z1hhSFlsamdDU3V4dndMRkY2UWdEUzJrYlM0?=
 =?utf-8?B?Z3Q5c3c2WS9lanVUeTBKaU9oN1N5b3JIbzM0VE9PU1Q4U3ZoVGZ6cUx3QkRG?=
 =?utf-8?B?Rm5kSnVjNXpTd2RKb2hHRWt1RDdSSzlWemNZeUFtYTJRdGRXcDN6VGc4aWZQ?=
 =?utf-8?B?RzdudmNpeGJvZlZkVC9NVVZnR0NMQWNKR0RJU3ZuUjhoWll5ck51UU1UanI1?=
 =?utf-8?B?WXBEeEM5dVdERmpEYVZHdWpxQjV6am9KcitlOFRDYWkwMTY4VXBmSGkxS00y?=
 =?utf-8?B?RHQ1QVdHRVJPc2lxQUpMSWJXcUhTZWxHZjRDaDJuOXNRenA5MDdnV3BtT3NU?=
 =?utf-8?B?ZXNRMVpHZDhuRllubU1DUmhFVmZocnA3TDI3U2hkcmhNN3Z5Sm5ORGRLT3NZ?=
 =?utf-8?B?M2RRSFlWTUhZWC9NS1RaakF4a0dodXZlbk5DalQwcFNIK2tPYzVNOW9rL0lE?=
 =?utf-8?B?bXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac38496f-2d38-4306-9f01-08db3b9b2549
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:16:13.6574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jTZPNx9+WUXJAFa8JPf2OEn+Hhi1ktod6z/WyZgqs+b7XOZ4rF/VsUf20Yh7F+LTfckVguAKWmxT1rh/6xpphUYBnyWZKDs8NpkRZF6jJ2Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7647
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> ocelot_io.c duplicates the decoding of an enum ocelot_reg (which holds
> an enum ocelot_target in the upper bits and an index into a regmap array
> in the lower bits) 4 times.
> 
> We'd like to reuse that logic once more, from ocelot.c. In order to do
> that, let's consolidate the existing 4 instances into a header
> accessible both by ocelot.c as well as by ocelot_io.c.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/mscc/ocelot.h    |  9 ++++++++
>  drivers/net/ethernet/mscc/ocelot_io.c | 30 ++++++++++++++-------------
>  2 files changed, 25 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot.h b/drivers/net/ethernet/mscc/ocelot.h
> index 9e0f2e4ed556..14440a3b04c3 100644
> --- a/drivers/net/ethernet/mscc/ocelot.h
> +++ b/drivers/net/ethernet/mscc/ocelot.h
> @@ -74,6 +74,15 @@ struct ocelot_multicast {
>  	struct ocelot_pgid *pgid;
>  };
>  
> +static inline void ocelot_reg_to_target_addr(struct ocelot *ocelot,
> +					     enum ocelot_reg reg,
> +					     enum ocelot_target *target,
> +					     u32 *addr)
> +{
> +	*target = reg >> TARGET_OFFSET;
> +	*addr = ocelot->map[*target][reg & REG_MASK];
> +}
> +

Ok this takes a reg and returns it split into target and address, so you
can't just directly return the value.

You could do this with two separate functions, but thats not really any
better. I do wish it was easier to return tuples from a C function, but
alas...

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>