Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b03f43e-3816-8aba-f6a6-3bd2d410726e@intel.com>
Date:   Wed, 12 Apr 2023 14:17:47 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 3/8] net: mscc: ocelot: debugging print for
 statistics regions
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-4-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-4-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azBjTURKRUhTVXNCMEk4ZEVOWmsxb2Frd0ZkU1NkS3FyZnJlN3hWcE5pR2t1?=
 =?utf-8?B?MVBaakx1VVMrVDlScU9JZ08vbFg2MDkwcndwOFowZVZvNGowWWZvbzRHQXpx?=
 =?utf-8?B?TW93YitPeUw0TkVTTWRDbWVtbDRnWFZYUzdpb0tiZE5YcGJCKzF1enFzS1RM?=
 =?utf-8?B?Y3dZeHhETzhHRk9wRDdCM3lRaGN0d0JiaTlnRmdXc1B1ZWV3YlliaUE1K2Fv?=
 =?utf-8?B?WTJRaGV5MVgvaFVVNHJNSTI3OWlZQ1gvekxrd0Mwd1YzT2ROWWxJNUNwT2d0?=
 =?utf-8?B?eGNiSHljRVlRVjZ4Nlo0c3l2WFlIZ3c4T1dReUIxZnZPQmJTYkRYVm5mZzFE?=
 =?utf-8?B?STVHM3ZmN3doZU5mV0JVbk1KdVBXa3dRSW9WNlZEb3QzYkJCcy9WOGJGT0hn?=
 =?utf-8?B?ZHBwVnplcWtDNDhOdjlWSTJkaER4L0lYSlpRQjFSbDNVRWs4SlZFUmNIR0I5?=
 =?utf-8?B?aGRXWXB2eEZqK2czUUJvMHpVTncweXNCWUVQMkZVZzVERmRvZHovZEtrVERI?=
 =?utf-8?B?N1M4RzJVSms1bDFwUWo1cHJEUTN0Nm9rRnZ4VXg0R0tzWGd2dlF4ajZzcjlQ?=
 =?utf-8?B?NWl6b2RoZVRJUTIvN2I1elZTYmhpOEhaSktzbkJXRDVGRHdkRlZSS29YNk1J?=
 =?utf-8?B?ckNTcWUvSHFHMUdQOHlnbGYwRWJXZk5ROW9tWTNnZm52eTVUWVBPY0dFc0RT?=
 =?utf-8?B?cll1UjMyck9HSzY3R0h3OFZsa050Mlh2N0tQcG5ad0cwUmxJcVprQkRTZFZY?=
 =?utf-8?B?dWp6SUl3YW9MclhpMUhPUTQ4NGphai9JWjl5Z3o2WGxlWE1YZVE0Y2VUQjhl?=
 =?utf-8?B?WklweGVvVDVTRldDTUJYT2Nhc2pyT05VNFFBOHJJWGZnMkNXZDl2am5JNlFR?=
 =?utf-8?B?dWJKcmdONHZzSkYyVWZ2VDhBSDdRbVNHRGNUa3BmaU9hY3FlNWdQdHFBMVJq?=
 =?utf-8?B?Umk4M1Vxa2Z4UTZJMmsrSkJOdUw0d0hyRGw4OVV3TENTcEwrMkI4WlB1Nk5L?=
 =?utf-8?B?aFp0WHZ1eUR0eDJkYUFaVm9XQ1ZxdHVKc1p0SzlhM3BPL21xdnREREgzVkVv?=
 =?utf-8?B?Y2kyQnhaMURDZDVtaVhubXd6NmNnQ3RTazZtbmgvSTNOMFFvMW9xSmcvNHJ5?=
 =?utf-8?B?eUZZYjNtLzdyRnRaTTQ4ZkM0NWdvZEdxbE1kMEMzdkovYlJGSmUweGFjcURo?=
 =?utf-8?B?amxiMGU4U013aTB5QlJrZVh2QmpYTXRwNUtNR2dBWjZUZnJIZCtpZHpHQnhY?=
 =?utf-8?B?Wit6K2VnR2o5VnZBUG1EcU1kYzgrMVF6Zkprb3krK0lTb053U3NRNmd5OHZD?=
 =?utf-8?B?b05OcndWSHBnZUFFWVdQK2FRdDEybWNEcWM3S3I2ZUd2WWJJcDl1YW91c1lV?=
 =?utf-8?B?azhpbEFJZ0VIRHk1TFQvWEZ0bmYyL1NrUHFpVEhCUXlwbmRBUzRUbDV2Mmsw?=
 =?utf-8?B?T0tOOTBUVFViVGZHUVlDUTRUR2RLZ1dPV21tamh4bFdFcVc3TTlSSUlabThO?=
 =?utf-8?B?RDlqMUJ1YnhzN3dqOGNmYkVzK1Bqd2pFWldkU2RCRUtBQncxbHQwcnRVSm9W?=
 =?utf-8?B?NmYxaTJwYWVPeHJLZlJSaytQRVQvQ0g2V2hpdGdjQWkyNmlNWXFPWGpRNmZQ?=
 =?utf-8?B?WTkrdDhuS2Y2aFJ5OHJqdUdKZmo4UG84UWF0TVVkRjc3QUV0Sjh5U0svYnBF?=
 =?utf-8?B?Q1VjR2N4ZkplYWxLYndBaEFtMVJidkdFSnMxUFIvTlBWbkc3RkJZT3JpSmJN?=
 =?utf-8?B?aUFUSzBZd3doR3NxNkI0WGNpbmNTK2JQQjJTRG50aWs3aFFjMXlGOWVYakhE?=
 =?utf-8?B?dVdVUzcvMjE0V0c3TmFma25YcU5LTUVORWJaOEpvTDhkd2hQYWxuVEQ4MHRV?=
 =?utf-8?B?Tk8xVEUwaS9adCsvZFVSMTROdkJTckNCYnJabnM0WXlLVHVzQ1llbFYxYmhB?=
 =?utf-8?B?SFBLbzlDTnM1Z29oL3JtdXZMNW94Ym9NRUQ3THFtTVl3eVBTNlIxc2oxUEZv?=
 =?utf-8?B?NVljTUZBSjJPY2lOeFVWMEd2TTVibFozbXdPZ2RiWEFyM0VyaWhkaW9yeDRh?=
 =?utf-8?B?QUlBclN3MUh2eFhocktWNElQQWZFRXNBeUtGOTJkQytSSW9pUHpzekREZkdE?=
 =?utf-8?B?eDQweXZlWkI3WjkwNFIzWWwxRUIrbE1XSlhzYW1VMTFsL3NaOWhTZFNCR0tI?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f4a198e-8458-409d-b0e6-08db3b9b59a7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:17:41.5155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 41D7rSdqGriGBO2szYDH1/h9xxD1+80sU5g2zMAj2j3FftBYbMNsdBhnbpAKn0I/F43lw9GnHNq5LEa2x25gaxhkpFMnVbGLQlS0hNCMWmo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7783
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> To make it easier to debug future issues with statistics counters not
> getting aggregated properly into regions, like what happened in commit
> 6acc72a43eac ("net: mscc: ocelot: fix stats region batching"), add some
> dev_dbg() prints which show the regions that were dynamically
> determined.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_stats.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c
> index d0e6cd8dbe5c..b50d9d9f8023 100644
> --- a/drivers/net/ethernet/mscc/ocelot_stats.c
> +++ b/drivers/net/ethernet/mscc/ocelot_stats.c
> @@ -925,6 +925,15 @@ static int ocelot_prepare_stats_regions(struct ocelot *ocelot)
>  	}
>  
>  	list_for_each_entry(region, &ocelot->stats_regions, node) {
> +		enum ocelot_target target;
> +		u32 addr;
> +
> +		ocelot_reg_to_target_addr(ocelot, region->base, &target,
> +					  &addr);
> +
> +		dev_dbg(ocelot->dev,
> +			"region of %d contiguous counters starting with SYS:STAT:CNT[0x%03x]\n",
> +			region->count, addr / 4);


This will load the target and addr every time even when dev_dbg isn't
activated, but thats not a huge cost.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  		region->buf = devm_kcalloc(ocelot->dev, region->count,
>  					   sizeof(*region->buf), GFP_KERNEL);
>  		if (!region->buf)