Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54a4ad72-dc77-557f-64b6-b33440efb38a@intel.com>
Date:   Wed, 12 Apr 2023 14:18:09 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 4/8] net: mscc: ocelot: remove blank line at the
 end of ocelot_stats.c
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-5-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-5-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SklDaU5MaExEa09zUlJpNXN2T2JwTFRodXFEdk1jS09GNUFIaDV0SkgwUHRE?=
 =?utf-8?B?bTNwdE1aU1VNL0VDZ1JQeDBNM2pWS21nbVFTS2pDdjBLY2JNOE5aWlBmOHRE?=
 =?utf-8?B?eDgvbUJpWU96TDJqckdSWUg2a3drMGRLc0wvdzVya3QwL3c1K0QvMHJ6cUht?=
 =?utf-8?B?dGxmOTdha3pEYWtSbVFSMXAxTzV1Tm96UTkwaVZhNkZLSlBJTGo5b2w1V3FJ?=
 =?utf-8?B?TGN1MEhmNDNMNm1hSmtITWRrczV1TVhpSkQ3cTZIMHZoQjdteXlSNC80TzhI?=
 =?utf-8?B?WXpNbkFtMGYreFkzYkRWYWcwcUpsWEU1QnE5dDJhVUxzanpHTVY0dzFiT2Ev?=
 =?utf-8?B?VUxWUFpTdDhHVHphNkV0RTBRV3hjVXo0WDVIR0lkR205YjJxNVBzVEl3WEI0?=
 =?utf-8?B?OFRuRmhNbVJZMzgwUUdwRnMrelRTanFJb3p6ZnpRTjcyYkFVT3d4Ri8wR1p5?=
 =?utf-8?B?cGlSZjFnWVcxd1NEOXpqeG1GcjFodFpXTHhHdWdOdkFmeHN6c2hxUVVpMnJq?=
 =?utf-8?B?K0p2LzFZejZXd2NtVEtRSndla2VpVUFIajBmNzI5S3VIV29zb3ozTFI4TVpF?=
 =?utf-8?B?cDZqbmZzWjRuV3dwVlZHUk1jdTQyN2FYSWo1dXd0SjlsRDBZZHhLL1ZCbDd4?=
 =?utf-8?B?T3VtTlRMUTJvOTI4a2JCbUx2dnRCaHo0VWF0MUMzRU5OWG5uM1cxUUpZTG01?=
 =?utf-8?B?UFN3V3VMM0ZqQm95elROS1RQdVlWN3VoUG9wbG9GRzYvQkJId0xUTmNTZmJH?=
 =?utf-8?B?T0tLWSszczlrSko3L1lMOGl1WHM0OHRKZjZIaFI5OGlMWFdvd2JZb2NBbi9i?=
 =?utf-8?B?MkQ5R0kwTllvcDM5Q2JEbmpnUjJQK1Z0ekNUb1VRaXBMYzdXU2NiZW1sNExw?=
 =?utf-8?B?M3c5L0tsK3VzUkhpWkRZYnVmR2dJL2JJU1o1cXQ3VjJKMnp0K2N5K3pMS0RY?=
 =?utf-8?B?d2RCZnIwNGI4bVA3d1F1MFFaQ1EwQnBwTmU4eW1KQ3pQd1ZiRGtPNmIwOTVu?=
 =?utf-8?B?MEgzV1dRT1REanRSZUw5WlRiRzJ3aUF6MllKb09MMUFLUGNYQW1rR285QTJC?=
 =?utf-8?B?eG1qWjJkcyt2Y3BVaTJaOGRDNGQrWkVXR0U1UjczU0k2ZmR0czZTNmdFaVhI?=
 =?utf-8?B?L0xrcElmdzFPYjQ1M1VYN0RlVFNuTWpqKy9SeWg2MTl6V0IxVjNtSlVVS3B6?=
 =?utf-8?B?bzdBU1Uxc3pMVHpjemlrYUgxTWxRd0lqRGwvdG5JN3pWMTMycGh6MnRsakpr?=
 =?utf-8?B?Q0xVUUNDTVZHKytnN1JqZVF5TmxpN1RGblJRWUxGRkdWd1Y0K3NNMFFYSE5o?=
 =?utf-8?B?d29zUWtUOXN5WW5KZVorUnJxVDdYWE9Vamh3VGNZUW1oUWw4T2ZvN0xCT0Y1?=
 =?utf-8?B?S2dnbXplTTJSOXAxM3JaNmhmK3FXTko4b3N5YjhUSkpSRkZGR1pPaTVVS04x?=
 =?utf-8?B?YXhSMnBEOFhuQnhHa3FiM0poRkRvdGxTYVUvUGx1TWs3N3hIc0s1MjJKZnlz?=
 =?utf-8?B?WFJyRkF6TGJWWTVqTnpaY2ZGanZhSlB1MGE0NkxBU0FuVHFJa1V0OTd2eWUv?=
 =?utf-8?B?alV2cXRDV0YxYThSZ2V2TFpIZjMyVEo5K0VjUmtKQ0p0Vi9pYUNLOHNMUWkw?=
 =?utf-8?B?MGFXaW1TaEc1d05hcWhTSDZjY2dMaktGWHBXZjQ0aC9yTFFmNkNOOTlyekVy?=
 =?utf-8?B?bXpmWnRwaU1VenB6WVFmRUpmMHliUGMwSk5vUlQxb2o0VSs4Q3FBR2FDdFBR?=
 =?utf-8?B?R093TkNnOEN6Z2NaK0RLNnJkanZ6Uk9vUVU1Z2RPMTdNdmtpKzNDT0Jqa3N4?=
 =?utf-8?B?Rk9lY29QeXB0YXAvOU9DcVNvTFNyMS9BZi84aWJEYjJFTktXQzJFVzQxSWEx?=
 =?utf-8?B?YmVjUS9LUFB6d0FKZDA1NEpaKytxbys3bUpKMUNIbVU0clpjV1lBcVptZ0pG?=
 =?utf-8?B?NkI2cVRGWUJMWEh6bUJWTkdwYzZYZ2JJbHUzWEJQOUc1ZTJSSTRuWmUrM3Ba?=
 =?utf-8?B?Mi9rMUNDbVVXUTVSeDNhb0FNYTBQS29aTnlUNGFlOXJ4bHNZME1ZUzl5R1Vz?=
 =?utf-8?B?aGxySXkreEJ6RXZid296ZWpGM3kxWm5YUVpoWEk1dDY2R1pBL09zaU0zMVBV?=
 =?utf-8?B?SS9vb2NzRUwva1lhK2p3MzNvQnNmY25QR0JKV2h4UGxiOHVuU3BHUkVKRStp?=
 =?utf-8?B?TGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2308fb8-c2ce-47e3-1190-08db3b9b6766
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:18:04.5605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FIcM41EGCVMNM5DJJxfLDI4xcOLafa7dnhtwJRAUfvTVGqN4thmoJ8QlC+gof29hcaHCmGgOyPRSSJkLQfLRustYH+fqbehNJvjswZYDbPY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7783
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> Commit a3bb8f521fd8 ("net: mscc: ocelot: remove unnecessary exposure of
> stats structures") made an unnecessary change which was to add a new
> line at the end of ocelot_stats.c. Remove it.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_stats.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c
> index b50d9d9f8023..99a14a942600 100644
> --- a/drivers/net/ethernet/mscc/ocelot_stats.c
> +++ b/drivers/net/ethernet/mscc/ocelot_stats.c
> @@ -981,4 +981,3 @@ void ocelot_stats_deinit(struct ocelot *ocelot)
>  	cancel_delayed_work(&ocelot->stats_work);
>  	destroy_workqueue(ocelot->stats_queue);
>  }
> -

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>