Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <90ee1533-008c-f90e-5f23-f3c42cda85a7@intel.com>
Date:   Wed, 12 Apr 2023 14:18:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 5/8] net: dsa: felix: remove confusing/incorrect
 comment from felix_setup()
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-6-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-6-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkIvdjFpakgxaU1HaGFoRklaQUV6OFJuU3ppU09HamtmcWZFbGl0L1ZFYzBD?=
 =?utf-8?B?Q3VwWjIrZStpSEtRZzdFNURhWVA4bFB6dWhEK2lIRU1jN3ZNR1hDajRmS1Zm?=
 =?utf-8?B?M09rakVXOU9Ed0QyZlV1K3RLWGV6eFdYWDdXTXZHK21ZK1kraUk5ME9RZkJD?=
 =?utf-8?B?c25tTWxUVitDakZaTjVhUko4cFZZRHhna3h4ODR2Vk1DQ3I0MVU0MnZSWldl?=
 =?utf-8?B?cHNrSUZwUEE3cWVmb1JQeEZWMUs5LzEwV0NVb0tGQzRzVzR1ZzBTTVF5MW5U?=
 =?utf-8?B?RFRrLzBnbVNVenZ5cy9md096bFFtYVpBZFR2Sk9QOUVCWlQ0VlJzaXJYTk03?=
 =?utf-8?B?OGhFKy9MQWx0cDViZFJHMmQ5Wmd5akFFQWZnaEtMbWZPclEvZ0ZMK09OUFJS?=
 =?utf-8?B?QTZkSzduTHVyRXRxc3R2TFFEMUd1ZlBmcXI0YkVySllQOENOODR4RE81QXFo?=
 =?utf-8?B?WnVhMFREeFZjYVJFVFRaMXhEM0oxZkNYUUVCMTkxbHIza0YvWGoxYUd4OGRy?=
 =?utf-8?B?UHFNRXBpMy9wV2c4NXNuOW11MWxwbmtCdzIrU0JhU05DdlBBcU1lYjFzVXQ4?=
 =?utf-8?B?SUxSTTlUTnM1MWpaUHhIR1AwYWhOZXE1dzVuRitQMlFFMExQN3pNWFJSRjJM?=
 =?utf-8?B?TkRHL2VjdkpGc0ZKckdvUVUwRDJtQW4yT3JvZlg5d2ZMd1B2cEhCY0VESnRr?=
 =?utf-8?B?bnZCdXJzallGZXlxQjA0ZTZqWm9iRzBmbTB2T24xWEJ4T3JuV3J4c1ZEMW41?=
 =?utf-8?B?cFZsUFM1SHUzUGJKbHUrNC9XQmw5dDNLWmI4Unh2diswMmxhOHBHK1JXR1dG?=
 =?utf-8?B?U3JXN2QydUZjWkVLSDkwRjZPTmw5UDduUzN6WEcrY2s3ei8vWk1GVDdUN2tK?=
 =?utf-8?B?ai9TMFlsMzdhM0poL0VtcUE2OUJWNGZiVlU0eHJNOWhmWCtuTE90VmhSdVFq?=
 =?utf-8?B?TUozM1hpZ3dOK2FJZ0NGQWI1U3EzeXlQQjRVYlJ5VlNCRzdpYUFTSzFnMzhi?=
 =?utf-8?B?eSt3Y3pzYTJtMUpoTXYyRS9tMGhjTFZWS0pvRjlRN1h2VHU1YlpYdUsrQklp?=
 =?utf-8?B?aFVNcytqRWR0MFZsYUZpN2YyMFplUkdmVUNMVlJTRnBJRmxjZ0lySTBlaUNk?=
 =?utf-8?B?UGwwNlU0Wmg1eWVxMHM0UXh5dEJDUlFoWW9BcWtiRVR0TG5ROGE3akxUNktU?=
 =?utf-8?B?aCtRZ3hTSkN1VnZJWFc3YkF0ZXcybjcvRjhPdFFlV09kUWovb1NSM2daZmIr?=
 =?utf-8?B?TG9HdE9MNCtRQUN1citqVGExVGhCSVJXSEhpdXV0cDROcDAwY3hqQU1KUnM5?=
 =?utf-8?B?bWl5OVVpRHhHa0psWGVaaDdMQks3U2FSMlhwOUM5c2xZR2tFU0UwMWlzeUR5?=
 =?utf-8?B?MVE5ZTZYalhTYW1BMXpoREpCL0w1TWQ5L0c5ZURLQW5XK2dlQ29FTXJINHFD?=
 =?utf-8?B?cFhmZXhLUmJlRVZnTTZja1l4UWc5ak9zNmtKTzA4QjBydm9mSWg3Kzh0SlE4?=
 =?utf-8?B?RXMwZ0RRajJ3Y3luNDFLelR1d0k5c216dk5lV1ZiNFI2VzJhYnloVS9Ea1h2?=
 =?utf-8?B?OFBrczBMVGpscDZOSGp5eldCQTQxR1d5YU1UU1E1SUFFR3laL0d4eVFrSzlt?=
 =?utf-8?B?NFI5c2N5MVNrVndHWlNpZmxIOXB4djVOS3BYUGEydGVLVmZDOHBmb1dXTHBm?=
 =?utf-8?B?K0JxOWZORlgrbWszdzdCbVl6V3JlNlJQQmVEVHR6MW41b01jbVIzcXd3MUFa?=
 =?utf-8?B?YkJWVngvTUsyUHhqRlRwMCtwNGlvSEVscm5UemxGZHRGUjV0eXJuUTE4Wnk1?=
 =?utf-8?B?N2h1K0lmUnJMWDllSkExdm5jRURoMkU2K3BRNk9QTjBNd0taOTFjN2JuR0hN?=
 =?utf-8?B?biszZmh0VlhhbjdnQVpMOEg1M1o1VnNveTM4SXN3NUZPaDF0YkRkZHJBK0Nx?=
 =?utf-8?B?cDhzK2E0OEQrYnlEeVZtaEpOTWNXZXU4YnpKOHA1eDM3TWhLVDJxankrNlFU?=
 =?utf-8?B?UWdSWi81WGNzNmdleTl5TEkzd1VOME5oNHhyS1F1bWpMVDUybmVuMDFVaWxr?=
 =?utf-8?B?QVdBZjQ2c1pVbmI0TDgwbFVxWmpXSXMwQ21idjFVc2hUT1F6cCsrUmtTby9F?=
 =?utf-8?B?TUhuR0d6eEtZOUdMM0tZc29LMnVoWkQ5TnU2Y0xiMEdMTUtmN29Sc0FjT25q?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c041b5-f8fa-4fe4-5bf3-08db3b9b82ec
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:18:50.7651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lHvBaITkrB8K8QUPxvawgeE5UeAwipgWJU6/yoIiH+Zbjfot5XGxLGfb9sTF5vZQWHHbcVVrS7C62wFw5R+ljV8UU+IeH+/51dykF4ekJs8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7783
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> That comment was written prior to knowing that what I was actually
> seeing was a manifestation of the bug fixed in commit b4024c9e5c57
> ("felix: Fix initialization of ioremap resources").
> 
> There isn't any particular reason now why the hardware initialization is
> done in felix_setup(), so just delete that comment to avoid spreading
> misinformation.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/dsa/ocelot/felix.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
> index 6dcebcfd71e7..80861ac090ae 100644
> --- a/drivers/net/dsa/ocelot/felix.c
> +++ b/drivers/net/dsa/ocelot/felix.c
> @@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds,
>  	}
>  }
>  
> -/* Hardware initialization done here so that we can allocate structures with
> - * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing
> - * us to allocate structures twice (leak memory) and map PCI memory twice
> - * (which will not work).
> - */
>  static int felix_setup(struct dsa_switch *ds)
>  {
>  	struct ocelot *ocelot = ds->priv;

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>