Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <003aa645-187e-f0d7-fe69-fe86a3d7226d@intel.com>
Date:   Wed, 12 Apr 2023 14:19:29 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 6/8] net: mscc: ocelot: strengthen type of "u32
 reg" and "u32 base" in ocelot_stats.c
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-7-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-7-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnQxOWJuVUlyM2FkT3BYQ25uYlNnVFFVWEZuMk5UQ3kxWldLdEpNZGhXaEh6?=
 =?utf-8?B?OEQ3L0lXZ1VkU1BnVHJRU3pNUWw0ei96Z0FtYVdYK293c3VjRjhBYUtBemIw?=
 =?utf-8?B?N3FZelBTd2QxMVFKWTNMaGxHcmV4MTBrbFk1a2t5OHNqOW9MUUs1SDJjMm5w?=
 =?utf-8?B?ZEt4d2hoQzFvelRKZm5nK2xYSmVPQzBFS0ZsQWtyUjIrL3didnZwSHpSVWVF?=
 =?utf-8?B?RFFMV283VWpoOWhNRTJkTzNKTy8wMEQyMkVmOTlJNm5jSU9YS0MzSXFvZGd3?=
 =?utf-8?B?Q3RBcU5iL3I0VUVvQXlDb00rbWpQUXd2L1hCQzBQZlhqZ0w1SlNXV245UUdG?=
 =?utf-8?B?eDNsdm42UytORWtrN1kzbk44akZhcW1GUFFieWI1Yk9rMS9pSkpMejVFblFO?=
 =?utf-8?B?WkoxaDNMUmNqZFk2NkVvNml3UnNNeEwzZFNobi9EcTJoQkFWc016ZEdGNmFa?=
 =?utf-8?B?OHdGMVg5djNUTEFuY3M2c1RKWEJ5Vk5MVmVxalk5K1NuWVJaQ1dyWXBoRkxQ?=
 =?utf-8?B?cDdCVTRRYXNXaVhIdy9qYWFQMzRaSlNac1VMQ0JuL2EwYjNyUFUrNFpWNXJk?=
 =?utf-8?B?M1ZLbE44RHVKYmx2WWJYRlB1dGo4N0dZeitPMnNabkxpL1kvcHNwSVBPbmQ5?=
 =?utf-8?B?eHcrSGI0T01sUVgyUnNuUkNlZjlBUzdqd1BYQUNTY1A1ZzNBTjhkcUhmbzZU?=
 =?utf-8?B?Q2lmc0lZdzUydnVVS1k0MDN5dmhESmtjUWVlR0daajlKczE1b3pBbC9sVjRE?=
 =?utf-8?B?Q0dKRnJESDMrN2hwcW1ZL1BCRkt4RS91MytqTi83UDh5RnBYWkx2Y0RxZG8y?=
 =?utf-8?B?dmw4aG9oSGhySFJ2NUpOV3c4TTQ2dzJCZ1l1RFpQOGJ6VUdiWmduRStRQ2xv?=
 =?utf-8?B?MVQ0UnllTTFmOXYydmdDaHBpNTU0dUkvQ2svWG5LckRuUTNmanRhT1VnTHZT?=
 =?utf-8?B?MTVUQ3RKUW9mUktOZ2xjY0xpdC9CUzlReWcwbVIrU29XSitncUltZFRrSmt3?=
 =?utf-8?B?akVkSzcxRVVQSkgzVC9kak15QUtIYll4ZDVhcFFNcTBxd2pmU3JXNGVYaWF5?=
 =?utf-8?B?WUhTc2dnNDIvU0FMUGZrSC9jak5nU0hsbllVR2I2eUNWTC9lZnV3Z21SaU55?=
 =?utf-8?B?SjVnM1k1UmlUU2l1UndZZDhXdVQyS1pnUlhGZVNwWGx3aGJ0dXFkTGZzS284?=
 =?utf-8?B?bk4rVE15Q0tydkc0a0VzVFJvNXVNUmg1cHkyMzNKdWJMcGZMeTlURGJ2TmNN?=
 =?utf-8?B?ZUFlalNJVzhvbFR1SU5DNEZJcVlRYkw4MEo0NVkzVEVMRG95UDlRYkRWZWZF?=
 =?utf-8?B?blBWQmp3VXdXb1V1L2I2WmN2RENubHYwR2NLMTZyUVNmajh5c2xNaVBBV3BT?=
 =?utf-8?B?cUREd1RvQ0J2djVhdGtKZ1k4ZXBTNGR4MGNWZm1WTzZUMVJNYmY0N0xqWkta?=
 =?utf-8?B?bUtIbUtQYWpnU3lxbGdkVGpxbnpEN2lKdnpwY2JPSHJXdEpWcWxDSDcyOU90?=
 =?utf-8?B?QnJ3WUdSNldlYWt6LzBaME9lbVQrMk1xOWxPRmJBb3AyeWVOeXdLYlIvbDFD?=
 =?utf-8?B?T1k0TFFxUElISVR3S0hzeHFYa0FPbXJQVXI4SysyTDB6dmYvc2tKT0lCWEs4?=
 =?utf-8?B?NVlvSVBya1grN2x6TmZUY0ZIZG1OVWxFc3U4eVFHZFB2cG5PM3hTZHR4ZU56?=
 =?utf-8?B?c1B3TXBzTEMwa1VrRSsyZGJFbVVXNkczZ2R1VDh2Szlxcm5xWkJiY0NDcGx1?=
 =?utf-8?B?NHlnU1d4WFRQekYwRGRzMlpsWkJkNDEzeGpBYTVVOWZPbW5nTDhGL1grdHpC?=
 =?utf-8?B?c3htbmdSUW9jZlM1eGdQN0diSWlDdU5STWwvSU5FWVRVSFBBQlZjTUVXQW9I?=
 =?utf-8?B?WXM0MXM3eXJyRk1IcHlaVnhCTTJyU2JlOEZ2OGlrZTFmeTM0WmQwcGcwK3FE?=
 =?utf-8?B?VmF0RmY0enpTMlVUMXE4aVl6bDlWRlV4dWxIR2xZLy9KL2k5SDhJVWZ1NGVC?=
 =?utf-8?B?YnFwU2J0bEZNaVhYMUZSbmw1YWQzR1lJSmpsYnQ2aFB2Mk5hSnBBOEU0dzlm?=
 =?utf-8?B?K1F5b056Zmp0WWljOS8rT0RDQ2Ryd3A2Nk5UdFQwUXNmMkVOSDVIS3BYTlFU?=
 =?utf-8?B?YUtueHg0MDY0Y2E2MGtXY1JzVFczeFdjSDM3RHZWWTRhUUQ4VzBKSnVkRHI1?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 709eea28-b351-47bd-1ee7-08db3b9b9648
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:19:23.2266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ovvr53sPCEaDCk5yWPybWTWjWLA9UkRglN1Ljh53gQpdUULnhX5YgYg38GgNp7Nu8C5K9M5UjUTGFYyZhMcsika4hvmDVxz1qzg6ajsJpA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7783
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> Use the specific enum ocelot_reg to make it clear that the region
> registers are encoded and not plain addresses.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_stats.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c
> index 99a14a942600..a381e326cb2b 100644
> --- a/drivers/net/ethernet/mscc/ocelot_stats.c
> +++ b/drivers/net/ethernet/mscc/ocelot_stats.c
> @@ -145,7 +145,7 @@ enum ocelot_stat {
>  };
>  
>  struct ocelot_stat_layout {
> -	u32 reg;
> +	enum ocelot_reg reg;
>  	char name[ETH_GSTRING_LEN];
>  };
>  
> @@ -257,7 +257,7 @@ struct ocelot_stat_layout {
>  
>  struct ocelot_stats_region {
>  	struct list_head node;
> -	u32 base;
> +	enum ocelot_reg base;
>  	enum ocelot_stat first_stat;
>  	int count;
>  	u32 *buf;
> @@ -889,7 +889,7 @@ static int ocelot_prepare_stats_regions(struct ocelot *ocelot)
>  {
>  	struct ocelot_stats_region *region = NULL;
>  	const struct ocelot_stat_layout *layout;
> -	unsigned int last = 0;
> +	enum ocelot_reg last = 0;
>  	int i;
>  
>  	INIT_LIST_HEAD(&ocelot->stats_regions);

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>