Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <794f4bb2-ea10-1d9b-96a2-e14df75c81df@intel.com>
Date:   Wed, 12 Apr 2023 14:21:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH net-next 7/8] net: mscc: ocelot: strengthen type of "int
 i" in ocelot_stats.c
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        <linux-kernel@vger.kernel.org>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
 <20230412124737.2243527-8-vladimir.oltean@nxp.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230412124737.2243527-8-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTFyZUZDTThmbGtSLzVuUFNMQUJWVFVFMENEdmRLcHUyTXNrUzRyeHJIMHh1?=
 =?utf-8?B?Nm4rb1gyN2dHL2ZQMkMzTnoyYit1cWVjY2Z4V251ZTh2VUVkVkJmNFdpaGhm?=
 =?utf-8?B?clFpYkhLVGJnMXJQZ0Z1aUE1ZENKTjgrWWJpZC9HV3hia1g1cFVYTEFFVXgw?=
 =?utf-8?B?bWFiWU1Ubm00TlNlUnlDSkdDM29sSGdDVkNHeXl6YkQzTjVuSHVmNHUyK0cv?=
 =?utf-8?B?NzQ3Q2JnV21tT2dNNFR0MDl1dnpaNUR2cTMyRzRpNGVaQ1pOb2N6MTRVWDd4?=
 =?utf-8?B?S0tWSTZLUWttOXRDK2p5MXJsZm9CN09uS3VkWkd3RUtPZ0h5TlRjQThnaW1s?=
 =?utf-8?B?RFltVDlJSmwrcW0rK3htZ050QkRLWXlkbWg3L0tpbHZUOWJBd1IyaHEzVlVX?=
 =?utf-8?B?LzR5bUt6blEzbXdwSTJXREpmMHBsZlZudWdndytQM0poc0xwMEZkUnRDc2VX?=
 =?utf-8?B?TWs0T010cHZxbTROemNUR1d2U3NGek1yOEdaNTlrUkhTZUdmaExJaHNNZFN4?=
 =?utf-8?B?MWlyYk9HQUEwTGxWWCtYZHN4TDZSdk00azNPVEZtWU8xcmJwSFFZKzBNN3V2?=
 =?utf-8?B?V2Y0emV2bTJyRzRhSCt5Qzdia2NIenJ4TkNsSGIrOWJjRnNydUpiRUYyTWE4?=
 =?utf-8?B?ZDFTSVEvUWg3aFp5anExNGtJQ3NnUUZYdWdFRVZYNEVNQlM2VnVFVEhhMlpE?=
 =?utf-8?B?SlpvL1MxbTZMQzUwMmh1RmxTVytuZEJHYmpSYWFQSXFkWTJsdmtkQ1crVVBv?=
 =?utf-8?B?TEpYNjNCdGs5Mm11eGkxZzcvd2F6b2hMOUQ5NzBZMGhXNktUTmp0eWNMb1FG?=
 =?utf-8?B?Sy9wRmxHL0pFOGM2cXRpM25FV1lYZ3Y4T3drZU4zOXJ1b25OcWxHckFmUlN1?=
 =?utf-8?B?UTZ1K3RLNWlkSUNvVVlBUTBkVHExR3dWUHZONnNocW5xMWtlbTVhT2tQRG0z?=
 =?utf-8?B?cUV4R2hWcldHcGpkc2hxeTdsRkRvNlRpaEpIWERqUWJWdWxZaTNCQmhtaG96?=
 =?utf-8?B?Q1B0ZGZGRFFJcHlRWW1TaUZWTmdHenBWS3hHbjRheWdNTmt6bVBXYklKcGRu?=
 =?utf-8?B?b0hTWHZhOUVOd01RMi8zRzUzeFFNcWplL0taaDVsdk1GSnd6V1l2RG9kWDhk?=
 =?utf-8?B?TkZRRC9mcUJzTit6QzNaN1ErY2g2Z2xWTHFNNWRnYXZsVnZzR2EwMHhTK1FV?=
 =?utf-8?B?Zy9sTVZaNmU3ZWp5VEdoL1BMS0YwdFhKREs5NndqblFRRmVwcXgxR1czTmdK?=
 =?utf-8?B?VXJzWUltM1dFNUZOUWIvMmJTNkJFa2NYc3BHbHFMSlFiaXpFQmsxNFRXTXBY?=
 =?utf-8?B?bVRSOVZUQktJMG9jOHdnVXFYc29lSVJ3T21EOGZERDFsbEFQQXhFeWQ1Z0c4?=
 =?utf-8?B?aU9pV1NVZTNGSnBPaGhkT05WWGJwNTh3UWxBTFRuQ09RZStuNC8vUFREd0FD?=
 =?utf-8?B?VUNqcmJRbm1Sb1dlMmk5MERmL3N6am9EUzVmWGROcFVYMWNHa3dNRW9BV0Nh?=
 =?utf-8?B?WXV3MjRiQTk3b1FwUHJuOUFRdmdaaXczdXBweHh5QlVjMTRTWnJaR1Ivb0Na?=
 =?utf-8?B?Z3FsTTgxUGdXMURBK29zV0p6RWxqalhGbk42dTdhejFLYjB3RTFvaHY5ZVZL?=
 =?utf-8?B?a0dxMUhaOVZ1OUkwQlduTGY4dGtLZDA1TVRwQ2NyM0t0blpGZmpWblNEUmxN?=
 =?utf-8?B?YUVFdUsyZUVzSnlIcjN0dmpheENWYitBVVRhWmF0ZEE1alNKcVNYNGNPMnZu?=
 =?utf-8?B?MXAzUEhFSDVLdk1GcVpEU1ZUNStySm9DSVVBakdaUCtXblNJaWp4UWIwelBC?=
 =?utf-8?B?TDVJN0FkZk9taG1vbFZZMm8vY2lsdXA2cGRMZHl2L003V3Jna2w4bnAvYVow?=
 =?utf-8?B?ZW1vWUNidk90OE1VVFN5djE3Q2pHTElneHRDUUd5U0RyK3N3czc4SmxNS2xs?=
 =?utf-8?B?MktkaEZjQmpGMW9PU0NnU2dCWXZtdkdFQm1ZalRVUHlwYm9Ya3luM1BBN0Fz?=
 =?utf-8?B?aElXK3NScXBTaDNScC9QWm9SYWVrR0JycHdQdFV0SG1mVzBPZkRZR2Vrcnlm?=
 =?utf-8?B?cTM3SGp1NmY0STlHMTVwY05nejVOS3Yza0Y3MFJDMmRRSjE4NkNVV0htT3Bv?=
 =?utf-8?B?bHFyS0xTbE9Yc3VpQkpVdTJEZzk3WlRMRW5KbUVkcTE3T0huaTU0ME9MQ25G?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e7df719-99af-4988-eaca-08db3b9be0a6
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 21:21:28.0346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oFXKNR0FZFQq1uGwZ0S964oWf9fu/T6hGn25gwncatA/q/ZEawAd5iIFvnY5rr+YA8x7Rarh8hpbcA1l2RVuBm1BOrXGMC5uMHHqw7oyv+M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8322
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/12/2023 5:47 AM, Vladimir Oltean wrote:
> The "int i" used to index the struct ocelot_stat_layout array actually
> has a specific type: enum ocelot_stat. Use it, so that the WARN()
> comment from ocelot_prepare_stats_regions() makes more sense.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_stats.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

For the lazy readers who didn't dig up the source outside the patch
context, the WARN in question is:

> 
>                         /* enum ocelot_stat must be kept sorted in the same
>                          * order as layout[i].reg in order to have efficient
>                          * bulking
>                          */
>                         WARN_ON(last >= layout[i].reg);

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>