Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b92e2f18-4fd0-0510-4a85-36d7a200c9fe@ni.com>
Date:   Wed, 12 Apr 2023 17:24:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 tty-next 1/2] dt-bindings: serial: ni,ni16650: add
 bindings
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     ilpo.jarvinen@linux.intel.com,
        Gratian Crisan <gratian.crisan@ni.com>,
        Jason Smith <jason.smith@ni.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230329154235.615349-1-brenda.streiff@ni.com>
 <20230410211152.94332-1-brenda.streiff@ni.com>
 <20230410211152.94332-2-brenda.streiff@ni.com>
 <b2f81c57-9b7c-9ad6-6ce6-cc94703599db@linaro.org>
From:   Brenda Streiff <brenda.streiff@ni.com>
In-Reply-To: <b2f81c57-9b7c-9ad6-6ce6-cc94703599db@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWd3RDJPL3MwNEFBcGR4UWZUallrR1pOYng5S282WkJVWUMzMGtjOXR2WDNr?=
 =?utf-8?B?bkk2WlRaYVFFS0xQRDdpeUpzU0trVDVZdnF1R2JLVEVrdG1OcFhwTzlTTmRr?=
 =?utf-8?B?M1o1U2ppVi81MHRmWVZKaXA5VXgxb0c1RlVuVVV0MWlvbVBwcW15UDBCSWFj?=
 =?utf-8?B?bDBPRDEwczhacGpKdGZLMWlaUjY1LzlMVG1hQ3R2cy9GZWlwTWN1V2R1OERO?=
 =?utf-8?B?VGJzZDVSYmROTDQwRmNLaTEzeEkycHFLTVRINUdwUHQ3cXRjL0ZVK0VTWlNx?=
 =?utf-8?B?Ujc4NlEwVDBNTlQ1dHVSdkNGakV0SkNQekQrdW5MTXF4RTNSS3FXM1VBZTdW?=
 =?utf-8?B?M3A3Tk5MR2Z6VlAvT1psam04aDYwZTkyUG13ek95a1hxblVTTmpiQVVNLzhP?=
 =?utf-8?B?ZFVRRGNCeHNXQjVLLzYyNHAyVHRtOUdnWmp5bmlKbEJPeExEcWgwc3dCSExV?=
 =?utf-8?B?RkszZDlER21VYkg3UDhrQndySCtuSlVReXFkdVkrU3RxQ05FSU84Q1ZHN3Jr?=
 =?utf-8?B?YlRZRDdMNnhSREhHTWRIRWFFM3pzSFV0bGc2OXNHMHlOOWJRMEhCZFBpV1hk?=
 =?utf-8?B?ZkJLVjVuWkN3V24vaEFjWVdmSGVSTE5wOVpoT2JpYWxSNVhuTGtsT3VpRWVu?=
 =?utf-8?B?YVROTDFERzRJTTdaY3ZJNE1PK2tVZTlxZHByTEhSaUZJeGlLTEJFamdDZGNy?=
 =?utf-8?B?MzQ4d2NweFBjcVcvTzR6K1lvR0xnbjNIQWJEbzNvdENzRFh1UjFwRUNKQTFy?=
 =?utf-8?B?ekZBVW03dXcyVlRUN3Z1YUxGZ21mdTNadmFXWkRzTFZXckZOaHlaZFY1YTRv?=
 =?utf-8?B?TXJxajdFcDFkNE1vT1R2czc5ajVvNmUwS3NUOXdTb1h2MnczRnpLMVR2Y2JI?=
 =?utf-8?B?b0xuQy9rbGx3d3J1dGwwTmlQMHpVK1ZkOStNbGNCa0pyMzJwRTBPWWFadFoy?=
 =?utf-8?B?VHYwWjdocFN4QitoUmh0UjNieE53dmRiQWN0U1ZTZVRrWTFJQXJPSHdNNmxl?=
 =?utf-8?B?NjVPdVF3WHBGczY0RXdXRmIwbWI1Vm5tbHlLTDJwOEpVWk5kNGVEdnZXZ2Fy?=
 =?utf-8?B?WFJUUC93UWVvV0FPZlk4UjZnZ2hoNUZsL0kyMVhKL3Q5N0xseDZ0NUduR0wx?=
 =?utf-8?B?YmpiQk9icG8zb0RFQ1lWM1U0SDMvVXpDeG9GcGlhNDczRHhjY2ZscVFodnNt?=
 =?utf-8?B?UXRpb0Z2VnlBUTBiTUFubE9KSFV6ZkJYd2dkTWFLUjJKSFNtUGlUQTJISXZy?=
 =?utf-8?B?YnBKanVJdUdaUWhVU0lsdnRITGp6ZkxyUjJBN3g4RG5ZSzZZcFFUR3pCc1Vr?=
 =?utf-8?B?UEVqUlV3Q3RuR2RDVzBQelRySFc0SzJVWjBNdzRsT0Jjd3pkZElUMDlOclI0?=
 =?utf-8?B?NnpsVWFiSDFyKzJwOFdXSEY1SDVHZ3J3Uk10dUE2UzlwYld1UkFHRFpzeWp1?=
 =?utf-8?B?b3dnd3QrTnhidDg2QVVlNG83S3BZZHRiR2pkdng5akZQTG0zR0hMdVVPNnJZ?=
 =?utf-8?B?TFhqRCtHMnNQU3pyZzYreWUrUjA1dWtJaTFZOEM4dmNOV0JPYVZqWVI2akpz?=
 =?utf-8?B?N0JPM0FJWXlycFU0VnQyYmRuODJxTHRlcmZNbWdSRi9VQ0pCNi9KTlphRDIz?=
 =?utf-8?B?OFNSU0hVVkFuS0xkWUE1dTFLczF4NEtQY3A2UEhsZGQ3eER2Mzg4d1h5Nk9r?=
 =?utf-8?B?UnEzM1ROV0pVNkxDK1ZRdHdHMHBBNmRIOGt3cWlpTXMxWUpiakR0czZpa1BR?=
 =?utf-8?B?ZGpIZ1ZsYW1XV29wekpPZ0g1MDRDY2hETFZGK1IwVEdyQituSWhma1duSWFw?=
 =?utf-8?B?QnE3VkFkWUVRbHdoTzlSUVFwaDU1T1BXRU5yVlpsQy9uZ3lybFlrSDNpSWdT?=
 =?utf-8?B?dWkyMHdHNnFEY2RvQ0kyWVQ2U3N6c010a09relAwRnp6dmZ1Q0hzdWJmZUM3?=
 =?utf-8?B?TWNzTm1USWwyVU4ySWNOWXN2YmJoMUZVVHhDbDA5RXlYM0c2aUxZU0hZakVI?=
 =?utf-8?B?TXJZUHJmNkNVamtMTnYxUkNPbngzem5XellZblBWK3RINVRNandXSDFYTEQv?=
 =?utf-8?B?S0hDNGw5dWp1UUw1aS9PdHlXdEYwSXdWUCs0dmx2MHRmaU1PdTVmMEYyMVQ3?=
 =?utf-8?Q?Lh2Pe95uio8VlG0iCgvsl6u5F?=
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22bad68f-c2bc-4651-5e47-08db3ba4a032
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4973.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 22:24:05.3259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HvRYXUcfLv9BTWtmtXR0vc//fm7I2McigArGVnLSbGyvkSFplS29D772uhPMUhzjF6ARUFSvKycYK0d+Uinynw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6766
X-Proofpoint-GUID: HkIAh_08iApyIVwZ6CtVdLI_Y7EnVPys
X-Proofpoint-ORIG-GUID: HkIAh_08iApyIVwZ6CtVdLI_Y7EnVPys
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-12_12,2023-04-12_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 suspectscore=0
 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0
 priorityscore=1501 bulkscore=0 impostorscore=0 clxscore=1015 spamscore=0
 mlxlogscore=959 mlxscore=0 classifier=spam adjust=30 reason=mlx
 scancount=1 engine=8.12.0-2303200000 definitions=main-2304120190
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/23 00:44, Krzysztof Kozlowski wrote:
> On 10/04/2023 23:11, Brenda Streiff wrote:
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clock-frequency: true
> 
> I missed it last time - why do you need this property? You do not have
> any clock input, so which clock's frequency is it?
> 

This is the clock frequency of the UART; on our x86-based platforms this
comes from the LPC clock, on Zynq-7000 it's derived from a clock in the
FPGA. This is used to set struct uart_port::uartclk in the serial core,
as it is for other UARTs.

This clock frequency can vary based on board design (especially on the
x86 side, due to different LPC clocks) but for a given design is fixed-
frequency.

Would you prefer this be documented further? I was following 8250.yaml's
lead here with the simple `true`.