Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7038215-f821-0f44-436a-192058683fa5@intel.com>
Date:   Wed, 12 Apr 2023 16:06:09 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [net-next Patch v7 1/6] sch_htb: Allow HTB priority parameter in
 offload mode
Content-Language: en-US
To:     Hariprasad Kelam <hkelam@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <kuba@kernel.org>, <davem@davemloft.net>,
        <willemdebruijn.kernel@gmail.com>, <andrew@lunn.ch>,
        <sgoutham@marvell.com>, <lcherian@marvell.com>,
        <gakula@marvell.com>, <jerinj@marvell.com>, <sbhatta@marvell.com>,
        <naveenm@marvell.com>, <edumazet@google.com>, <pabeni@redhat.com>,
        <jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
        <maxtram95@gmail.com>, <corbet@lwn.net>
References: <20230410072910.5632-1-hkelam@marvell.com>
 <20230410072910.5632-2-hkelam@marvell.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230410072910.5632-2-hkelam@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmN3RnZROWoxU2NEZVh1dW1YSDdUcTlqLzA5dEV0dlp6aDJIUmNRRFFIUFMw?=
 =?utf-8?B?OEJmOGV0MVdhaCtBLzdGTTdob1VuaThjVDZOVThDekVrQlpoZk0yNkdmYkVF?=
 =?utf-8?B?dm1CellaUzBFU2lmU2VVRG11MTNuSk13WUpyTjB4N2JZdHNsaDBPaVo3R0pz?=
 =?utf-8?B?M0VodmZTVGl4VlpPNjNPeThDZk0yeHoyd3R4MUJSVVpFNnVxNitudnArV21n?=
 =?utf-8?B?VXRuTVR5UkltYkJRei9ONzlteHV3ZElqOTBFM3poamw1WDNnNmRoMWZXWU5O?=
 =?utf-8?B?aUd4aTEzTDA4VWRkbTlsYzZZUGlEOC9hUTl3T01rTVV0TkYxNkt2Q3ErblA0?=
 =?utf-8?B?K0llU1ZIbEQyTnlLU2hYUkI1UDc4eWxGRXBNbkVFTWtlTERFbW92OXJqazBz?=
 =?utf-8?B?Ny9tbTFBazNpdS9YaGkvcWszUTVRNTdTbVowTHVwMGxpanpJR2ZteFFWbzJO?=
 =?utf-8?B?cWN5V1Y4RTNyaFJqWUgrSkJrTFNYaTFPUnNVVXJpUkxRaGdSTmpSNTZINVUw?=
 =?utf-8?B?Wmtmb29oUGV6YjVVQ3c1VXNMWGpQSklYeTdOYU4wQUQvOEFqMDZLU3RydzdT?=
 =?utf-8?B?Z3F6eEVFUWdpUDM2QjVvR09iUnE0Q3pCTnozTktlbEc0UFo5NlNXTFB2SS9w?=
 =?utf-8?B?akdLQkFDWjlXUU1nZ1Z1cm55NGR4MDBvUHJzV3RSV3NJTXo3UmphMVRIc2pW?=
 =?utf-8?B?ditSMk4xZmFOVGsydHNSelQwT3VzZUp2Z2ZIazFxS2JhZzBLL1B0bmppN3BL?=
 =?utf-8?B?NU91eHRaaWRGS2dsQ2l4MHlCaXAzR0V2L2k1dUp6aDdOUmE5dk1YT0hlblB1?=
 =?utf-8?B?ZTBpQ1VSVWZVbTNlTWNUZFlFYWN1SzNIYVZvRHdnZkRHZW9lRkNMWWZsYWZj?=
 =?utf-8?B?VUFjYUdiVWZHbFQrM3lLSmwwYjh1L0FtTXRVNTJacTdCM2xOVUlTclZSODM4?=
 =?utf-8?B?dnhVb2w4NjRWbGRmY3BNTlIrWUZBWFQ3dkUrTXdwellUMlpnK3psUndSU3VO?=
 =?utf-8?B?NTJ3dHZmZFRoUzIrZkNJYkdQTkpxVG4rRFcycXdLRS9nd3M2d0hZMWY5dHlU?=
 =?utf-8?B?Nkk5N01kM0cyOHVOcjNLRTNJVUE4V1IrRHQ3dXlJei9pWEx2dGtDS3RCYlRy?=
 =?utf-8?B?L3AzdEZGcHAwbTdKM0hsS2RnMi9pbkx3NkhHN0hvbjd6bk5oOE04TFdpemlE?=
 =?utf-8?B?aTgvMjl2ZndmQVB1RW13cEJPWTRNOUp4K0Exczg4THhEZkVQT0E1UmtrMWF1?=
 =?utf-8?B?SXlrMjZVN2N6MGthK0FzVCsvaEJBSWpMV3dkbTd5N3ZEK2dZbEpKeXBWZDZN?=
 =?utf-8?B?eFpIL0xEb3NDUEExajFsVi93NFhrZEoxVjJjdVlLbENmbCt0aEZjQUFDeEpk?=
 =?utf-8?B?QS8weEZTazJlUjAxOEg4ZDlMZ09zN1FVZEJhbmViMkJFTGYwck1pK2pLS00w?=
 =?utf-8?B?bFc4N2lDY0U4UEtLWVhNZDlXZmovdWdXWktvYUdPc1llWXBrN2dtVzZDRXVh?=
 =?utf-8?B?bUJSWEczbm9wN1pKQTQ0UzZOMGx6VG8yUlFFa3hXaTE2ZjVNSnE1eVFNVkpK?=
 =?utf-8?B?b0lwUklqUkZrVWlqdklMNXkvTW4zRDMvS2pXZGdOQ0R4UTg3NTNHNjBIOGpy?=
 =?utf-8?B?aG1zWEd1TDcvTlhxV2VwR2JCL1dxNnRrNHBLYTZKUDdFb0xZSSsrbHlMN2pw?=
 =?utf-8?B?ZWZINy9TYnp0YjFQY1FHSGRkTXRtb1g5K2VDT3VvMU9nVjRGVE9tVEJzaEVM?=
 =?utf-8?B?RHF3WG9ONUt6WG1oNy9wQzhNVDk3V1o5RXBLdUE2VVJRbGNreU52dG42aXQx?=
 =?utf-8?B?YmNXZzF2Zk40UGI5OGY5dm1kVXA2NDIyZWRTUU1HUzBLSTJka3lhcW1CV2Va?=
 =?utf-8?B?MXdKMVFtdmRqZGo1bWhFLzdsZ3d5aEdIU1orazhtVGVOZVcycU1Qd1FWeEgw?=
 =?utf-8?B?bVRJWm5UN25ROG9jVXBjSnBUSlF5K1NVbnd1dzUvdUhEWWVmQzJrMWxGRURG?=
 =?utf-8?B?cHBLdUhiaG9mOHV3dFU1VEJuYkhYQjU3bFc3Y1czUk84QlNHY1dXZ0pOekpi?=
 =?utf-8?B?WGZ4bmRjbDY5bzBWSzZBNzJQamtaS21PTmhnbVdZY3drYXpjcWh3cjBaYzRn?=
 =?utf-8?B?eVFpb21RbDZSakcrVGwrRzgvNHg5S2RIa0ZpZ05CWDNlekRjT3lSYzhWcUxn?=
 =?utf-8?B?V0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7312c20f-8be1-4998-5b6e-08db3baa7d46
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 23:06:03.7574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hrnNLuBLXAOKD2d5IMK6KY63xUItfd6jsLKig8khEegCVNAXr6brNnBA3NEjoVlyWoDSJb6KW6apNG7r1SRvQL5pABJIW1rgxlkSN1fa5vU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5968
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/10/2023 12:29 AM, Hariprasad Kelam wrote:
> From: Naveen Mamindlapalli <naveenm@marvell.com>
> 
> The current implementation of HTB offload returns the EINVAL error
> for unsupported parameters like prio and quantum. This patch removes
> the error returning checks for 'prio' parameter and populates its
> value to tc_htb_qopt_offload structure such that driver can use the
> same.
> 
> Add prio parameter check in mlx5 driver, as mlx5 devices are not capable
> of supporting the prio parameter when htb offload is used. Report error
> if prio parameter is set to a non-default value.
> 
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Co-developed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>