Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230407233254.957013-1-seanjc@google.com>
In-Reply-To: <20230407233254.957013-1-seanjc@google.com>
From:   Aaron Lewis <aaronlewis@google.com>
Date:   Wed, 12 Apr 2023 23:06:41 +0000
Message-ID: <CAAAPnDFruYyoT=jT7+H=QXry0DHFyYCTO2cX=Nr=L4JH8g-Y4Q@mail.gmail.com>
Subject: Re: [PATCH v4 0/6] KVM: selftests: Add "instructions required" testcase
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 7, 2023 at 11:33=E2=80=AFPM Sean Christopherson <seanjc@google.=
com> wrote:
>
> This is the selftests portion of Aaron's series[*] to fix incorrect
> "instructions required" counting.  The big change from v3 is to use a

nit: here and in the subject, s/required/retired/.

> common struct to copy counter values to/from the guest instead of smushin=
g
> the values into a single 64-bit value.
>
> [*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40googl=
e.com
>
> Aaron Lewis (4):
>   KVM: selftests: Add a common helper for the PMU event filter guest
>     code
>   KVM: selftests: Add helpers for PMC asserts in PMU event filter test
>   KVM: selftests: Print detailed info in PMU event filter asserts
>   KVM: selftests: Test the PMU event "Instructions retired"
>
> Sean Christopherson (2):
>   KVM: selftests: Use error codes to signal errors in PMU event filter
>     test
>   KVM: selftests: Copy full counter values from guest in PMU event
>     filter test
>
>  .../kvm/x86_64/pmu_event_filter_test.c        | 252 ++++++++++--------
>  1 file changed, 140 insertions(+), 112 deletions(-)
>
>
> base-commit: b821bf96cf3bed0c1c8d34659299a3a1dc47218d
> --
> 2.40.0.577.gac1e443424-goog
>

Fingers crossed that marking this as "plain text" works this time.

Reviewed by: Aaron Lewis <aaronlewis@google.com>