Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1617055rwl; Wed, 12 Apr 2023 16:09:27 -0700 (PDT) X-Google-Smtp-Source: AKy350bsNOwjH18Yp/BhKTlRU6tU8+cHIynj9ArWshbFxiyYpMOZwz+wrVZnTlH8PK/Wb6cb941V X-Received: by 2002:a17:907:1010:b0:94a:71b6:c007 with SMTP id ox16-20020a170907101000b0094a71b6c007mr476870ejb.8.1681340966774; Wed, 12 Apr 2023 16:09:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681340966; cv=none; d=google.com; s=arc-20160816; b=qSNj4Er95Zf9wCr6fQh9edxrlSrN/slA2YSlMopS6UnAGEnhiMgW8Xo0igLVrUKpaL 6/aKaxNhLCkR5vDvaJ8qlo7yRwLPEmKj9XmrFyRGBY7/uDCA1t5pLRDnimg/OCITZFLH gv/H/3xdzP0sFJW7I/IzgU4cufaalF0sGWm/vHEoMs1VsQvSxZ6Cs+MT+iHMQqrLoB9p noujcWV4vCL2Vuwmd1kfjIqZPaqLnhwO9AHY4YWJ5xZH+ct+TsonJrJ4KHeF6woSY4EQ AIgycbFpMv9sOmwi1smoUHcbNRDJT2ilViS0l7hapZLCuRaeTNpLXYa9/s4EnH2Tm/M3 rP0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=dwVaL64KESQ73tFqJhAn+OVsHN/maU89TV8jjV38IOc=; b=LjBvECJOmMiCM1L1gVVQXNqYglXoG0TBlf7n5DJf0BzbLY9cBTlZGlh9id7urIxnHg tuQXEn1Ygvqfk/earAQX8IgEaNv2mE1OIDYLlTPuTw4WFnW52uF1cDe79Df8YCiRXabv vmWk6E6b01NTWYmLMiWFmEoJbGl3ftz0LctywZa8RSXSe6DUl4DMCedxCgyosfpWp4kg lUoJXfBUlhCIfzGW0dXNtJZ19nsEKYqaDbGqO1EFHBCx5QjovQCmyiBPuwLDIxrlL4J4 eMb0mr5EbKONpl7B6Fuc2kk2cFb12ElBrSDZ83z7cdZIW6vW3CYB12Z4PJxgwg50lqnO Qs4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=IGiPbu+K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020aa7d88e000000b005066af6d5cdsi113888edq.297.2023.04.12.16.09.02; Wed, 12 Apr 2023 16:09:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=IGiPbu+K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbjDLXG5 (ORCPT + 99 others); Wed, 12 Apr 2023 19:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjDLXGy (ORCPT ); Wed, 12 Apr 2023 19:06:54 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C005F4EF2 for ; Wed, 12 Apr 2023 16:06:53 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-3e390e23f83so378251cf.1 for ; Wed, 12 Apr 2023 16:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681340813; x=1683932813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dwVaL64KESQ73tFqJhAn+OVsHN/maU89TV8jjV38IOc=; b=IGiPbu+KoqInvTbngvjlV9BcbaEZGiza8BATEXX9C7Hq/shdvgFCJnmLIS8dJbTUpL +wWq1nXNOWIW3v6JGCmtp49pUMDYcdmZ8lOV4lOeWZI8S7PwRhFKGSSZcUQ28R4nzK2t o8ICmCv4pcMevcPQK90x7hBVcffin/c6djXPvnB/oUiu6L7s/VGsF9I9d5Dn4QC51LIW kOwWK9djSWLBeCW8LI+vKYrLzdkZMbUkUOQon66RbDE64eRTEHxy+Gz/mEIrusC47aES Uc7+AhnGVFf/UQX1I5muj4ojIkxKxQjK51QFQ4IrXX2fWMDWaEafb2T/umoJ7LpqHf+8 z1Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681340813; x=1683932813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dwVaL64KESQ73tFqJhAn+OVsHN/maU89TV8jjV38IOc=; b=d1qw/3nrDPa+HYw4gjpGFmKTix+s95YfHrqCl1tfevgmndM5fuSZgj528S8Tdihcpa ViC7xjthyogE/0mZxSwnlVezFBAD86Sg/Eb8SD0r/H3gyxW6/QhZiBXCYbpq2LSLNNMg 83Cp6W0oEoCN2Qo+kw87MTpTnUfyoIt+SqDomA+p5EwhjosuW9J0iZM9SZ3uP6pDaFyt kfUUMmjVZgli8h9mwhYMuzcZeVbEAaJtnpaD4MuRTKfDdAMDuhXQQEEzFNFNS4TnRVoK a6Y+FvVIPhkALBYSALW/pwfbw4NV5TtSIgzxVeWPhWtICWjMjMW4A0RZefuEUBzKZ3Kj EKJw== X-Gm-Message-State: AAQBX9cl1D9g09O2aI3vluCfEPftqUPMaYdJqHoxSiJSw4ILvQMQ1ynP 7RN5TF+RcWptiBWV4EBi/QRp/jMRiaCQvEjHDlhbdpwV3aALEsR/uKg= X-Received: by 2002:ac8:4e44:0:b0:3d6:5f1b:1e7c with SMTP id e4-20020ac84e44000000b003d65f1b1e7cmr1093287qtw.9.1681340812792; Wed, 12 Apr 2023 16:06:52 -0700 (PDT) MIME-Version: 1.0 References: <20230407233254.957013-1-seanjc@google.com> In-Reply-To: <20230407233254.957013-1-seanjc@google.com> From: Aaron Lewis Date: Wed, 12 Apr 2023 23:06:41 +0000 Message-ID: Subject: Re: [PATCH v4 0/6] KVM: selftests: Add "instructions required" testcase To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 7, 2023 at 11:33=E2=80=AFPM Sean Christopherson wrote: > > This is the selftests portion of Aaron's series[*] to fix incorrect > "instructions required" counting. The big change from v3 is to use a nit: here and in the subject, s/required/retired/. > common struct to copy counter values to/from the guest instead of smushin= g > the values into a single 64-bit value. > > [*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40googl= e.com > > Aaron Lewis (4): > KVM: selftests: Add a common helper for the PMU event filter guest > code > KVM: selftests: Add helpers for PMC asserts in PMU event filter test > KVM: selftests: Print detailed info in PMU event filter asserts > KVM: selftests: Test the PMU event "Instructions retired" > > Sean Christopherson (2): > KVM: selftests: Use error codes to signal errors in PMU event filter > test > KVM: selftests: Copy full counter values from guest in PMU event > filter test > > .../kvm/x86_64/pmu_event_filter_test.c | 252 ++++++++++-------- > 1 file changed, 140 insertions(+), 112 deletions(-) > > > base-commit: b821bf96cf3bed0c1c8d34659299a3a1dc47218d > -- > 2.40.0.577.gac1e443424-goog > Fingers crossed that marking this as "plain text" works this time. Reviewed by: Aaron Lewis