Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d01e3e47-9514-f84f-2497-30dcfda6c825@intel.com>
Date:   Wed, 12 Apr 2023 16:10:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [net-next Patch v7 4/6] octeontx2-pf: Refactor schedular queue
 alloc/free calls
Content-Language: en-US
To:     Hariprasad Kelam <hkelam@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <kuba@kernel.org>, <davem@davemloft.net>,
        <willemdebruijn.kernel@gmail.com>, <andrew@lunn.ch>,
        <sgoutham@marvell.com>, <lcherian@marvell.com>,
        <gakula@marvell.com>, <jerinj@marvell.com>, <sbhatta@marvell.com>,
        <naveenm@marvell.com>, <edumazet@google.com>, <pabeni@redhat.com>,
        <jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
        <maxtram95@gmail.com>, <corbet@lwn.net>
References: <20230410072910.5632-1-hkelam@marvell.com>
 <20230410072910.5632-5-hkelam@marvell.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230410072910.5632-5-hkelam@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXhNbHBTVTVxdkVFQVBvY2hRV3NZak5zVENCQmxVTEdXRWx5NjRsd29WMnF6?=
 =?utf-8?B?cUVHYnBaY3I2NnMwNUw3U3hpMW00OHZTeEdiWnZSQ0xkVjB6MmwvZFpRRnBn?=
 =?utf-8?B?WW9mdTlJa0xBRTNpNzRkZW9KZEJqVWxpWDYrb3BFdVlqanZtSkpOZklQWnFm?=
 =?utf-8?B?MTlZVUJ3OUZqekVFR0RkSkw5NXgvY2FMaWtQUFAwdVlVYTFzT1NEeVBMekQv?=
 =?utf-8?B?MjhZNGNvcGxxYU9KZ0gwdUVqd2I5U2RWMmVvclRSZ1haVkpreEJUbmVFMFZs?=
 =?utf-8?B?ZFdmUkFWMi94dHczL3MzbE9idEVUS1czOVZCRjN1aFgvSGRDTFc3dWZCYlFj?=
 =?utf-8?B?cmVHZWZ6ZWkxUVVGQnk5eUhJSnRtRHVPMThmMzQ5Vml5clgzeUJiL2NhWndh?=
 =?utf-8?B?OFBkZHc5V1VDQTN0VkM0b2NuVWdxcmhWNXNvWHBzYThYWFd5UzBNSGI4WktQ?=
 =?utf-8?B?eEs0OXg3NlhzTXdlcDVpbUxQMDMyeDNaaFZJQUE2UzBKTzd3VXlrQWJ1Z2l1?=
 =?utf-8?B?ZUZlbHUrTnYyMU42Unp5dCtiNzFCd1JMeFg5TFRhMWorTDJHek9JZDJ5S1Fx?=
 =?utf-8?B?QitFeVh5cXNSL0ozWWkzVlBzWFp3K29yTWc5a1BQeUszVzZuc0o1bU1LdDBQ?=
 =?utf-8?B?bGo5NVNlL0pOdzhrTzZxYnBQTWkzRDdmdFhSZDFNbHJFMVRxVi9NSUNhckJv?=
 =?utf-8?B?aldTc2JiN0ZhRjBlUDRSOUF4TE5hemd2NE1jY3V1MGNQcDBienRtR0dGc1Ja?=
 =?utf-8?B?YjdMRTZKaWQyVDZoNVRTRXBxSFI4MjB6WEVodndHWkprYmhBN0xtdlJoa1RP?=
 =?utf-8?B?dC9WdkE1bFk1cWRjMVdwZCtQd3YzcHE3TFdMTmZGN2J4ZmJCTWVjaWZldHpN?=
 =?utf-8?B?UlduZUNtTy9kcEE5cVJoeHB6VlB4Qk5WYVpVR2lKVW54N1hneDNMbGlnYW1L?=
 =?utf-8?B?a0lNVGhObmsrQjhpSmdWTWZJVEhObktha0c5OTdlVVpMallJUGwvRk04VVU4?=
 =?utf-8?B?eHp3aUNsTER0cGhOb1RJcHB0OEJWSDVOeExPQUVBcmF3d1ZYU0YvQzIxT0R0?=
 =?utf-8?B?cUI2SWFsbUhBZk95ai9wTnI1SmpqNU44Q2NtMDRrMWJEWmdFTHlDS3REV2k3?=
 =?utf-8?B?R1NGWkdyUm5mbXVkZVNySlNaZWRPcUlYYStmeTFQYy9iK01CV0NTNFdKbGln?=
 =?utf-8?B?dUhJRUNGdmd4YzczR3FBR2lWWVMzQUxPd2UrVFF4T3VCS2F1ajdpRUh6L0Nh?=
 =?utf-8?B?MzV5b2cyVGhRb0NUUDVKTlNYTzBkNlVpVjNIdWpkZTNyU0NJUlZmSGpNb08x?=
 =?utf-8?B?eVBXMU5UQnhUeUxPeVZXS21wQmtxclhHbXRVaG9yRFhHaDZNK3d3LytrTFE0?=
 =?utf-8?B?N1FTSEw4aE83NmdUQlhaQVl3SWdPUEd5TGJYeUkvUk1rTTc3TS9pREJ5bTQw?=
 =?utf-8?B?bmJtM2hKWEthc3Y2dThUYS9xSGpBdnl4OU1kazcwM010TnVIU0tIcy81L2Fn?=
 =?utf-8?B?N2ZJenh3cFVaUGhoZnJ0SmtHNHd2amdiSk03eVZrRWNGcE96MVB6L1Yxc0tn?=
 =?utf-8?B?WXZka3hFTGQrOWY3LzZxbHBxYm56azU4ZUxsRUhud2dwTnZWeDFMcExpZHVQ?=
 =?utf-8?B?RHJFbXF2YThORmUrMEdyMjZBMUhpVndRa3YwT25jRGRYc2xhbGNYVzlSWEFD?=
 =?utf-8?B?YjYzYU9paktQSU9ybnI5TS9CWHFmSXg0c21nZnhKMGtDcFE2NWNXaHFvQWEx?=
 =?utf-8?B?eXNVRmFCelVqU3I5azlTUWZNaU01RnBQTEhicThNODNjWVhHZ2Jyb1dIUUt3?=
 =?utf-8?B?RVUyNkxRcERuZVZVcndBdTFra2tjYmdISEhoRmdRZVhsN3Y1cXdTSzlBbGEv?=
 =?utf-8?B?UlpYbkM5ZkQveEZsR0tRaVF2RE5kK3QzZ0p2N1RPaElyZUFoTFM0NU1pTHNE?=
 =?utf-8?B?ckdGNy81YmVPalQ1Z09tUlhoeDdXZEMyRllXNUJYRE8zRXBoRTNaN01DV1Uz?=
 =?utf-8?B?VVF3RW5UVk5mcEpwOGRCQUU5T2tINVpySmgxMDczZWUrTHh0bnZURVkwWlp0?=
 =?utf-8?B?WEovei9QMTNtbHcwMER2bkVUWlJKdGRTTmtSYm9XcUJjbGs3WmsxRWJ0a0dh?=
 =?utf-8?B?QUV6TW4vazYxZnpXUkhsRWJEb3RIQ1pnK3dWWU91ZVdtOFFiemJuV2UzMHh6?=
 =?utf-8?B?bFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd7cc4c-d4ea-4554-269b-08db3bab2628
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 23:10:47.0713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bOJTxJ98NuVQs5bp8de99T7/0eT4/GJ6JoTF8zYSjI1138i1CcLIU5sj5evsw0HRxhix+6i+Pg9zSBuE+DtfVMALigLAQMasp+aEqmk+REY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7140
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/10/2023 12:29 AM, Hariprasad Kelam wrote:
> Multiple transmit scheduler queues can be configured at different
> levels to support traffic shaping and scheduling. But on txschq free
> requests, the transmit schedular config in hardware is not getting
> reset. This patch adds support to reset the stale config.
> 
> The txschq alloc response handler updates the default txschq
> array which is used to configure the transmit packet path from
> SMQ to TL2 levels. However, for new features such as QoS offload
> that requires it's own txschq queues, this handler is still
> invoked and results in undefined behavior. The code now handles
> txschq response in the mbox caller function.

This paragraph is a bit hard to parse. I assume you mean that the
behavior used to be undefined? This could use a little bit of rephrasing.

The code it self seems ok.