Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 17:45:34 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/8] Ocelot/Felix driver cleanup
Message-ID: <ZDdQrmtqa8eYiRbX@MSI.localdomain>
References: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230412124737.2243527-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VVwxrlFBs4YsiAdlVWc3/oM9f4Y9igCD+OiHqVrkdfy6A1T7J21nR2nfgvkY?=
 =?us-ascii?Q?OMgFxQuv7qZIhfHH+FTnb1Zu8oH4jEVuwKZYjDqo6sgEaNRwcAVNfzpuMywJ?=
 =?us-ascii?Q?vzlBXmgu68UH9GtarOh4YrlGNLZjPUI7bSLyHiBGaqPazJG+EwIPEriXyZlt?=
 =?us-ascii?Q?yJBQA1tIFbwb0P7hEcuVJfIxVzYuYdHSFEVaXtEgL0ZTNsBzFCyomVS4kTm4?=
 =?us-ascii?Q?JtQ4FwaMvtCT73pTBquUyN5GmEhQPrhSglJf48+duG9SVjJiNhdKG1hFUfBs?=
 =?us-ascii?Q?JgjU4pVmvbN9c9oFJcd/KfExyBmzGLu2lcBMQsNDvdubR5Kz0qPPTKM3SpdU?=
 =?us-ascii?Q?N0+cGdBItWdj0TCYeUkIW++E4PU0djTTb+OLGQk4fjXi+VuVGeONpHxcpvvG?=
 =?us-ascii?Q?QDaBYIzU4uPe1C1VzKHhrSof/PT+uzd1F1qqb49ps2zplok70T9AnayCxwsi?=
 =?us-ascii?Q?5H5B9qXv0lVwhKKQrb9AygI91MbBGhO/NbC5IJ3XeAOOtZK7Eue0RQpd5flT?=
 =?us-ascii?Q?2XkTS+hbSiZpBbtKZyeiF85hPCVctHtCew7R95NKVV7jMAtykuMU67N4N3+S?=
 =?us-ascii?Q?PCFofUWwO93RF+w/3Wi2jDhL0NzM1rTYgnraTQgr4B0hOGc2m1snJF7+53gt?=
 =?us-ascii?Q?OKezcK3onE81ry/Z/3LNy26jlo9AqpKHyh/dDBAVSFYO2yb0SRRPLUgbAQEX?=
 =?us-ascii?Q?Y0pnTBlqLQT+lvvZjwJH2Izq4u8X7Pft6dSotNyixaiP2Vo0V3n1yXShF+Go?=
 =?us-ascii?Q?cslczXZcsoqm1C6tTWp9AKlHKnppRlNSQOIsU2pRjaGDvMI2JVKMAK0A7xtH?=
 =?us-ascii?Q?9X7q2mvvSwqYAWA3B7LmXsN60p1Sz0+qPYE8eTTDGjXW4QvUdyazX1OAiNPK?=
 =?us-ascii?Q?8uTBGVJS/dyBt8KmRpnxgCMz/vZw5Wfc74iW+CQOLxBUhbBti+RmdVjcf7ko?=
 =?us-ascii?Q?wAhbPB2Wmj9FsDeVP4lDqzinyWUtF7phsBlSI+Y9ZAyFKHfQMbFViIjUN7mU?=
 =?us-ascii?Q?7JKt+jKnNfYyAV9Rk1GZkkAPjn75k++W7AnrJDgMksq5dQXqLUO/nZeQy56l?=
 =?us-ascii?Q?K7T7G9Kres7z6+7o8+fnKn9hyC5nqHuAnM6AIH1UQ1EPA9MLH8Dx2FkIxn95?=
 =?us-ascii?Q?ajZ1ZnHH6Jr8ycF3om/ptZIqBoWeogu7SHYS5xtC/aJeaGpWE5PbF7odY+7W?=
 =?us-ascii?Q?kFrfNMHxVXBxSfsUByNsnESB9WHAD3GzG5DhhCMwODi2xWJPHOpr1u39FBOd?=
 =?us-ascii?Q?sNNa3q2CDWXzYwvrBC7dKy30Qw5o2dreEQlbeZnWH6/RixNl23Dy10Cp0dT8?=
 =?us-ascii?Q?BXdbPQU5CL9/tgbncU9oSiAAfpy9EyX2GC+LCOgCa6xrFwrPt5/l9l1UUDHH?=
 =?us-ascii?Q?S0NX/JQXQPJIyzotwCg/R2QyAhGAzJoSaYKKWPMr3l26WIEWp6vcOnkstrd7?=
 =?us-ascii?Q?CJxHeqJqobBs2sEjBlf9O7qWn0d4/Unsom5v0aTKxAcaBPHZe3RI3KvHEp4z?=
 =?us-ascii?Q?6+ApG7Zt1v3y+B11lde4xz/9lqgqAwALBzLdguUDUxMRcU/UJ6biEPTxmiqP?=
 =?us-ascii?Q?FH00+vgFrbOCOpg+SN4JmgGYlRIyNptkOIO0FX3oehoHRs9Ta4YIAKHSVH0R?=
 =?us-ascii?Q?aQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 288706b9-389b-4e58-893d-08db3bb864ed
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 00:45:36.1151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JVU7HZNhs7+s/NgMJwzoLxAk5Kb9GUMuZCjPYoqkEKxpleRqWAyqNk7GMWgEfPe3kPD5xUz59F5ZNW4wMfTMoqgy8ZWio66ZJdd8gvXv7WA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4217
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

On Wed, Apr 12, 2023 at 03:47:29PM +0300, Vladimir Oltean wrote:
> The cleanup mostly handles the statistics code path - some issues
> regarding understandability became apparent after the series
> "Fix trainwreck with Ocelot switch statistics counters":
> https://lore.kernel.org/netdev/20230321010325.897817-1-vladimir.oltean@nxp.com/
> 
> There is also one patch which cleans up a misleading comment
> in the DSA felix_setup().

Sorry I won't have access to hardware until next week, so I can't add
any tested-bys. But this whole set is straightforward, it probably
isn't too necessary. Let me know if there's anything you want from me on
this set.


Colin