Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 01:31:42 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc:     Wei Liu <wei.liu@kernel.org>, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org,
        Michael Kelley <mikelley@microsoft.com>, decui@microsoft.com
Subject: Re: [PATCH] hv/hv_kvp_daemon: Add support for keyfile config based
 connection profile in NM
Message-ID: <ZDdbfiMD8iq2OH9s@liuwe-devbox-debian-v2>
References: <1677133334-6958-1-git-send-email-shradhagupta@linux.microsoft.com>
 <ZAYJhm9fVAgCtTiC@liuwe-devbox-debian-v2>
 <20230307052408.GA11548@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230307052408.GA11548@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Precedence: bulk

Hi Shradha

On Mon, Mar 06, 2023 at 09:24:08PM -0800, Shradha Gupta wrote:
> On Mon, Mar 06, 2023 at 03:40:54PM +0000, Wei Liu wrote:
> > On Wed, Feb 22, 2023 at 10:22:14PM -0800, Shradha Gupta wrote:
> > > As communicated in BZ <2122115>, ifcfg config file support in
> > 
> > What is BZ <2122115>? I guess that's Red Hat's bugzilla?
> > 
> > I don't think this is useful information for the commit message, since
> > the community cannot access that ticket.
> Thanks for the pointer, will change this
> > 
> > > NetworkManger is deprecated. This patch provides support for the
> > > new keyfile config format for connection profiles in NetworkManager.
> > > The patch modifies the hv_kvp_daemon code to generate the new network
> > > configuration in keyfile format(.ini-style format) instead of ifcfg
> > > format.
> > 
> > Okay, so the wire protocol for the KVP daemon is not changed. It is just
> > the intermediate file format that's changed.
> > 
> That is correct.
> > > This configuration is stored in a temp file which is further translated
> > > using the hv_set_ifconfig.sh script. This script is implemented by
> > > individual distros based on the network management commands supported.
> > > For example, RHEL's implementation could be found here:
> > > https://gitlab.com/redhat/centos-stream/src/hyperv-daemons/-/blob/c9s/hv_set_ifconfig.sh
> > > Debian's implementation could be found here:
> > > https://github.com/endlessm/linux/blob/master/debian/cloud-tools/hv_set_ifconfig
> > > 
> > > The next part of this support is to inform the Distro vendors to
> > > modify these implementations to consume the new configuration format.
> > > 
> > 
> > I guess they will figure out the format has changed when they upgrade to
> > a new kernel?
> Yeah, so whenever they decide to use the latest kernel, they would have to change
> their implementation to consume these changes.

Can you resend with my comments addressed and ask member of the best
guest team to give an ack or review?

It does look sensible, but I guess I'm not in a good enough position to
determine the guest side tools changes.

Thanks,
Wei.


> > 
> > Thanks,
> > Wei.