Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a01a789c-8965-d1dc-cb45-ea9901a9af34@huawei.com>
Date:   Thu, 13 Apr 2023 09:34:54 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] fs: fix sysctls.c built
Content-Language: en-US
To:     Christian Brauner <brauner@kernel.org>
CC:     Luis Chamberlain <mcgrof@kernel.org>,
        <linux-fsdevel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>
References: <20230331084502.155284-1-wangkefeng.wang@huawei.com>
 <66c0e8b6-64d1-5be6-cd4d-9700d84e1b84@huawei.com>
 <20230412-sympathie-haltbar-da2d2183067b@brauner>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20230412-sympathie-haltbar-da2d2183067b@brauner>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/12 17:19, Christian Brauner wrote:
> On Tue, Apr 11, 2023 at 12:14:44PM +0800, Kefeng Wang wrote:
>> /proc/sys/fs/overflowuid and overflowgid  will be lost without
>> building this file, kindly ping, any comments, thanks.
>>
>>
>> On 2023/3/31 16:45, Kefeng Wang wrote:
>>> 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=",
>>> or it won't be built as it is overwrited.

...

> Given the description in
> ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
> you probably want to move this earlier.

Oh, missing that part, but the /proc/sys/fs/overflowuid and overflowgid 
are lost after it, is it expected? Luis, could you take a look? thanks.

>