Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 09:54:26 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Catalin Marinas <catalin.marinas@arm.com>
CC:     kernel test robot <lkp@intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>
Subject: Re: drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified
 bound 6 equals destination size
Message-ID: <ZDdg0hfJQeQh/2SZ@yujie-X299>
References: <202304071552.CeeIBr5P-lkp@intel.com>
 <ZDVA8ykiKaXSzJdM@arm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZDVA8ykiKaXSzJdM@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WbPtfiL8l2klLncz/pXPi6k+OnSMA9qRen6OO3yfZTb/bJvFg9wvxpTJiela?=
 =?us-ascii?Q?esUlBOnoS9ZtjY2dO4OnGlNtkRKf6XOTxbHPWHxNXCmcKL1E5ZfOfP02i3wH?=
 =?us-ascii?Q?ngYhyPMzojE/sQJiXYJg5tFJYV7khROoRh269gCv8747D2wczCWiJj2GWihQ?=
 =?us-ascii?Q?n0glyprLN43TtAdH3ZNqz6ZgZzI/nZSRTEvoBkZw5uoPTJqhzoe8byvm595a?=
 =?us-ascii?Q?jhe3AXoOL9OOPBcVqHPFt9vboqATVkETzO60hMuZD5Rtjlcd/q1g4d/nWFe0?=
 =?us-ascii?Q?3NUkPwSct6Nlpzs8oDfFAGCxRknRHMOVETTNTPYAP17taetS7nrBITkqF5D2?=
 =?us-ascii?Q?QYbOBv+gm2YJEhWdZ/jyQnTlRuSG9ZWT3Z0ObVdYI5E0aZUVrNt07gxcAR0t?=
 =?us-ascii?Q?juWuGX4ZoyJNkUMmKy6jGoekGxCirQmhpzdDI5l8xYJvs7A3iosCWx+JH2IH?=
 =?us-ascii?Q?/UpstlO8YPL0NdjWwo4DKxeNyYL+1TbywUjbizUcMGjYKsGsi6RH79b7M6LL?=
 =?us-ascii?Q?ziZO5n2fk3Bgr08ZLFrZGDAxsJBksGhqbtPWzevGNdUsFMig3MZSq6nqh0Fd?=
 =?us-ascii?Q?6eBE0ZUdOnu0efChsiW1JwFpYqlBNC0j6UC9LfXHeaFUVNNpE+vuEkZpNlpU?=
 =?us-ascii?Q?9cS5jZxer0G0kpi4jsObM8/+ss6oSLdyiQUPIibNRW6KSmA89Q69teOjfI6x?=
 =?us-ascii?Q?e4xm/5BxSC90kQ2uR8izwrw97XSMGsRmmk/Tqjp10ZhJUuSZBFOIIsEy/QZx?=
 =?us-ascii?Q?Z39tvbIBAfwxE42GM7rSVVzBNaejKo/6TKyZJkzjPao4fJXKw+f/YteSSinT?=
 =?us-ascii?Q?RRJ2SwSmq+zoTFaYrw7f30iLe6PvtQ8sqcs0tgiXp1I8XjcqlqeR+fM4LnHY?=
 =?us-ascii?Q?bkzJ4INsxf0ZFi8hwEr/UMnJWs14kxyeHjgo0eKtxAuLfnj83SZZ0/7iZ308?=
 =?us-ascii?Q?coIPKvcjHdExz76jOEs1ABNsK/QGZl5dQ7v06+lbmte/mZCIWAogJNtbx18m?=
 =?us-ascii?Q?adUl/5AVh+PkFBh7EJZ/L9R754oyHfjMcHHBKGwfblQI+2KQDbPvy8kyqfml?=
 =?us-ascii?Q?MfBCfQlci/7sFjqkceZGqtkhxlRxo/O4uAZP+shyWs+xWKipPGMyhJscQlsx?=
 =?us-ascii?Q?drGOZD2U8vNeXuND58Hz17WAobfPNqe6vPtoLPRREXAY9VvDLQ9iH+Kby3DI?=
 =?us-ascii?Q?LT4Uze67EzRuHd1l8ub9vHEsFrY2//jFcPYoVWfoiRPWnVxBbMJyb9Ky7Zzn?=
 =?us-ascii?Q?hNwhkD6NJN3Gg7gJ3M0rtVRjcRxEU1Zk8TQCTJ1dFRc1f0MpehR2DPgF/6uh?=
 =?us-ascii?Q?d6vBtnRaTVAWZ/IHhBlAlBn3z8muPir7XU8n9teCbo7ljXUMwVUata6rYx0O?=
 =?us-ascii?Q?MLRTewL9Eorpc8xzcZSIcMKKR1vSO93lytxDMjJevpRPGJBeBtDk/od//yFr?=
 =?us-ascii?Q?qxiO4oLsF4qSsW6XlIbr2RFYcYeSGO4N/wgrBZZzuON5Ek4ko96a1qX24qkr?=
 =?us-ascii?Q?YpntiGaYhp20Spq0o2AZBqvDw4EhcJCd/a/PgT/H9YH/Z7O6x56TANS36gvA?=
 =?us-ascii?Q?hXH+UCZdcl6Q5Qkuh7YcsK6akyWonnMbntgN+l7l?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e57d00f5-2b70-4fc7-77b6-08db3bc273ec
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 01:57:35.9649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IVEwKab5BwHrGJxza0atTcHhZF7OdcYVSg1glIQFYRlrWWfnlhYVUbimlUwZZd+NGrVHY5Skys5uj9+0nbHSIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6523
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 11, 2023 at 12:13:55PM +0100, Catalin Marinas wrote:
> On Fri, Apr 07, 2023 at 03:02:15PM +0800, kernel test robot wrote:
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   f2afccfefe7be1f7346564fe619277110d341f9b
> > commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
> > date:   2 months ago
> > config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230407/202304071552.CeeIBr5P-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > reproduce (this is a W=1 build):
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         make W=1 O=build_dir ARCH=x86_64 olddefconfig
> >         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202304071552.CeeIBr5P-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
> > >> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
> >       60 |         strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
> >          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
> >       61 |         strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
> >          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    cc1: all warnings being treated as errors
> 
> I think the kernel test robot should filter out any reports related to
> this commit. The warning has nothing to do with the -O2 vs -Os change.
> It's simply that the compiler now warns if strncpy() has the destination
> size equal to the bound parameter (for some reason it doesn't do this
> with -Os). I mentioned it on a different report here:
> 
> https://lore.kernel.org/all/Y%2FdM77YdzDKRDdj1@arm.com/
> 
> A potential solution to silence the compiler is to go through the ACPI
> code and change those strncpy() instances to memcpy(). I don't think
> those strings are even null-terminated in the APCI spec, so using
> strncpy() doesn't make sense.

Sorry for making this noise. We've configured the robot to filter out
the reports related to this commit.

--
Best Regards,
Yujie