Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230413024125.3082418-1-zenghao@kylinos.cn>
In-Reply-To: <20230413024125.3082418-1-zenghao@kylinos.cn>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 12 Apr 2023 20:03:58 -0700
Message-ID: <CAP-5=fV9TVxHx1xveQgUbZnyrDNUmkW=c3OX+DEErfZb_3G_ow@mail.gmail.com>
Subject: Re: [PATCH] perf pmu: Fix resource leaks in pmu_cpumask()
To:     Hao Zeng <zenghao@kylinos.cn>
Cc:     linux-perf-users@vger.kernel.org, peterz@infradead.org,
        mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, adrian.hunter@intel.com, james.clark@arm.com,
        suzuki.poulose@arm.com, ravi.bangoria@amd.com, seanjc@google.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 7:41=E2=80=AFPM Hao Zeng <zenghao@kylinos.cn> wrote=
:
>
> The perf_pmu__open_file() and perf_cpu_map__read()
> are called to process the file,but the file is not closed,
> which may cause a file handle leak.
>
> Signed-off-by: Hao Zeng <zenghao@kylinos.cn>

Thanks, this was already fixed by Namhyung in:
https://lore.kernel.org/all/20230331202949.810326-9-namhyung@kernel.org/
You may want to check for issues like this in Arnaldo's perf-tools-next tre=
e:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=3Dper=
f-tools-next
These are the changes planned for Linux 6.4.

Thanks,
Ian

> ---
>  tools/perf/util/pmu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index c256b29defad..3b4d2f531d83 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -583,6 +583,7 @@ static struct perf_cpu_map *pmu_cpumask(const char *n=
ame)
>                 if (!file)
>                         continue;
>                 cpus =3D perf_cpu_map__read(file);
> +               fclose(file);
>                 if (cpus)
>                         return cpus;
>         }
> --
> 2.37.2
>
>
> No virus found
>                 Checked by Hillstone Network AntiVirus