Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1876611rwl; Wed, 12 Apr 2023 21:08:56 -0700 (PDT) X-Google-Smtp-Source: AKy350ZsfbDK2GTAuZ4S+OyByIiKziAM2Wk0E1AERQ1C7zlgyrD2IZQiw2s5uRz4c1t/2/rX38k1 X-Received: by 2002:a50:fc05:0:b0:4fb:5089:6e01 with SMTP id i5-20020a50fc05000000b004fb50896e01mr1253722edr.6.1681358935886; Wed, 12 Apr 2023 21:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681358935; cv=none; d=google.com; s=arc-20160816; b=VEEqkWAjm/py1slEPkBDckuM1uptLdHukcmoCOCsxYO5WPyleEgLVEKeYHr1SjK15+ aD2qzLin+NjK19sIDkRbYMKIXBlX7jhLJ9pB1vJVYR+ZCchyH9VvVV9wfAJcizDGO19l YL9KBj320er4ssS1giFGAjDohmOvFZjwrv1e2ZyXQXygTaJLTZRHXeq5C8NfS7HBzcXY X1AGiKJxe6lKxftEPqUfQxjHlqg9tOwikwLJMBTQRcdWRuDkkT60ZfPaJxhYaoRCg2Xm rl6EBIy76quCsBr3WKIu6ollJQRnm387gqhN2KBX9njUKCAKQZhduDQ3ZMXw2Ky0T38b zItQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gtm8RkT0yxwe71dbqxBAk2+ojNT/TWjrefqo1SdVU6I=; b=hNvWQYDmO4q8dLh02rWbzb4Yiu4CSCWmbzSa55gf6QqVDZxQudLgrEgxjnSJzrtJZ4 fuxDiUcFtK4UhddQhaLHYrEAQr6ADBuxJspjKrE6p68rtLzbS4xhpr5Yc7CB7iPkWpRF Wj69aos2Nn7J/84Pdnd8LsREzJ/7MHJ3+wJ6XXx6/rbkV3bdAvqfPGR2R19rjfYEJDrV dgWX1GyACWcGOK/yO/VqeV3m4Ja6W3WDA6mqh4lXQeECsDv7VWwwq142kW5e72etH/ji Vt/FwaVSyQZy460Z48nxnYDndY55Bpk8Yjznq/zpOXHeW4LMccWQdmq4mv/FzLbSgP7t bWOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aLApzQdi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020aa7d886000000b00504784766fdsi777501edq.373.2023.04.12.21.08.29; Wed, 12 Apr 2023 21:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aLApzQdi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbjDMEHr (ORCPT + 99 others); Thu, 13 Apr 2023 00:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbjDMEG6 (ORCPT ); Thu, 13 Apr 2023 00:06:58 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F15A576AE for ; Wed, 12 Apr 2023 21:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681358817; x=1712894817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KLcSzST6hDd+fcr/F74YMXpjYh9sQavSmsQ3e9U8YPk=; b=aLApzQdiJi4uay8uEI4J9WflgjO17BjCpwY7RlyRMJtCwKY7r2lZe2vO 0UUJaIEeBHtEz//fW2HaBuhlCw2Tbp7j2CYRXQo8M/fInszr/Z7QANSJN YOgLs5IoNyC3DtabVdfpCyarMs9vFbk9lwLMhk4zIi6vnmQKHY4zCtTch Hl95ZA847SXtPZuow80x6ZjQ4e4mlVfYkOhXVDbd9bMEhM2AWPyGeaRaB rhw2TMqziY9PPwKoho1QEIMt1N/kZs1FtUbcbB1JNyYR7I5BcuhPVanGj xYZIAwNj1kn8IHLdRv3AV1IEYs15+6SoOLaBAMRGc3HOUBG+BWZwn9NQW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="332786576" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="332786576" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 21:06:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="935361017" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="935361017" Received: from allen-box.sh.intel.com ([10.239.159.127]) by fmsmga006.fm.intel.com with ESMTP; 12 Apr 2023 21:06:54 -0700 From: Lu Baolu To: Joerg Roedel Cc: Tina Zhang , Jacob Pan , Christophe JAILLET , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/17] iommu/vt-d: Do not use GFP_ATOMIC when not needed Date: Thu, 13 Apr 2023 12:06:35 +0800 Message-Id: <20230413040645.46157-8-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413040645.46157-1-baolu.lu@linux.intel.com> References: <20230413040645.46157-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET There is no need to use GFP_ATOMIC here. GFP_KERNEL is already used for some other memory allocations just a few lines above. Commit e3a981d61d15 ("iommu/vt-d: Convert allocations to GFP_KERNEL") has changed the other memory allocation flags. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/e2a8a1019ffc8a86b4b4ed93def3623f60581274.1675542576.git.christophe.jaillet@wanadoo.fr Signed-off-by: Lu Baolu --- drivers/iommu/intel/irq_remapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/irq_remapping.c b/drivers/iommu/intel/irq_remapping.c index df9e261af0b5..a1b987335b31 100644 --- a/drivers/iommu/intel/irq_remapping.c +++ b/drivers/iommu/intel/irq_remapping.c @@ -548,7 +548,7 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu) goto out_free_table; } - bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_ATOMIC); + bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_KERNEL); if (bitmap == NULL) { pr_err("IR%d: failed to allocate bitmap\n", iommu->seq_id); goto out_free_pages; -- 2.34.1