Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <Y_Ashley@163.com>, <arnd@arndb.de>, <gregkh@linuxfoundation.org>
CC:     <dzm91@hust.edu.cn>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] misc: mchp_pci1xxxx: mchp_pci1xxxx_gp: add unwind goto
Thread-Topic: [PATCH] misc: mchp_pci1xxxx: mchp_pci1xxxx_gp: add unwind goto
Thread-Index: AQHZauGuhYFnOhukmEeia3xqTdT61q8orhlw
Date:   Thu, 13 Apr 2023 04:43:10 +0000
Message-ID: <BN8PR11MB3668BB25DB6028404F423086E9989@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20230409124816.36137-1-Y_Ashley@163.com>
In-Reply-To: <20230409124816.36137-1-Y_Ashley@163.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?weOWT/zLQov1NH+dvgeAK84WKuIfAgBIZ0Hx9s7L2daAEHbJ/mCTmDmPFMuY?=
 =?us-ascii?Q?k/fBzFEK5S6R6CmQeKzYUHEwkvedKWInTwlxkVYqbw7K/lfaLhcEKKm80jgV?=
 =?us-ascii?Q?96PSG6c9jiAY9fsmEGr/W75SghdGCHu3g1CNeQpUN24eEnQKhI/5gQgNWrLN?=
 =?us-ascii?Q?4W3bCJijrUZAMWeWUMwcSzt6sIFNc6VYya992TkUJaL9VINO9V1P+0aIGhhy?=
 =?us-ascii?Q?Gxxx0bd275gnunHDJnkVJFxYcSHJwpBrRDDGhiOW6y8/ClGgX/fQSv62dzHs?=
 =?us-ascii?Q?cT57kwGtMPv8aWA9oLbWkVjcmNgIRU72N0Mm1DJlNqKV0M/YbDzSV9vhMp0J?=
 =?us-ascii?Q?G6xNqlBd+L1Di08d3+aSbBZC3XqDKveg3O8Y/a2xjKCQtl8ZpDB6cwHk9Y8D?=
 =?us-ascii?Q?WyXyqR8uFOXrJWdegGq3nKgNDUWM1KVw6fXsUbU+NAHmwSPP5Zp70Ka2z3YL?=
 =?us-ascii?Q?dwB68UQ2zBT4x2oWdL1gQMeEidHd4qUHyD0wEWtUCTdPWsY9RSW8na734dEC?=
 =?us-ascii?Q?eItZHa/SW/oNVgWCtXT6aJ3hqQbE0hB9A8Ajf6zlyxEt5oUz3LlNin+HmjTm?=
 =?us-ascii?Q?nGsoTvpXZD0AsHCyx0MS+WIeSK/G3v/FL9RfKhXlWqkWl/5RL648tVjeV/2o?=
 =?us-ascii?Q?qlJ5MOD7zPPwcSQgHAt6eYMzg9ImrxHbJXoLK3GgApg2EJ2GZgs1moxtIoTj?=
 =?us-ascii?Q?bQ+3comZ4dtiN5/6YDbVqFVcr9hcsxR4W4UEOyC8rcUGN2todS8xAXqFfcjc?=
 =?us-ascii?Q?//2nn0XmA+jRzqFxU93EGvRg6dHHORXUI1t59GzA0hBNh01aNqRnNMewdIqm?=
 =?us-ascii?Q?U7W6KIQ5qQsd1fp2yuyADSUGD42PLEw98MtUpzHGAS6Re23jP2eNo8MpK3Gx?=
 =?us-ascii?Q?qqykoRXIbtiZ+eYG3UEJm4EGA5lqVOBkqTk47TcXoka3DjhVh2DcS8jjnNK9?=
 =?us-ascii?Q?q662NXnwT/ZN70OQKomrSJRdp8zi7+hT566PnPN4AHbcqcNwYd+pbz/gHfQ2?=
 =?us-ascii?Q?8jJjm1kPSQbTjSfe/294FzkGdA+x7mw6xL5+IKJ8h50dh+mMAbIs+3laDx2j?=
 =?us-ascii?Q?IN4jolTroxb1I9rPi2kgEshkvvVo+ARSj/ERrXb9wT3c3j1hK2HMtXvvWiww?=
 =?us-ascii?Q?XvK3CMcsxyUXUpvQjQ0dBrh37JdJGHokcjUHTf8rrseYrFxSUbTSQfNiMe+B?=
 =?us-ascii?Q?RuIH3merqOue1TpRAr6TbHIrPpxo/g1JT9oqmTsMmk96AbzPPYPSFXHu0Y3w?=
 =?us-ascii?Q?PliQIjqMvTTfAhCkPKY46a1pP+b/trJPTwWDhGOQP/TQSieIe02egGovkVmx?=
 =?us-ascii?Q?08e8qsAxvczUdyXWb+O04P39B6+gAmNKDcq8CUk/XOVUpYdiBck7Kg8fAWYF?=
 =?us-ascii?Q?7C+9g1+KQEx13w0Lh69tdHRnepaeyzmvJbx4PiIitVHtC+wqaULacTkwOsA/?=
 =?us-ascii?Q?i+OWVH3Br0BfEip7o38Zewr0YJGMLF8Cyu/YChD0PGLHxLJjUoiMSehRkCzl?=
 =?us-ascii?Q?pTGTp96AcgfOmPo9uUq7HK1bdzPvQrQchjdCSB/OnYqrh6TPaXg8yPIfxQR7?=
 =?us-ascii?Q?v/6wCgHlg0RNNhO8x96jHlKf4UJemGFTP2nWIBBGPwfbd560tok+exTE6v66?=
 =?us-ascii?Q?yMz4vMRVQ3b6e6h4wikcd2k=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04a16417-5cca-4a5f-70e9-08db3bd99551
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2023 04:43:10.1722
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: urDFFDX7k3mGOeY/uNVVO4UpupHlal8LOsrhHFCuTFCSsoUiIVcFMIXiEqZxMWkcLX55qsGbJwXdvsywYEC7oK50VCyE721dnuiq1GK9FHgYPfSMHqdqSHy57OAqwIId
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5697
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Xinyi Hou <Y_Ashley@163.com>
> Sent: Sunday, April 9, 2023 6:18 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Arnd Bergmann
> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>=20
> Smatch reported:
>=20
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:73 gp_aux_bus_probe()
> warn:
> missing unwind goto?
>=20
> In gp_aux_bus_probe(), when the allocation of aux_bus-
> >aux_device_wrapper[1] fails, it needs to clean up the allocated resource=
s.
>=20
> Fix this by revising the return statement to a goto statement.
>=20
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus drive=
r for
> the PIO function in the multi-function endpoint of pci1xxxx device.")
> Signed-off-by: Xinyi Hou <Y_Ashley@163.com>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> The issue is found by static analysis, and the patch remains untest.
> ---
>=20
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> index 32af2b14ff34..2c64b6b3cd9c 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> @@ -69,8 +69,10 @@ static int gp_aux_bus_probe(struct pci_dev *pdev,
> const struct pci_device_id *id
>=20
>         aux_bus->aux_device_wrapper[1] =3D kzalloc(sizeof(*aux_bus-
> >aux_device_wrapper[1]),
>                                                  GFP_KERNEL);
> -       if (!aux_bus->aux_device_wrapper[1])
> -               return -ENOMEM;
> +       if (!aux_bus->aux_device_wrapper[1]) {
> +               retval =3D -ENOMEM;
> +               goto err_aux_dev_add_0;
> +       }
>=20
>         retval =3D ida_alloc(&gp_client_ida, GFP_KERNEL);
>         if (retval < 0)
> --
> 2.25.1