Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1928235rwl; Wed, 12 Apr 2023 22:12:53 -0700 (PDT) X-Google-Smtp-Source: AKy350bPLDu5aLXzIX1hYkQQn4zCXhTgEp/+QXtmKS1Ss5X7nc92C2sQ+8IfnD5U9V/+4R3RT8sn X-Received: by 2002:a05:6a20:45e:b0:ec:26bf:50e4 with SMTP id b30-20020a056a20045e00b000ec26bf50e4mr876131pzb.8.1681362773316; Wed, 12 Apr 2023 22:12:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681362773; cv=none; d=google.com; s=arc-20160816; b=tL/IGApP4g5L+C3OSgGTYRUsWHNS8D3hqPpLa+YgIkFC+jposIblGA6F2VGvjyTsjp +CuHKZ72sLBhFQZKubTKV/L3iF4Cj8RQc9aHenhtfXkmGzd/hRoJsTdyYahGJEVGuvsK X/bvT1sa6X1yHlgnitEOBnQ4gYUH6pHDtiCzODuV3qH7RcwHH07oo1TgukO1YtlrO8Xg NmSn+UBW5+L454Zl4+q1GHxAcc2Lcrip3aeovCKEGRyWH4yOfCbS3sdqkv+W13ydtQEe tfwUYC+rua9HUkoaI/zVlK0zO97GnaIo03uBi8alLXFQz8GOJksmq2xtyzosFp6L7TGG gNqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=jEpKLz+OYswEj/j/OWHKJyMyfHb410Gtkfr4ce53yxW2n78xILwSht2ktCWI+E2tPM FQl06298j4N01B664DE7o20eb0HdyppPCNPtGwTmOe06gj5ZCMHTb03PFQwNQ/zuKvip 23PnnJoeqljRM25ooJKUpWIooNxh5ITFF369t2mFgkTwqDzBKtXOLnHAhuKg0HCr7ZW+ o3VTcv7csC+2hXJYn0NKh4q6+bWmh9Jp7v0CyQTTSwPCqjhFneiYy6a6q4LW7XBKihr8 IbHa5w7BxO5azp4bTWxqO+qipKTa/hSZGANXGMwIG5DsL6W8g0ZcPDitPkdtEKwNdk+Q qKrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a63540a000000b0051323af954asi1060869pgb.644.2023.04.12.22.12.41; Wed, 12 Apr 2023 22:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjDMFAO (ORCPT + 99 others); Thu, 13 Apr 2023 01:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjDMFAN (ORCPT ); Thu, 13 Apr 2023 01:00:13 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 575DA5BA2; Wed, 12 Apr 2023 22:00:12 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C03486732D; Thu, 13 Apr 2023 07:00:09 +0200 (CEST) Date: Thu, 13 Apr 2023 07:00:09 +0200 From: Christoph Hellwig To: Tejun Heo Cc: axboe@kernel.dk, josef@toxicpanda.com, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com Subject: Re: [PATCH 2/4] blkcg: Restructure blkg_conf_prep() and friends Message-ID: <20230413050009.GB14083@lst.de> References: <20230413000649.115785-1-tj@kernel.org> <20230413000649.115785-3-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413000649.115785-3-tj@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig