Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230411230650.1760757-1-pranavpp@google.com>
In-Reply-To: <20230411230650.1760757-1-pranavpp@google.com>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Thu, 13 Apr 2023 09:11:58 +0200
Message-ID: <CAMGffEmrHRJjRLiMAsq0K43JcN571Es9xg=wtr=CO-j1ts_SRA@mail.gmail.com>
Subject: Re: [PATCH] scsi: pm80xx: Log device registration
To:     Pranav Prasad <pranavpp@google.com>
Cc:     Jack Wang <jinpu.wang@cloud.ionos.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Akshat Jain <akshatzen@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 12, 2023 at 1:09=E2=80=AFAM Pranav Prasad <pranavpp@google.com>=
 wrote:
>
> From: Akshat Jain <akshatzen@google.com>
>
> Log combination of phy_id and device_id in device registration
> response.
>
> Signed-off-by: Akshat Jain <akshatzen@google.com>
> Signed-off-by: Pranav Prasad <pranavpp@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm800=
1_hwi.c
> index ec1a9ab61814..73cd25f30ca5 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -3362,8 +3362,9 @@ int pm8001_mpi_reg_resp(struct pm8001_hba_info *pm8=
001_ha, void *piomb)
>         pm8001_dev =3D ccb->device;
>         status =3D le32_to_cpu(registerRespPayload->status);
>         device_id =3D le32_to_cpu(registerRespPayload->device_id);
> -       pm8001_dbg(pm8001_ha, MSG, " register device is status =3D %d\n",
> -                  status);
> +       pm8001_dbg(pm8001_ha, INIT,
> +                  "register device status %d phy_id 0x%x device_id %d\n"=
,
> +                  status, pm8001_dev->attached_phy, device_id);
>         switch (status) {
>         case DEVREG_SUCCESS:
>                 pm8001_dbg(pm8001_ha, MSG, "DEVREG_SUCCESS\n");
> @@ -4278,7 +4279,7 @@ int pm8001_chip_dereg_dev_req(struct pm8001_hba_inf=
o *pm8001_ha,
>         memset(&payload, 0, sizeof(payload));
>         payload.tag =3D cpu_to_le32(1);
>         payload.device_id =3D cpu_to_le32(device_id);
> -       pm8001_dbg(pm8001_ha, MSG, "unregister device device_id =3D %d\n"=
,
> +       pm8001_dbg(pm8001_ha, INIT, "unregister device device_id %d\n",
>                    device_id);
>
>         return pm8001_mpi_build_cmd(pm8001_ha, 0, opc, &payload,
> --
> 2.40.0.577.gac1e443424-goog
>