Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aed50785-3eaf-3e5c-d208-5e5ccbc51096@samsung.com>
Date:   Thu, 13 Apr 2023 09:44:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.9.0
Subject: Re: [PATCH v2] scripts/gdb: use mem instead of core_layout to get
 the module address
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <jan.kiszka@siemens.com>, <kbingham@kernel.org>,
        <gost.dev@samsung.com>, <linux-kernel@vger.kernel.org>,
        <song@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>
Content-Language: en-US
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <ZDdSd8iB2n6r/ccB@bombadil.infradead.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20230412203420eucas1p2efd38df12efde2ca05c6b3a26f5a753b@eucas1p2.samsung.com>
        <20230412202516.1027149-1-p.raghav@samsung.com>
        <ZDdSd8iB2n6r/ccB@bombadil.infradead.org>
Precedence: bulk

On 2023-04-13 02:53, Luis Chamberlain wrote:
> On Wed, Apr 12, 2023 at 10:25:18PM +0200, Pankaj Raghav wrote:
>> commit ac3b43283923 ("module: replace module_layout with module_memory")
>> changed the struct module data structure from module_layout to
>> module_memory. The core_layout member which is used while loading
>> modules are not available anymore leading to the following error while
>> running gdb:
>>
>> (gdb) lx-symbols
>> loading vmlinux
>> Python Exception <class 'gdb.error'>: There is no member named core_layout.
>> Error occurred in Python: There is no member named core_layout.
>>
>> Replace core_layout with its new counterpart mem[MOD_TEXT].
>>
>> Fixes: ac3b43283923 ("module: replace module_layout with module_memory")
>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>> ---
>>  scripts/gdb/linux/constants.py.in | 3 +++
>>  scripts/gdb/linux/modules.py      | 4 ++--
>>  scripts/gdb/linux/symbols.py      | 4 ++--
>>  3 files changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
>> index 36fd2b145853..471300ba176c 100644
>> --- a/scripts/gdb/linux/constants.py.in
>> +++ b/scripts/gdb/linux/constants.py.in
>> @@ -62,6 +62,9 @@ LX_GDBPARSED(hrtimer_resolution)
>>  LX_GDBPARSED(IRQD_LEVEL)
>>  LX_GDBPARSED(IRQ_HIDDEN)
>>  
>> +/* linux/module.h */
>> +LX_GDBPARSED(MOD_TEXT)
> 
> Should we just fill in the rest of the other sections too while at it?
> 

I don't see them used in the scripts. Maybe we can add them when needed?

>   Luis