Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1681372206.941719-1-xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH] tools/virtio/ringtest: Replace obsolete memalign() with posix_memalign()
Date:   Thu, 13 Apr 2023 15:50:06 +0800
From:   Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To:     Deming Wang <wangdeming@inspur.com>
Cc:     <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>,
        Deming Wang <wangdeming@inspur.com>, <mst@redhat.com>,
        <jasowang@redhat.com>
References: <20230412072536.2029-1-wangdeming@inspur.com>
In-Reply-To: <20230412072536.2029-1-wangdeming@inspur.com>
Precedence: bulk

On Wed, 12 Apr 2023 03:25:36 -0400, Deming Wang <wangdeming@inspur.com> wrote:
> memalign() is obsolete according to its manpage.
>
> Replace memalign() with posix_memalign() and remove malloc.h include
> that was there for memalign().
>
> As a pointer is passed into posix_memalign(), initialize *p to NULL
> to silence a warning about the function's return value being used as
> uninitialized (which is not valid anyway because the error is properly
> checked before p is returned).
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>

LGTM

Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>

> ---
>  tools/virtio/ringtest/ptr_ring.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/virtio/ringtest/ptr_ring.c b/tools/virtio/ringtest/ptr_ring.c
> index c9b26335f891..a0bf4978eace 100644
> --- a/tools/virtio/ringtest/ptr_ring.c
> +++ b/tools/virtio/ringtest/ptr_ring.c
> @@ -26,9 +26,12 @@ typedef int gfp_t;
>
>  static void *kmalloc(unsigned size, gfp_t gfp)
>  {
> -	void *p = memalign(64, size);
> -	if (!p)
> -		return p;
> +	void *p;
> +	int ret;
> +
> +	ret = posix_memalign(&p, 64, size);
> +	if (ret < 0)
> +		return NULL;
>
>  	if (gfp & __GFP_ZERO)
>  		memset(p, 0, size);
> --
> 2.27.0
>