Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2068056rwl; Thu, 13 Apr 2023 00:53:35 -0700 (PDT) X-Google-Smtp-Source: AKy350aiumNZFuoIxFD2+uUtx+O8rQD3NP+SFY83dj5P3fr5hRlBpXFEpFg6FqugeUWHKTVgNgvb X-Received: by 2002:aa7:da55:0:b0:504:9a5a:7c93 with SMTP id w21-20020aa7da55000000b005049a5a7c93mr1621702eds.24.1681372414775; Thu, 13 Apr 2023 00:53:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681372414; cv=none; d=google.com; s=arc-20160816; b=UwQkj5ZndB6Xw1Hikl0Ad5nGLyHCJkGHbJI89pJdwHb+gpoyM6b9azqJNG01nU/Kez oAzyBTzdoY74Q598STNVs+PUip6xsbvTgW08VHelcxBrDWAJKyXxxcLXkHJsaATpQvoC 1Kqx5HZR/7N7pZ6W5Az2166EPhs0G0FwWjusKf8+UahwvLQkcgrtbI+2qrnJZl1Gahe4 xQ0TV0wI5EY+vvLdYQx2zA9rUqG/NcmsqIk9UwMO4YknxInHnhMBp6kIE+hG+XULnAuM RxmJwKVRLgD2p3XVdeJiOezgVZWrhL0gmAJU3CInoH1kEEMW0beuenebxxwMmXzL4bxv d8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Au1HGF148lMOJhXl55fVMciphrL5/N0EfS5Fnj76E4g=; b=Ce5qYPXUhzTgKBAOVTwzOD/I455dJvGHPCHk5ZpdkFiDxZFvc3hBbk/duFytd8ui91 3sAOmsxhlSnEjRkke9S/pw9O2ddrtlv4sbtvUewkB92Lp1oJG/HgsLOKTHIzSm0JO0y5 FNG3ODigyRMQCKJGqGj4+ZRBaXuebzkd7gsHYm9xvDQIIUngh4B4Ug3Twydfg7FdRuHk UCeLLGX15/AAYMIOVKdPUj6CqgGN5JceCJBHS4xMdGWkXJ2B/VU9kEvzikSBqbMA0AJf 2MGOyc0EJARUYNic87heaZaazgnLQSZSgyDXGccLk7PN5shyDDtWvJcJZRCgu1aO+SDv +VgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=mEliRrXD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e26-20020a50fb9a000000b005048c3d97d7si1248021edq.249.2023.04.13.00.53.10; Thu, 13 Apr 2023 00:53:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=mEliRrXD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbjDMHvj (ORCPT + 99 others); Thu, 13 Apr 2023 03:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbjDMHve (ORCPT ); Thu, 13 Apr 2023 03:51:34 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F1118A4F for ; Thu, 13 Apr 2023 00:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Au1HGF148lMOJhXl55fVMciphrL5/N0EfS5Fnj76E4g=; b=mEliRrXDDk8Kw7VHKsS5hSUMl4 ldXJVGmCkr1vlznPtsLVyufPQRpdwWxbJM26bCbyLMFDA3DfDM9Vx3J6/4xa1hdXg4VdA3liP6QUJ iE+k/ZYn0JdTpTNJMmmyk0C/xKYHNJyvhhZmIZ6lwsVaZ2gf8LNalXxtYHYs5VU0FUbu+RYWkXTC5 nrKgc2Yu69XwE5JDSshFTh25FCuHs9C9VIoZryu2Dp/TjpDrdk3AuJEUlxVt85SRX/rg6bWUqBVz7 quaURGsRd8ujKm5fVJoli/YWMw7eYbdehGoUQDiJEuBPFN5M0E+SWJVfOxQKUjRKWqkYV7CUdMUJs abDFoBaA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pmrjY-00EfR9-1y; Thu, 13 Apr 2023 07:51:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F0FCE30002F; Thu, 13 Apr 2023 09:51:06 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D5214235CC4A0; Thu, 13 Apr 2023 09:51:06 +0200 (CEST) Date: Thu, 13 Apr 2023 09:51:06 +0200 From: Peter Zijlstra To: ndesaulniers@google.com Cc: "Borislav Petkov (AMD)" , Josh Poimboeuf , x86@kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , Miguel Ojeda , Nathan Chancellor , Tom Rix , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 0/2] start_kernel: omit stack canary Message-ID: <20230413075106.GE4253@hirez.programming.kicks-ass.net> References: <20230412-no_stackp-v1-0-46a69b507a4b@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412-no_stackp-v1-0-46a69b507a4b@google.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2023 at 11:32:11AM -0700, ndesaulniers@google.com wrote: > Nick Desaulniers (2): > start_kernel: add no_stack_protector fn attr > start_kernel: omit prevent_tail_call_optimization for newer toolchains > Your second patch has a vile comment style :-) Other than that, Acked-by: Peter Zijlstra (Intel)