Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 10:08:22 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@kernel.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v2 5/9] objtool: Add verbose option for disassembling
 affected functions
Message-ID: <20230413080822.GH4253@hirez.programming.kicks-ass.net>
References: <cover.1681325924.git.jpoimboe@kernel.org>
 <4cadacc719db1e792c335309056960ca6f71139e.1681325924.git.jpoimboe@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cadacc719db1e792c335309056960ca6f71139e.1681325924.git.jpoimboe@kernel.org>
Precedence: bulk

On Wed, Apr 12, 2023 at 12:03:20PM -0700, Josh Poimboeuf wrote:
> +	objdump_str = "%sobjdump -wdr %s | gawk -M -v _funcs='%s' '"
> +			"BEGIN { split(_funcs, funcs); }"
> +			"/^$/ { func_match = 0; }"
> +			"/<.*>:/ { "
> +				"f = gensub(/.*<(.*)>:/, \"\\\\1\", 1);"
> +				"for (i in funcs) {"
> +					"if (funcs[i] == f) {"
> +						"func_match = 1;"
> +						"base = strtonum(\"0x\" $1);"
> +						"break;"
> +					"}"
> +				"}"
> +			"}"
> +			"{"
> +				"if (func_match) {"
> +					"addr = strtonum(\"0x\" $1);"
> +					"printf(\"%%04x \", addr - base);"
> +					"print;"
> +				"}"
> +			"}' 1>&2";

Do we want to have scripts/objdump-func.awk and use that to avoid the
duplication and eventual divergence of these awk thingies?