Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <710ed5a2-1c3a-3fb1-c015-55ded320db30@arm.com>
Date:   Thu, 13 Apr 2023 10:34:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] net: Finish up ->msg_control{,_user} split
Content-Language: en-GB
To:     Christoph Hellwig <hch@lst.de>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
References: <20230411122625.3902339-1-kevin.brodsky@arm.com>
 <20230412152548.GA26786@lst.de>
From:   Kevin Brodsky <kevin.brodsky@arm.com>
In-Reply-To: <20230412152548.GA26786@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: 32TINHaNuzqah4vb+gRp1NQB1aOusdYf86+7gmEq3q5JHEa8Xk+3aY6fhTr8F3VubjyOlB/oVAMeyypxNbNCbVtc+oEnnFqR5jZBlYS61Sxvd8mNHceDpddVcKVHhGVJGA85cz/2Pd6QV2osTCoq8Z8GSZ6aL0nNwAXWvVp/CLS5WBRpxe165+tjecz6ktdzJSFKxr45Qf0KrrDxmLO2TVXAYjw+H84qyr5Lpp2rBxf2muquauaZ1uWsCxCmckFGAegww6pXZs6i7E1f04FYB3f2LiKljTxmzJv5gxRQRQZa1ULM0tkFiB3GzgjP+HG4fKQA+8gGIgrW5HJUD+KfPM1VtjM4D3JpKSJ0GcKcXZyCxjiLvFS/muUqeYo8Zqbv4u+BlZg1vYVoS5PTiR00WBLL9dm/JoWQmFdUxSPWY9HXxdfMSa0JciTrud1sAeLrQ53EqVSujXM6pCRrET3GPM6opUTMDXg/4tmffKjes9ZYzTY+J9vAe4lV03yOakpkjQDi7vpjM+gy5OibiJv1FS9vdAKm6DBR191Y4hLXLXZhMxRoyJX0E51FCgxV94INdhcWJaFh9RgEQ5huajfcHMJbsJ51Ve7BGLwOQyX1r7sZRrWctlsw4wqSqNz2+GwPi0pjqHH0WyVtL3a4+ZWGsQ==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6570.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(451199021)(316002)(38100700002)(6916009)(4326008)(66556008)(66946007)(66476007)(2616005)(5660300002)(41300700001)(44832011)(31686004)(36756003)(86362001)(6486002)(31696002)(54906003)(6512007)(6506007)(26005)(186003)(53546011)(2906002)(83380400001)(8676002)(8936002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10269
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 705b33a1-ed18-4126-3c68-08db3bf9f278
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PrKSuQlhM/t5EF+CXTpe7NRB0qWmjqNlSa/Xme/wlgmUkj5ObP1vmEWfzRKF6r0tLIA9lmLTnpSgwmIQMVEqskrbK+u5BflhGv3rqPM2Qn7b392yyD3KxHMnKUHZOr2mTMDbg3c2dEJE+kQY9e5D3R4O9dMpDzkejv77XEqsT6j3IqTyvtI97hPp2ocgoATJcoNqj+z51AcGfuLSr+DRgrbi1lPcM0nxY2DKNvPtjoxLSTflQuuy3hxvMz5CAEgtl6Jk/KlkJQKTsUWwv9jt3P9i9KrapEmv2xzxb3PGS7XB55G4UHLfZIcxxGPoFF3n8xx+cQ15J395xm4LKVKWuyFQwAtS6MW810F/dhSFgIc12zvDIdmVbIol+itwEE5GUgufhxSGYU/g0uP0zwCNGe+iNkSdQTb6f5LkZRMLg7Y+MtLc3I5nXnBqph7SI+ebUW6Jh176sWuvWS72Q6VD9+/m9sUgltlUv/VVs0zFpP514FESX1DTOsdnoKvdEoin1T37JlZBS0tpEvzPdSbHgU2LXGKxVoE9CI8s81R4XVKRxPzrYQx39Me9jPVka8J8oqqKL0rB02ScFtb4joahEUi/SJGxsx6wUavfkn57rRiDaimbTS1W8o/ATkOshz8+EFmAY6IpQXGQjdmgUxWGDUAEd3OS5H9i0gYbfdL+8ZNtBNp5oEt3Um2pJpUMtOQwkfBSPBjv6eESE+tPa5VUf16Ipr+9MwVWFA4XvcdxVKA=
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199021)(46966006)(40470700004)(36840700001)(2616005)(47076005)(40480700001)(53546011)(6512007)(6506007)(26005)(31686004)(186003)(336012)(40460700003)(36860700001)(8936002)(5660300002)(6862004)(8676002)(2906002)(83380400001)(450100002)(4326008)(70586007)(86362001)(54906003)(70206006)(41300700001)(316002)(31696002)(82740400003)(478600001)(356005)(44832011)(81166007)(6486002)(36756003)(82310400005)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 08:35:00.2508
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 99439678-d711-481c-84ac-08db3bf9f864
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5631
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,UNPARSEABLE_RELAY
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/04/2023 17:25, Christoph Hellwig wrote:
> On Tue, Apr 11, 2023 at 01:26:25PM +0100, Kevin Brodsky wrote:
>> This patch is attempting to complete the split. Most issues are about
>> msg_control being used when in fact a user pointer is stored in the
>> union; msg_control_user is now used instead. An exception is made
>> for null checks, as it should be safe to use msg_control
>> unconditionally for that purpose.
> So all of the fixes looks good to me.
>
>> Additionally, a special situation in
>> cmsghdr_from_user_compat_to_kern() is addressed. There the input
>> struct msghdr holds a user pointer (msg_control_user), but a kernel
>> pointer is stored in msg_control when returning. msg_control_is_user
>> is now updated accordingly.
> But this is a small isolated real bugfix.  So I'd suggest to split
> this into a simple and easily backportable patch, and do the rest
> in another.
>
>> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
>> index 2917dd8d198c..ae818ff46224 100644
>> --- a/net/ipv6/ipv6_sockglue.c
>> +++ b/net/ipv6/ipv6_sockglue.c
>> @@ -716,6 +716,7 @@ int do_ipv6_setsockopt(struct sock *sk, int level, i=
nt optname,
>>                      goto done;
>>
>>              msg.msg_controllen =3D optlen;
>> +            msg.msg_control_is_user =3D false;
> And this is another one that has a real effect.

Thank you, both good points! Will split that up into a series of three
patches.

Kevin
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.