Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a56509f598e4c65584ceb8b331b784d6ccdafda.camel@redhat.com>
Subject: Re: [net-next Patch v9 0/6] octeontx2-pf: HTB offload support
From:   Paolo Abeni <pabeni@redhat.com>
To:     Jakub Kicinski <kuba@kernel.org>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Jacob Keller <jacob.e.keller@intel.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, willemdebruijn.kernel@gmail.com,
        andrew@lunn.ch, sgoutham@marvell.com, lcherian@marvell.com,
        gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com,
        naveenm@marvell.com, edumazet@google.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com,
        corbet@lwn.net
Date:   Thu, 13 Apr 2023 10:53:20 +0200
In-Reply-To: <20230412182756.6b1d28c6@kernel.org>
References: <20230411090359.5134-1-hkelam@marvell.com>
         <20230412182756.6b1d28c6@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-04-12 at 18:27 -0700, Jakub Kicinski wrote:
> On Tue, 11 Apr 2023 14:33:53 +0530 Hariprasad Kelam wrote:
> > octeontx2 silicon and CN10K transmit interface consists of five
> > transmit levels starting from MDQ, TL4 to TL1. Once packets are
> > submitted to MDQ, hardware picks all active MDQs using strict
> > priority, and MDQs having the same priority level are chosen using
> > round robin. Each packet will traverse MDQ, TL4 to TL1 levels.
> > Each level contains an array of queues to support scheduling and
> > shaping.
>=20
>=20
> Looks like Jake's comments from v7 apply.

Just to be more verbose, the above means clarifying the commit message
for patch 4/6 and try factor into separate helpers some code of
function __otx2_qos_txschq_cfg() in patch 6/6.

Thanks,

Paolo