Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 11:14:01 +0200
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Bobby Eshleman <bobby.eshleman@bytedance.com>,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@sberdevices.ru,
        oxffffaa@gmail.com
Subject: Re: [RFC PATCH v1] vsock/loopback: don't disable irqs for queue
 access
Message-ID: <m6zafomiasxi7fdlejxqebvq5lkjwo3wvpkc7xa6tzfa7ywfy6@bswd76cx772g>
References: <b6dd26b3-97d7-ef8e-d8f8-a0e728fa2b02@sberdevices.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <b6dd26b3-97d7-ef8e-d8f8-a0e728fa2b02@sberdevices.ru>
Precedence: bulk

On Sun, Apr 09, 2023 at 10:17:51PM +0300, Arseniy Krasnov wrote:
>This replaces 'skb_queue_tail()' with 'virtio_vsock_skb_queue_tail()'.
>The first one uses 'spin_lock_irqsave()', second uses 'spin_lock_bh()'.
>There is no need to disable interrupts in the loopback transport as
>there is no access to the queue with skbs from interrupt context. Both
>virtio and vhost transports work in the same way.

Yep, this is a good point!

>
>Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>---
> net/vmw_vsock/vsock_loopback.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

LGTM! (net-next material)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

>
>diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c
>index e3afc0c866f5..5c6360df1f31 100644
>--- a/net/vmw_vsock/vsock_loopback.c
>+++ b/net/vmw_vsock/vsock_loopback.c
>@@ -31,8 +31,7 @@ static int vsock_loopback_send_pkt(struct sk_buff *skb)
> 	struct vsock_loopback *vsock = &the_vsock_loopback;
> 	int len = skb->len;
>
>-	skb_queue_tail(&vsock->pkt_queue, skb);
>-
>+	virtio_vsock_skb_queue_tail(&vsock->pkt_queue, skb);
> 	queue_work(vsock->workqueue, &vsock->pkt_work);
>
> 	return len;
>-- 
>2.25.1
>