Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 12:34:15 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [BUG] staging: rtl8192e: W_DISABLE# does not work after
 stop/start
Message-ID: <3f71b782-e52e-48cb-9a41-4097a3329ae3@kili.mountain>
References: <39dc735c-fd6d-e405-856c-788a52704d63@gmail.com>
 <248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com>
Precedence: bulk

On Fri, Apr 07, 2023 at 11:02:05PM +0200, Philipp Hortmann wrote:
> When loading the driver for rtl8192e, the W_DISABLE# switch is working as
> intended. But when the WLAN is turned off in software and then turned on
> again the W_DISABLE# does not work anymore.
> 
> Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio()
> checking this every two seconds is an conditional return.
> 
> 	if (priv->bfirst_after_down) {
> 		priv->bfirst_after_down = true; // PH: useless line
> 		return;
> 	}
> 
> 	tmp1byte = rtl92e_readb(dev, GPI); // PH: GPI for W_DISABLE#
> 
> bfirst_after_down is set true when switching the WLAN off in software. But
> it is not set to false again when WLAN is turned on again.
> 

Is there a question here?  You're like the expert on this driver and you
seem to have figured out the solution...  I'm confused.

regards,
dan carpenter