Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a311d52c-a07a-fdfe-5b48-502d05f70737@gmail.com>
Date:   Thu, 13 Apr 2023 11:37:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] soc: mediatek: mtk-svs: change the function
 IS_ERR_OR_NULL() to IS_ERR()
Content-Language: en-US
To:     =?UTF-8?B?5YiY57Sr55C0?= <ziqin_l@hust.edu.cn>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Dongliang Mu <dzm91@hust.edu.cn>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20230406024200.3126080-1-ziqin_l@hust.edu.cn>
 <1b48b0ec.3b004.1877971d059.Coremail.ziqin_l@hust.edu.cn>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <1b48b0ec.3b004.1877971d059.Coremail.ziqin_l@hust.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 13/04/2023 09:08, 刘紫琴 wrote:
> ping?
> 

Please be patient, maintainers are sometimes busy and can't cope with all the 
patches at a time.

Please don't top post :)

This was already fixed and applied to linux-next via
https://lore.kernel.org/all/20230202124104.16504-2-roger.lu@mediatek.com/

Best regards,
Matthias

> "Ziqin Liu" <ziqin_l@hust.edu.cn>写道：
>> nvmem_cell_get() will return an ERR_PTR() on error or a valid pointer to a
>> struct nvmem_cell but won't return NULL, the check function should be
>> IS_ERR() instead of IS_ERR_OR_NULL()
>>
>> Signed-off-by: Ziqin Liu <ziqin_l@hust.edu.cn>
>> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
>> ---
>>   drivers/soc/mediatek/mtk-svs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>> index a7eb019b5157..8127fb6d587b 100644
>> --- a/drivers/soc/mediatek/mtk-svs.c
>> +++ b/drivers/soc/mediatek/mtk-svs.c
>> @@ -1726,7 +1726,7 @@ static int svs_get_efuse_data(struct svs_platform *svsp,
>>   	struct nvmem_cell *cell;
>>   
>>   	cell = nvmem_cell_get(svsp->dev, nvmem_cell_name);
>> -	if (IS_ERR_OR_NULL(cell)) {
>> +	if (IS_ERR(cell)) {
>>   		dev_err(svsp->dev, "no \"%s\"? %ld\n",
>>   			nvmem_cell_name, PTR_ERR(cell));
>>   		return PTR_ERR(cell);
>> -- 
>> 2.25.1