Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 11:51:14 +0200
From:   Joerg Roedel <joro@8bytes.org>
To:     Steven Price <steven.price@arm.com>
Cc:     Heiko Stuebner <heiko@sntech.de>, Jason Gunthorpe <jgg@ziepe.ca>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org,
        John Keeping <john@metanate.com>
Subject: Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops
 callback
Message-ID: <ZDfQkmiPaNalNx2W@8bytes.org>
References: <20230331095154.2671129-1-steven.price@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230331095154.2671129-1-steven.price@arm.com>
Precedence: bulk

On Fri, Mar 31, 2023 at 10:51:54AM +0100, Steven Price wrote:
> Similar to exynos, we need a set_platform_dma_ops() callback for proper
> operation on ARM 32 bit after recent changes in the IOMMU framework
> (detach ops removal). But also the use of a NULL domain is confusing.
> 
> Rework the code to add support for IOMMU_DOMAIN_IDENTITY and a singleton
> rk_identity_domain which is assigned to domain when using an identity
> mapping rather than "detaching". This makes the code easier to reason about.
> 
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> Changes since v3[1]:
> 
>  * Added a dummy free callback to rk_identity_ops.
> 
> [1] https://lore.kernel.org/r/20230330144604.2431436-1-steven.price%40arm.com
> 
>  drivers/iommu/rockchip-iommu.c | 61 ++++++++++++++++++++++++++--------
>  1 file changed, 47 insertions(+), 14 deletions(-)

Applied, thanks.