Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 13:13:09 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     "David E. Box" <david.e.box@linux.intel.com>
cc:     hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel/pmt: Ignore uninitialized entries
In-Reply-To: <20230413012922.1521377-1-david.e.box@linux.intel.com>
Message-ID: <84f5952a-b64d-c3c8-d80-b9d59fe1ed40@linux.intel.com>
References: <20230413012922.1521377-1-david.e.box@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-53251890-1681380792=:1987"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-53251890-1681380792=:1987
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8BIT

On Wed, 12 Apr 2023, David E. Box wrote:

> On Intel Xeon, unused PMT regions will have uninitialized discovery headers
> containing all 0xF. Instead of returning an error, just skip the region.
> 
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>  drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/x86/intel/pmt/telemetry.c
> index 71cdef42084a..39cbc87cc28a 100644
> --- a/drivers/platform/x86/intel/pmt/telemetry.c
> +++ b/drivers/platform/x86/intel/pmt/telemetry.c
> @@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
>  	 * reserved for future use. They have zero size. Do not fail
>  	 * probe for these. Just ignore them.
>  	 */
> -	if (header->size == 0)
> +	if (header->size == 0 || header->access_type == 0xF)
>  		return 1;
>  
>  	return 0;

Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

--8323329-53251890-1681380792=:1987--