Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2237852rwl; Thu, 13 Apr 2023 03:47:41 -0700 (PDT) X-Google-Smtp-Source: AKy350ZNGiowAyjhFVacV4AVbJFRW4ZYofQuTqn5XmjvedV7CIFR2f6a0K3uYePsjngOP8fRN4N3 X-Received: by 2002:a05:6a00:2ea7:b0:63b:158d:ca4 with SMTP id fd39-20020a056a002ea700b0063b158d0ca4mr3153914pfb.5.1681382861002; Thu, 13 Apr 2023 03:47:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681382860; cv=none; d=google.com; s=arc-20160816; b=V+t6ZhNiQ7cKmFzinHBDb76ItfYo1PgOQI0W/NoRKn61GxhYkPQWQKM6co5/uWTJiZ 27jaZ3ZCERvpWwTGZSAdIN7MNEMqG1pnuSCZ19UXVV8wsaZPiJJqYxJ26vUTSifj3D5S n3pTRz0DfDgwhSjMlCWEB1jsC0z3N7nIe37axAzERf6ajerk6ePcIOBGIOB2BjEkQO7X 5rCNYRO6JTf5QkvtHMuPWwI4nU9fCs1VDiXRQzaXlQOC/GF74Ahdc0oe8UBcGz3QX53J ItROpk/udscMTCZ0qnkY4OnKwEKpmYAnMhDhfhur45xBH2iwIJy5bHeeW2G73YGdp2xw h5gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=PRmU1UOn8b5dubK28JOLEnSxE8xtD2PQEvlIOjmwKlc=; b=juLVhrI5VLdNNg6jW6WPF4Tady5KfhkNb2GVOEegmkbckI18F9uEeQhFMbBdA6bIDg hpwxyZsZWZ15oG3gMcxdUax83mzxua3k/lhpmzli8OaE9noQgFEYiNjXxn71tde9BYGO +egUaAXtexZCt6xJiovy29Qq3bTkYRGo35bRUOpM39gkydh/7MZ8bjsXd/3KiVj2f2UQ 7Yp1tvsFpWFVUdltxmoZbEzDPxZm1cRYKzFOY7Bs5fhlvNL15KCSfJp5vNCZ0IFczuZl SG1Rq+xX6DUlulqyq3xyTBV7yKTQqJCggt28CbGD/Zta3RDQkWv3X+H7t8IcL9Cp8HsF etCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=YZhAicgB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=bH+VKwUA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i28-20020a056a00005c00b0063984bcddbbsi1506976pfk.62.2023.04.13.03.47.30; Thu, 13 Apr 2023 03:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=YZhAicgB; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=bH+VKwUA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbjDMKe7 (ORCPT + 99 others); Thu, 13 Apr 2023 06:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230394AbjDMKe4 (ORCPT ); Thu, 13 Apr 2023 06:34:56 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB0930FB; Thu, 13 Apr 2023 03:34:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90BC61F383; Thu, 13 Apr 2023 10:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681382088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PRmU1UOn8b5dubK28JOLEnSxE8xtD2PQEvlIOjmwKlc=; b=YZhAicgBQ8IEqcLhF69qcmhxbTpTCqxT4IwvnVHg+An0NjGNp8IrFc5cewA0IyrOwZyjUw J9c/a+xjjxNzG7+bPEgNI2owhaf6s/RSf4Qbw9iYPUS/2rgAUIzIvAtc/8zZ8GrWFbD+ni DjXL2M8Eriw6mmibztYfUvkg6gQSXw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681382088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PRmU1UOn8b5dubK28JOLEnSxE8xtD2PQEvlIOjmwKlc=; b=bH+VKwUAk2J4eiCwYA36BbIXQ/qLuhvWxxHR68EjjNjXqtASau2YdBXqLPjMrbAljka3uq gbYGQuNNJVbkGIBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 817731390E; Thu, 13 Apr 2023 10:34:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 582RH8jaN2SnTgAAMHmgww (envelope-from ); Thu, 13 Apr 2023 10:34:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 04640A0732; Thu, 13 Apr 2023 12:34:47 +0200 (CEST) Date: Thu, 13 Apr 2023 12:34:47 +0200 From: Jan Kara To: Baokun Li Cc: Jan Kara , linux-ext4@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, ritesh.list@gmail.com, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v3 2/8] ext4: add a new helper to check if es must be kept Message-ID: <20230413103447.br5wgi6zhaaarcaz@quack3> References: <20230412124126.2286716-1-libaokun1@huawei.com> <20230412124126.2286716-3-libaokun1@huawei.com> <20230412185300.rpfwdlxeiptqaxes@quack3> <22b3bfef-7a47-036d-125b-180040a0c743@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22b3bfef-7a47-036d-125b-180040a0c743@huawei.com> X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 13-04-23 10:00:56, Baokun Li wrote: > Can you please help review the remaining patches for any problems? > If you have any suggestions, I'll fix them together and post another version > of v4. Yes, I've got a bit stuck thinking about the GFP_NOFAIL problem and how to best solve it. It will require some changes but most of the patchset can stay I believe. Honza -- Jan Kara SUSE Labs, CR