Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759532AbXIZNpS (ORCPT ); Wed, 26 Sep 2007 09:45:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754821AbXIZNpE (ORCPT ); Wed, 26 Sep 2007 09:45:04 -0400 Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:57026 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204AbXIZNpB (ORCPT ); Wed, 26 Sep 2007 09:45:01 -0400 Date: Wed, 26 Sep 2007 09:44:15 -0400 Message-Id: <200709261344.l8QDiFdw025498@agora.fsl.cs.sunysb.edu> From: Erez Zadok To: Christoph Hellwig Cc: Erez Zadok , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk Subject: Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting In-reply-to: Your message of "Wed, 26 Sep 2007 09:31:21 BST." <20070926083121.GA8421@infradead.org> X-MailKey: Erez_Zadok Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 16 In message <20070926083121.GA8421@infradead.org>, Christoph Hellwig writes: > On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote: > > Fixes bugs in number promotion/demotion computation, as per > > > > It's better to use te page_offset helper as that avoids any confusion > on where to cast. Excellent. Will do. Erez. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/