Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 14:06:24 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        linux-fsdevel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: fix sysctls.c built
Message-ID: <20230413-gepfiffen-hochphase-e98047bd16bd@brauner>
References: <20230331084502.155284-1-wangkefeng.wang@huawei.com>
 <66c0e8b6-64d1-5be6-cd4d-9700d84e1b84@huawei.com>
 <20230412-sympathie-haltbar-da2d2183067b@brauner>
 <a01a789c-8965-d1dc-cb45-ea9901a9af34@huawei.com>
 <20230413-kufen-infekt-02c7eb2a9adc@brauner>
 <3c98309c-eb56-1aee-5a6a-8f0a4c84d378@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3c98309c-eb56-1aee-5a6a-8f0a4c84d378@huawei.com>
Precedence: bulk

On Thu, Apr 13, 2023 at 05:45:20PM +0800, Kefeng Wang wrote:
> 
> 
> On 2023/4/13 16:35, Christian Brauner wrote:
> > On Thu, Apr 13, 2023 at 09:34:54AM +0800, Kefeng Wang wrote:
> > > 
> > > 
> > > On 2023/4/12 17:19, Christian Brauner wrote:
> > > > On Tue, Apr 11, 2023 at 12:14:44PM +0800, Kefeng Wang wrote:
> > > > > /proc/sys/fs/overflowuid and overflowgid  will be lost without
> > > > > building this file, kindly ping, any comments, thanks.
> > > > > 
> > > > > 
> > > > > On 2023/3/31 16:45, Kefeng Wang wrote:
> > > > > > 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=",
> > > > > > or it won't be built as it is overwrited.
> > > 
> > > ...
> > > 
> > > > Given the description in
> > > > ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
> > > > you probably want to move this earlier.
> > > 
> > > Oh, missing that part, but the /proc/sys/fs/overflowuid and overflowgid are
> > > lost after it, is it expected? Luis, could you take a look? thanks.
> > 
> > No, /proc/sys/fs/overflow{g,u}id need to be there of course. What I mean
> > is something like the following (similar to how net/core/ does it):
> > 
> 
> Thanks for your explanation,
> 
> > UNTESTED
> 
> Will try,
> 
> > ---
> >   fs/Makefile | 24 +++++++++++++-----------
> >   1 file changed, 13 insertions(+), 11 deletions(-)
> > 
> > diff --git a/fs/Makefile b/fs/Makefile
> > index 05f89b5c962f..dfaea8a28d92 100644
> > --- a/fs/Makefile
> > +++ b/fs/Makefile
> > @@ -6,17 +6,19 @@
> >   # Rewritten to use lists instead of if-statements.
> >   #
> > 
> > -obj-$(CONFIG_SYSCTL)           += sysctls.o
> > -
> > -obj-y :=       open.o read_write.o file_table.o super.o \
> > -               char_dev.o stat.o exec.o pipe.o namei.o fcntl.o \
> > -               ioctl.o readdir.o select.o dcache.o inode.o \
> > -               attr.o bad_inode.o file.o filesystems.o namespace.o \
> > -               seq_file.o xattr.o libfs.o fs-writeback.o \
> > -               pnode.o splice.o sync.o utimes.o d_path.o \
> > -               stack.o fs_struct.o statfs.o fs_pin.o nsfs.o \
> > -               fs_types.o fs_context.o fs_parser.o fsopen.o init.o \
> > -               kernel_read_file.o mnt_idmapping.o remap_range.o
> > +obj-y                  := fs_types.o
> > +obj-$(CONFIG_SYSCTL)   += sysctls.o
> > +obj-y                  += open.o read_write.o file_table.o super.o \
> > +                          char_dev.o stat.o exec.o pipe.o namei.o \
> > +                          fcntl.o ioctl.o readdir.o select.o dcache.o \
> > +                          inode.o attr.o bad_inode.o file.o \
> > +                          filesystems.o namespace.o seq_file.o \
> > +                          xattr.o libfs.o fs-writeback.o pnode.o \
> > +                          splice.o sync.o utimes.o d_path.o stack.o \
> > +                          fs_struct.o statfs.o fs_pin.o nsfs.o \
> > +                          fs_types.o fs_context.o fs_parser.o \
> 
> drop this fs_types.o ?

Yes.