Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31659e74-661b-8bd3-e64e-33ac6d24f577@foss.st.com>
Date:   Thu, 13 Apr 2023 15:04:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] drm/stm: ltdc: fix late dereference check
To:     Raphael GALLAIS-POU <gallais1@gnb.st.com>,
        Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>,
        Philippe Cornu <philippe.cornu@foss.st.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
CC:     <dri-devel@lists.freedesktop.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>,
        Dan Carpenter <error27@gmail.com>
References: <20230412092553.279185-1-raphael.gallais-pou@foss.st.com>
Content-Language: en-US
From:   Yannick FERTRE <yannick.fertre@foss.st.com>
In-Reply-To: <20230412092553.279185-1-raphael.gallais-pou@foss.st.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Raphael,

thanks for the patch.

Reviewed-by: Yannick Fertre <yannick.fertre@foss.st.com>


On 4/12/23 11:25, Raphael GALLAIS-POU wrote:
> Attention: Sender not authenticated
> --------------------------------------------------
>
> In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a
> container_of() before the pointer check. This could cause a kernel panic.
>
> Fix this smatch warning:
> drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable dereferenced before check 'crtc' (see line 1119)
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/lkml/202212241802.zeLFZCXB-lkp@intel.com/
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 03c6becda795..b8be4c1db423 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1145,7 +1145,7 @@ static void ltdc_crtc_disable_vblank(struct drm_crtc *crtc)
>
>   static int ltdc_crtc_set_crc_source(struct drm_crtc *crtc, const char *source)
>   {
> -       struct ltdc_device *ldev = crtc_to_ltdc(crtc);
> +       struct ltdc_device *ldev;
>          int ret;
>
>          DRM_DEBUG_DRIVER("\n");
> @@ -1153,6 +1153,8 @@ static int ltdc_crtc_set_crc_source(struct drm_crtc *crtc, const char *source)
>          if (!crtc)
>                  return -ENODEV;
>
> +       ldev = crtc_to_ltdc(crtc);
> +
>          if (source && strcmp(source, "auto") == 0) {
>                  ldev->crc_active = true;
>                  ret = regmap_set_bits(ldev->regmap, LTDC_GCR, GCR_CRCEN);
> --
> 2.25.1
>