Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "jiri@resnulli.us" <jiri@resnulli.us>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: RE: [RFC PATCH v1] ice: add CGU info to devlink info callback
Thread-Topic: [RFC PATCH v1] ice: add CGU info to devlink info callback
Thread-Index: AQHZbURL//7N1kf7H06LoNzMTKXBn68ol1EAgACoMpA=
Date:   Thu, 13 Apr 2023 13:43:52 +0000
Message-ID: <DM6PR11MB46577E14FE17ADA6D1E74E789B989@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230412133811.2518336-1-arkadiusz.kubalewski@intel.com>
 <20230412203500.36fb7c36@kernel.org>
In-Reply-To: <20230412203500.36fb7c36@kernel.org>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uBUQZ+OGATfGJVfHOVIgCMWlToDB1Cawo5F10j7gykg2CG8tz1SpWkYOBW6Q?=
 =?us-ascii?Q?uMlqyPV2PisGTxw8T7PoRiIzliaP5I9CX3QFXhdMpb+j6qldBhV38Jb/z7C3?=
 =?us-ascii?Q?PX0hECER6SrQ/ID9ZwTdXvyzGnlGWd2817vtSQZyaxSZ8p7LtkTj/I7fHDW7?=
 =?us-ascii?Q?OYgmoUjN5i6fyusdmkIVTWqDPUGBI7/CaO5ow09OKTD6l4sD2pM2tBcb1FwK?=
 =?us-ascii?Q?XcR3ROReXyfudQsOngALA/tH1lKff7U5z+WFW0efZeiE1QK9cIpIZwHmOkj2?=
 =?us-ascii?Q?v9tVbkMC8O34sb2YwDmsnNAFW05vW0xCQYQ77yhZx++MEhm/MGoWqunSRpoG?=
 =?us-ascii?Q?FrKD9CW4R1VadMpD4SK6joGq0mDfyhC2l0GhqHxpawFEN9F+E1ytd27R9MYo?=
 =?us-ascii?Q?zxyuxIeR8Mtz1TyAknDPjZgiNvMful8r+/TH33kisuwr5R7ZgksX6xWdmyhb?=
 =?us-ascii?Q?eZfvQ1BokHslxETcdrRnoBh7wnWZhtrmg7hK+SdatYB88JWY34UTC8XKR/zB?=
 =?us-ascii?Q?bG2OZEAz3MOFyMTiZoRXgr3C7ykHjysmiCrTFNtc6AZ6sm5J015iouN8q97v?=
 =?us-ascii?Q?BacNDQZicdR05EzNYCvrH+3JwY8bRO456x2t/jSg/naixlvMk6fluyl8S6yW?=
 =?us-ascii?Q?Ewwmb/CSJPzy+3DXkVlXzAl5m7k21H6iOsNi64yUfYO8JXne8SdSc7mQmNDg?=
 =?us-ascii?Q?v0hftvOVtq6dLj6V9HNJQIdlr47QjDwcULVirmWOcs/7WK3qITFj+3/T8ghO?=
 =?us-ascii?Q?5cw2JMsQJ/xR8+WgDmNqBrwUdzQ8P1IQJkfZlwlDnfSCqsj5A4WDyI2N/P/u?=
 =?us-ascii?Q?sRaLd7mUWtjdLVHX3bPYHpiE31Ge/sFMlnlL7nYJaePfoZ8Vj/iFHuz8TsJ5?=
 =?us-ascii?Q?SlbrjI2ApZm4FXDlbmQXV0qBVn+LJUXE45gw9B7PPCLhdu7gXEU/KuWpLkZd?=
 =?us-ascii?Q?cPoGVMXEbR7QtizBv7Mhob5D+O3PC5SeQkevOhmI7LcraJ/FgGWmys/E6X7i?=
 =?us-ascii?Q?PD5M/doowmK5u4iTYOaByO4RMA9KF8T7ngIPXvl/MJPXhcqGtgHsj0G6UHRF?=
 =?us-ascii?Q?c4jrcq9jPAgrPtn6bRSTRycMPxlJjT5JM97iasdFwWSdzgROdtGt0geKHwkT?=
 =?us-ascii?Q?9KZYS/U1baAPSYfJZl8LZvnDVEK9ZeRBkIQBHrWePrayZg6u0GH7/jxeYnNX?=
 =?us-ascii?Q?fn78jL2NOGIderjHhys5yzb9HzSec4y6omh0xWZhj0K3G4VAtiY2Xawacbwj?=
 =?us-ascii?Q?TYXwDx7xhlnbC0xbJ0qTyUqjXViuDZCXtYz6etANc5xVCmLBObf/ZX7c3x5f?=
 =?us-ascii?Q?0MpuGZKaZNdi8SrhXrMy0qc9lr9+zVARSd5U56oJAhJ01GHUdSEmDuxVnls0?=
 =?us-ascii?Q?ouu2njPmD3/7I4jCT2s8Pyg0yx0xos4mNtMvdwIBJjPQLKg3nc8bgL7GzMqz?=
 =?us-ascii?Q?jDbUlgYX3ZKL/HDOmWUk/9RXQMxKEhC9gyX1FAmpwWKan1heDR9ZbY2VNqbt?=
 =?us-ascii?Q?blFUxlvlh83fH/lir/ym5h0+vu+IK2IEgqhs5sMV1kiH6ij0BRJR8yR7wIGY?=
 =?us-ascii?Q?5wkOyYlrvl0It2my3yY3YaXt0sr6blaufP83K4H0sOYle3dZUr2+32uUI1Jd?=
 =?us-ascii?Q?/Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e724ec1-0654-4d66-5744-08db3c251e7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2023 13:43:52.5901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UVsSGCjZKUgJXoByPHEH6+QZ+TI8Ur88Ck78xLToOpTT8BY4PB7s5dPtnKyF+s/bMbJx254dhsja3NgYNOvZ8UCo/28Cy7Kf/g1koK4N6s0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8118
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Thursday, April 13, 2023 5:35 AM
>
>On Wed, 12 Apr 2023 15:38:11 +0200 Arkadiusz Kubalewski wrote:
>> If Clock Generation Unit and dplls are present on NIC board user shall
>> know its details.
>> Provide the devlink info callback with a new:
>> - fixed type object `cgu.id` - hardware variant of onboard CGU
>> - running type object `fw.cgu` - CGU firmware version
>> - running type object `fw.cgu.build` - CGU configuration build version
>>
>> These information shall be known for debugging purposes.
>>
>> Test (on NIC board with CGU)
>> $ devlink dev info <bus_name>/<dev_name> | grep cgu
>>         cgu.id 8032
>>         fw.cgu 6021
>>         fw.cgu.build 0x1030001
>>
>> Test (on NIC board without CGU)
>> $ devlink dev info <bus_name>/<dev_name> | grep cgu -c
>> 0
>>
>> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>
>Is it flashed together with the rest of the FW components of the NIC?
>Or the update method is different?

Right now there is no mechanics for CGU firmware update at all, this is why=
 I
mention that this is for now mostly for debugging purposes.
There are already some works ongoing to have CGU FW update possible, first =
with
Intel's nvmupdate packages and tools. But, for Linux we probably also gonna
need to support update through devlink, at least this seems right thing to =
do,
as there is already possibility to update NIC firmware with devlink.

Thank you!
Arkadiusz