Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Apr 2023 16:03:07 +0200 (CEST)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Peter Zijlstra <peterz@infradead.org>
cc:     Josh Poimboeuf <jpoimboe@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] objtool: Add verbose option for disassembling
 affected functions
In-Reply-To: <20230413080822.GH4253@hirez.programming.kicks-ass.net>
Message-ID: <alpine.LSU.2.21.2304131602150.27633@pobox.suse.cz>
References: <cover.1681325924.git.jpoimboe@kernel.org> <4cadacc719db1e792c335309056960ca6f71139e.1681325924.git.jpoimboe@kernel.org> <20230413080822.GH4253@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 13 Apr 2023, Peter Zijlstra wrote:

> On Wed, Apr 12, 2023 at 12:03:20PM -0700, Josh Poimboeuf wrote:
> > +	objdump_str = "%sobjdump -wdr %s | gawk -M -v _funcs='%s' '"
> > +			"BEGIN { split(_funcs, funcs); }"
> > +			"/^$/ { func_match = 0; }"
> > +			"/<.*>:/ { "
> > +				"f = gensub(/.*<(.*)>:/, \"\\\\1\", 1);"
> > +				"for (i in funcs) {"
> > +					"if (funcs[i] == f) {"
> > +						"func_match = 1;"
> > +						"base = strtonum(\"0x\" $1);"
> > +						"break;"
> > +					"}"
> > +				"}"
> > +			"}"
> > +			"{"
> > +				"if (func_match) {"
> > +					"addr = strtonum(\"0x\" $1);"
> > +					"printf(\"%%04x \", addr - base);"
> > +					"print;"
> > +				"}"
> > +			"}' 1>&2";
> 
> Do we want to have scripts/objdump-func.awk and use that to avoid the
> duplication and eventual divergence of these awk thingies?

I vote for that as well. To keep everything in sync can be a nightmare.

Miroslav